Re: [PATCH] radeon_display: Use pointer return error codes

2013-01-23 Thread Alex Deucher 
On Tue, Jan 22, 2013 at 9:27 PM, Su, Xuemin  wrote:
> From: xueminsu 
> Date: Tue, 22 Jan 2013 22:16:53 +0800
> Subject: [PATCH] radeon_display: Use pointer return error codes
>
> drm_mode_addfb() expects fb_create return error code
> instead of NULL.
>
> Signed-off-by: xueminsu 

Thanks.  Added to my fixes queue.

Alex


> ---
>  drivers/gpu/drm/radeon/radeon_display.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c 
> b/drivers/gpu/drm/radeon/radeon_display.c
> index 1da2386..ff3def7 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> if (ret) {
> kfree(radeon_fb);
> drm_gem_object_unreference_unlocked(obj);
> -   return NULL;
> +   return ERR_PTR(ret);
> }
>
> return _fb->base;
> --
> 1.7.6
>
>
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] radeon_display: Use pointer return error codes

2013-01-23 Thread Alex Deucher 
On Tue, Jan 22, 2013 at 9:27 PM, Su, Xuemin xuemin...@intel.com wrote:
 From: xueminsu xuemin...@intel.com
 Date: Tue, 22 Jan 2013 22:16:53 +0800
 Subject: [PATCH] radeon_display: Use pointer return error codes

 drm_mode_addfb() expects fb_create return error code
 instead of NULL.

 Signed-off-by: xueminsu xuemin...@intel.com

Thanks.  Added to my fixes queue.

Alex


 ---
  drivers/gpu/drm/radeon/radeon_display.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/drivers/gpu/drm/radeon/radeon_display.c 
 b/drivers/gpu/drm/radeon/radeon_display.c
 index 1da2386..ff3def7 100644
 --- a/drivers/gpu/drm/radeon/radeon_display.c
 +++ b/drivers/gpu/drm/radeon/radeon_display.c
 @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
 if (ret) {
 kfree(radeon_fb);
 drm_gem_object_unreference_unlocked(obj);
 -   return NULL;
 +   return ERR_PTR(ret);
 }

 return radeon_fb-base;
 --
 1.7.6



 ___
 dri-devel mailing list
 dri-de...@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] radeon_display: Use pointer return error codes

2013-01-22 Thread Su, Xuemin 
From: xueminsu 
Date: Tue, 22 Jan 2013 22:16:53 +0800
Subject: [PATCH] radeon_display: Use pointer return error codes

drm_mode_addfb() expects fb_create return error code
instead of NULL.

Signed-off-by: xueminsu 
---
 drivers/gpu/drm/radeon/radeon_display.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c 
b/drivers/gpu/drm/radeon/radeon_display.c
index 1da2386..ff3def7 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
if (ret) {
kfree(radeon_fb);
drm_gem_object_unreference_unlocked(obj);
-   return NULL;
+   return ERR_PTR(ret);
}
 
return _fb->base;
-- 
1.7.6



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] radeon_display: Use pointer return error codes

2013-01-22 Thread Su, Xuemin 
From: xueminsu xuemin...@intel.com
Date: Tue, 22 Jan 2013 22:16:53 +0800
Subject: [PATCH] radeon_display: Use pointer return error codes

drm_mode_addfb() expects fb_create return error code
instead of NULL.

Signed-off-by: xueminsu xuemin...@intel.com
---
 drivers/gpu/drm/radeon/radeon_display.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c 
b/drivers/gpu/drm/radeon/radeon_display.c
index 1da2386..ff3def7 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
if (ret) {
kfree(radeon_fb);
drm_gem_object_unreference_unlocked(obj);
-   return NULL;
+   return ERR_PTR(ret);
}
 
return radeon_fb-base;
-- 
1.7.6



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/