Re: [RFC PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-24 Thread Jiri Slaby
On 08/22/2012 04:44 PM, Alan Cox wrote: > Jiri - this seem more sensible ? I would be faster if you CCed me :). > From: Alan Cox > > These are used with the tty_port flags which are tty generic so move the > flags into a more sensible place. This then makes it possible to add > helpers such as

Re: [RFC PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-24 Thread Jiri Slaby
On 08/22/2012 04:44 PM, Alan Cox wrote: Jiri - this seem more sensible ? I would be faster if you CCed me :). From: Alan Cox a...@linux.intel.com These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add

[RFC PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Alan Cox
Jiri - this seem more sensible ? From: Alan Cox These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add helpers such as those suggested by Huang Shijie. Signed-off-by: Alan Cox --- include/linux/Kbuild

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Jiri Slaby
On 08/21/2012 03:35 PM, Alan Cox wrote: > From: Alan Cox > > These are used with the tty_port flags which are tty generic so move the > flags into a more sensible place. This then makes it possible to add > helpers such as those suggested by Huang Shijie. Yes, the idea looks good to me. I was

[PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Alan Cox
From: Alan Cox These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add helpers such as those suggested by Huang Shijie. Signed-off-by: Alan Cox --- include/linux/serial.h|2 + include/linux/tty.h

[PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Alan Cox
From: Alan Cox a...@linux.intel.com These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add helpers such as those suggested by Huang Shijie. Signed-off-by: Alan Cox a...@linux.intel.com ---

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Jiri Slaby
On 08/21/2012 03:35 PM, Alan Cox wrote: From: Alan Cox a...@linux.intel.com These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add helpers such as those suggested by Huang Shijie. Yes, the idea looks good

[RFC PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-22 Thread Alan Cox
Jiri - this seem more sensible ? From: Alan Cox a...@linux.intel.com These are used with the tty_port flags which are tty generic so move the flags into a more sensible place. This then makes it possible to add helpers such as those suggested by Huang Shijie. Signed-off-by: Alan Cox

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Huang Shijie
On Tue, Aug 21, 2012 at 9:35 PM, Alan Cox wrote: > Huang - how about we add this patch first which moves the flags somewhere > more sensible > and then your helper function (and probably a few others) would merge cleanly > ? > Allen, Could you post a formal patch? I can change my patch based on

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Huang Shijie
On Tue, Aug 21, 2012 at 9:35 PM, Alan Cox wrote: > Huang - how about we add this patch first which moves the flags somewhere > more sensible thanks. I am really happy with this patch. Huang Shijie > and then your helper function (and probably a few others) would merge cleanly > ? > > Alan >

[PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Alan Cox
Huang - how about we add this patch first which moves the flags somewhere more sensible and then your helper function (and probably a few others) would merge cleanly ? Alan -- From: Alan Cox These are used with the tty_port flags which are tty generic so move the flags into a more sensible

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Huang Shijie
On Tue, Aug 21, 2012 at 9:35 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: Huang - how about we add this patch first which moves the flags somewhere more sensible and then your helper function (and probably a few others) would merge cleanly ? Allen, Could you post a formal patch? I can

[PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Alan Cox
Huang - how about we add this patch first which moves the flags somewhere more sensible and then your helper function (and probably a few others) would merge cleanly ? Alan -- From: Alan Cox a...@linux.intel.com These are used with the tty_port flags which are tty generic so move the flags

Re: [PATCH] tty: move the async flags from the serial code into the tty includes

2012-08-21 Thread Huang Shijie
On Tue, Aug 21, 2012 at 9:35 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: Huang - how about we add this patch first which moves the flags somewhere more sensible thanks. I am really happy with this patch. Huang Shijie and then your helper function (and probably a few others) would merge