Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-18 Thread Corey Minyard
On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote: On 17/01/18 22:25, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Alexey

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-18 Thread Corey Minyard
On 01/17/2018 10:04 PM, Alexey Kardashevskiy wrote: On 17/01/18 22:25, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun Reviewed-by: Alexey Kardashevskiy Queued

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Alexey Kardashevskiy
On 17/01/18 22:25, Wei Yongjun wrote: > Fix to return a negative error code from the request_irq() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Reviewed-by: Alexey Kardashevskiy > --- >

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Alexey Kardashevskiy
On 17/01/18 22:25, Wei Yongjun wrote: > Fix to return a negative error code from the request_irq() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Reviewed-by: Alexey Kardashevskiy > --- > drivers/char/ipmi/ipmi_powernv.c | 5 +++-- >

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Corey Minyard
On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Corey Minyard
On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and

[PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Wei Yongjun
Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_powernv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Wei Yongjun
Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/char/ipmi/ipmi_powernv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git