Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-08-06 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > On Mon, 2007-07-30 at 11:27 +0200, Ingo Molnar wrote: > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof > > > { > > > __do_raise_softirq_irqoff(nr); > > > > > > +#ifdef

Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-08-06 Thread Ingo Molnar
* Daniel Walker [EMAIL PROTECTED] wrote: On Mon, 2007-07-30 at 11:27 +0200, Ingo Molnar wrote: * Daniel Walker [EMAIL PROTECTED] wrote: @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof { __do_raise_softirq_irqoff(nr); +#ifdef CONFIG_PREEMPT_SOFTIRQS

Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-30 Thread Daniel Walker
On Mon, 2007-07-30 at 11:27 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof > > { > > __do_raise_softirq_irqoff(nr); > > > > +#ifdef CONFIG_PREEMPT_SOFTIRQS > > wakeup_softirqd(nr); > > +#endif >

Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-30 Thread Ingo Molnar
* Daniel Walker <[EMAIL PROTECTED]> wrote: > @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof > { > __do_raise_softirq_irqoff(nr); > > +#ifdef CONFIG_PREEMPT_SOFTIRQS > wakeup_softirqd(nr); > +#endif thanks, applied. People rarely run the -rt kernel just to turn off

Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-30 Thread Ingo Molnar
* Daniel Walker [EMAIL PROTECTED] wrote: @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof { __do_raise_softirq_irqoff(nr); +#ifdef CONFIG_PREEMPT_SOFTIRQS wakeup_softirqd(nr); +#endif thanks, applied. People rarely run the -rt kernel just to turn off

Re: [PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-30 Thread Daniel Walker
On Mon, 2007-07-30 at 11:27 +0200, Ingo Molnar wrote: * Daniel Walker [EMAIL PROTECTED] wrote: @@ -508,7 +508,9 @@ inline fastcall void raise_softirq_irqof { __do_raise_softirq_irqoff(nr); +#ifdef CONFIG_PREEMPT_SOFTIRQS wakeup_softirqd(nr); +#endif thanks, applied.

[PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-29 Thread Daniel Walker
raise_softirq is called every timer interrupt in run_local_timers(), which causes a thread wakeup to happen every timer interrupt. This happens in !CONFIG_PREEMPT_SOFTIRQS, which means the wakeup is most likely not needed. In addition it also fouls calc_load() since it's, agian, observing at least

[PATCH -rt 4/9] ifdef raise_softirq_irqoff wakeup

2007-07-29 Thread Daniel Walker
raise_softirq is called every timer interrupt in run_local_timers(), which causes a thread wakeup to happen every timer interrupt. This happens in !CONFIG_PREEMPT_SOFTIRQS, which means the wakeup is most likely not needed. In addition it also fouls calc_load() since it's, agian, observing at least