Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On Thu, Apr 30, 2015 at 08:34:36PM +0200, Marek Vasut wrote: > On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote: > > On 30 April 2015 at 18:30, wrote: > > > Hello Michal: > > >> I tried to connect a SPI NOR flash to my sunxi board and due to the > > > > > > current > > > > > >> sunxi SPI driver limitations it does not work. > > >> > > >> The SPI driver returns an error when more than 64 bytes are > > >> transferred at once > > >> due to lack of DMA support. > > > > > > Wouldn't it be easier to fix the SPI driver to handle transfers larger > > > than 64 bytes, filling and draining the FIFO multiple times if > > > neccessary? (As far as I can tell, most SPI drivers do this.) > > > > Yes, the intent is to fix this by adding dma support to the driver, > > eventually. > > > > The patch might be still useful for other hardware with developing SPI > > support. > > Please just fix the controller driver to correctly handle arbitrary transfer > lengths. Just noticed this. Yes, that would definitely be a better option! Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On Thu, Apr 30, 2015 at 08:34:36PM +0200, Marek Vasut wrote: On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote: On 30 April 2015 at 18:30, thomas.bet...@rohde-schwarz.com wrote: Hello Michal: I tried to connect a SPI NOR flash to my sunxi board and due to the current sunxi SPI driver limitations it does not work. The SPI driver returns an error when more than 64 bytes are transferred at once due to lack of DMA support. Wouldn't it be easier to fix the SPI driver to handle transfers larger than 64 bytes, filling and draining the FIFO multiple times if neccessary? (As far as I can tell, most SPI drivers do this.) Yes, the intent is to fix this by adding dma support to the driver, eventually. The patch might be still useful for other hardware with developing SPI support. Please just fix the controller driver to correctly handle arbitrary transfer lengths. Just noticed this. Yes, that would definitely be a better option! Brian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-sunxi] Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Hello, On 1 May 2015 at 14:27, Stefan Monnier wrote: >> The SPI driver returns an error when more than 64 bytes are >> transferred at once due to lack of DMA support. > > Have you tried the dmaengine patch and make the SPI driver use it? > The dmaengine is already merged or queued in sunxi-wip but the SPI glue fell through the cracks. I found it after digging through the archives so I will see if it works for me. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [linux-sunxi] Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Hello, On 1 May 2015 at 14:27, Stefan Monnier monn...@iro.umontreal.ca wrote: The SPI driver returns an error when more than 64 bytes are transferred at once due to lack of DMA support. Have you tried the dmaengine patch and make the SPI driver use it? The dmaengine is already merged or queued in sunxi-wip but the SPI glue fell through the cracks. I found it after digging through the archives so I will see if it works for me. Thanks Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote: > On 30 April 2015 at 18:30, wrote: > > Hello Michal: > >> I tried to connect a SPI NOR flash to my sunxi board and due to the > > > > current > > > >> sunxi SPI driver limitations it does not work. > >> > >> The SPI driver returns an error when more than 64 bytes are > >> transferred at once > >> due to lack of DMA support. > > > > Wouldn't it be easier to fix the SPI driver to handle transfers larger > > than 64 bytes, filling and draining the FIFO multiple times if > > neccessary? (As far as I can tell, most SPI drivers do this.) > > Yes, the intent is to fix this by adding dma support to the driver, > eventually. > > The patch might be still useful for other hardware with developing SPI > support. Please just fix the controller driver to correctly handle arbitrary transfer lengths. Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On 30 April 2015 at 18:30, wrote: > Hello Michal: > >> I tried to connect a SPI NOR flash to my sunxi board and due to the > current >> sunxi SPI driver limitations it does not work. >> >> The SPI driver returns an error when more than 64 bytes are >> transferred at once >> due to lack of DMA support. > > Wouldn't it be easier to fix the SPI driver to handle transfers larger > than 64 bytes, filling and draining the FIFO multiple times if neccessary? > (As far as I can tell, most SPI drivers do this.) > Yes, the intent is to fix this by adding dma support to the driver, eventually. The patch might be still useful for other hardware with developing SPI support. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Hello Michal: > I tried to connect a SPI NOR flash to my sunxi board and due to the current > sunxi SPI driver limitations it does not work. > > The SPI driver returns an error when more than 64 bytes are > transferred at once > due to lack of DMA support. Wouldn't it be easier to fix the SPI driver to handle transfers larger than 64 bytes, filling and draining the FIFO multiple times if neccessary? (As far as I can tell, most SPI drivers do this.) Just asking, Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Hello Michal: I tried to connect a SPI NOR flash to my sunxi board and due to the current sunxi SPI driver limitations it does not work. The SPI driver returns an error when more than 64 bytes are transferred at once due to lack of DMA support. Wouldn't it be easier to fix the SPI driver to handle transfers larger than 64 bytes, filling and draining the FIFO multiple times if neccessary? (As far as I can tell, most SPI drivers do this.) Just asking, Thomas -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On 30 April 2015 at 18:30, thomas.bet...@rohde-schwarz.com wrote: Hello Michal: I tried to connect a SPI NOR flash to my sunxi board and due to the current sunxi SPI driver limitations it does not work. The SPI driver returns an error when more than 64 bytes are transferred at once due to lack of DMA support. Wouldn't it be easier to fix the SPI driver to handle transfers larger than 64 bytes, filling and draining the FIFO multiple times if neccessary? (As far as I can tell, most SPI drivers do this.) Yes, the intent is to fix this by adding dma support to the driver, eventually. The patch might be still useful for other hardware with developing SPI support. Thanks Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote: On 30 April 2015 at 18:30, thomas.bet...@rohde-schwarz.com wrote: Hello Michal: I tried to connect a SPI NOR flash to my sunxi board and due to the current sunxi SPI driver limitations it does not work. The SPI driver returns an error when more than 64 bytes are transferred at once due to lack of DMA support. Wouldn't it be easier to fix the SPI driver to handle transfers larger than 64 bytes, filling and draining the FIFO multiple times if neccessary? (As far as I can tell, most SPI drivers do this.) Yes, the intent is to fix this by adding dma support to the driver, eventually. The patch might be still useful for other hardware with developing SPI support. Please just fix the controller driver to correctly handle arbitrary transfer lengths. Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
