Re: [PATCH 0/5] perf tool: Fix enable/disable events logic for record command

2012-11-12 Thread Namhyung Kim
On Mon, 12 Nov 2012 18:33:59 +0100, Jiri Olsa wrote:
> hi,
> this patchset fixes the event enable/disable logic for record command
> (patches 1 - 4) plus small fix for event parsing (patch 5).
>
> Attached patches:
>   1/5 perf tool: Fix attributes for '{}' defined event groups
>   2/5 perf tool: Fix 'disabled' attribute config for record command
>   3/5 perf tool: Ensure single disable call per event in record comand
>   4/5 perf tool: Omit group members from perf_evlist__disable/enable
>   5/5 perf tool: Add basic event modifier sanity check
>
> Also available in:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git
> perf/enable5
>
> thanks,
> jirka
>
> Cc: Corey Ashford 
> Cc: Frederic Weisbecker 
> Cc: Ingo Molnar 
> Cc: Namhyung Kim 
> Cc: Paul Mackerras 
> Cc: Peter Zijlstra 
> Cc: Arnaldo Carvalho de Melo 

I commented on the patch 5/5, anyway looks good to me:

Acked-by: Namhyung Kim 

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 0/5] perf tool: Fix enable/disable events logic for record command

2012-11-12 Thread Jiri Olsa
hi,
this patchset fixes the event enable/disable logic for record command
(patches 1 - 4) plus small fix for event parsing (patch 5).

Attached patches:
  1/5 perf tool: Fix attributes for '{}' defined event groups
  2/5 perf tool: Fix 'disabled' attribute config for record command
  3/5 perf tool: Ensure single disable call per event in record comand
  4/5 perf tool: Omit group members from perf_evlist__disable/enable
  5/5 perf tool: Add basic event modifier sanity check

Also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git
perf/enable5

thanks,
jirka

Cc: Corey Ashford 
Cc: Frederic Weisbecker 
Cc: Ingo Molnar 
Cc: Namhyung Kim 
Cc: Paul Mackerras 
Cc: Peter Zijlstra 
Cc: Arnaldo Carvalho de Melo 
---
 tools/perf/builtin-record.c   | 26 ++
 tools/perf/builtin-stat.c | 11 ---
 tools/perf/tests/attr/test-record-group   |  1 +
 tools/perf/tests/attr/test-record-group1  |  5 ++---
 tools/perf/tests/attr/test-stat-group1|  6 ++
 tools/perf/tests/open-syscall-tp-fields.c |  2 +-
 tools/perf/util/evlist.c  | 10 ++
 tools/perf/util/evsel.c   | 50 
--
 tools/perf/util/evsel.h   |  3 +--
 tools/perf/util/parse-events.c| 20 
 tools/perf/util/parse-events.l|  2 +-
 11 files changed, 104 insertions(+), 32 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 0/5] perf tool: Fix enable/disable events logic for record command

2012-11-12 Thread Jiri Olsa
hi,
this patchset fixes the event enable/disable logic for record command
(patches 1 - 4) plus small fix for event parsing (patch 5).

Attached patches:
  1/5 perf tool: Fix attributes for '{}' defined event groups
  2/5 perf tool: Fix 'disabled' attribute config for record command
  3/5 perf tool: Ensure single disable call per event in record comand
  4/5 perf tool: Omit group members from perf_evlist__disable/enable
  5/5 perf tool: Add basic event modifier sanity check

Also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git
perf/enable5

thanks,
jirka

Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Namhyung Kim namhy...@kernel.org
Cc: Paul Mackerras pau...@samba.org
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Arnaldo Carvalho de Melo a...@redhat.com
---
 tools/perf/builtin-record.c   | 26 ++
 tools/perf/builtin-stat.c | 11 ---
 tools/perf/tests/attr/test-record-group   |  1 +
 tools/perf/tests/attr/test-record-group1  |  5 ++---
 tools/perf/tests/attr/test-stat-group1|  6 ++
 tools/perf/tests/open-syscall-tp-fields.c |  2 +-
 tools/perf/util/evlist.c  | 10 ++
 tools/perf/util/evsel.c   | 50 
--
 tools/perf/util/evsel.h   |  3 +--
 tools/perf/util/parse-events.c| 20 
 tools/perf/util/parse-events.l|  2 +-
 11 files changed, 104 insertions(+), 32 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 0/5] perf tool: Fix enable/disable events logic for record command

2012-11-12 Thread Namhyung Kim
On Mon, 12 Nov 2012 18:33:59 +0100, Jiri Olsa wrote:
 hi,
 this patchset fixes the event enable/disable logic for record command
 (patches 1 - 4) plus small fix for event parsing (patch 5).

 Attached patches:
   1/5 perf tool: Fix attributes for '{}' defined event groups
   2/5 perf tool: Fix 'disabled' attribute config for record command
   3/5 perf tool: Ensure single disable call per event in record comand
   4/5 perf tool: Omit group members from perf_evlist__disable/enable
   5/5 perf tool: Add basic event modifier sanity check

 Also available in:
 git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/linux.git
 perf/enable5

 thanks,
 jirka

 Cc: Corey Ashford cjash...@linux.vnet.ibm.com
 Cc: Frederic Weisbecker fweis...@gmail.com
 Cc: Ingo Molnar mi...@elte.hu
 Cc: Namhyung Kim namhy...@kernel.org
 Cc: Paul Mackerras pau...@samba.org
 Cc: Peter Zijlstra a.p.zijls...@chello.nl
 Cc: Arnaldo Carvalho de Melo a...@redhat.com

I commented on the patch 5/5, anyway looks good to me:

Acked-by: Namhyung Kim namhy...@kernel.org

Thanks,
Namhyung
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/