Re: [PATCH 0/7] assorted minor bitmap patches

2018-08-19 Thread Andy Shevchenko 
On Sat, Aug 18, 2018 at 4:17 PM Rasmus Villemoes
 wrote:
>
> A recent LKML thread had me look into bitmap.{h,c} again, and I
> stumbled on/rediscovered a few things.
>

Good fixes, thanks!

Reviewed-by: Andy Shevchenko 

P.S. Perhaps needs addressing my comment to patch 6.
> Rasmus Villemoes (7):
>   lib/bitmap.c: remove wrong documentation
>   linux/bitmap.h: handle constant zero-size bitmaps correctly
>   linux/bitmap.h: remove redundant uses of small_const_nbits()
>   linux/bitmap.h: fix type of nbits in bitmap_shift_right()
>   linux/bitmap.h: relax comment on compile-time constant nbits
>   lib/bitmap.c: fix remaining space computation in
> bitmap_print_to_pagebuf
>   lib/bitmap.c: simplify bitmap_print_to_pagebuf
>
>  include/linux/bitmap.h | 37 +++--
>  lib/bitmap.c   | 21 +++--
>  2 files changed, 22 insertions(+), 36 deletions(-)
>
> --
> 2.16.4
>


--
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/7] assorted minor bitmap patches

2018-08-19 Thread Andy Shevchenko 
On Sat, Aug 18, 2018 at 4:17 PM Rasmus Villemoes
 wrote:
>
> A recent LKML thread had me look into bitmap.{h,c} again, and I
> stumbled on/rediscovered a few things.
>

Good fixes, thanks!

Reviewed-by: Andy Shevchenko 

P.S. Perhaps needs addressing my comment to patch 6.
> Rasmus Villemoes (7):
>   lib/bitmap.c: remove wrong documentation
>   linux/bitmap.h: handle constant zero-size bitmaps correctly
>   linux/bitmap.h: remove redundant uses of small_const_nbits()
>   linux/bitmap.h: fix type of nbits in bitmap_shift_right()
>   linux/bitmap.h: relax comment on compile-time constant nbits
>   lib/bitmap.c: fix remaining space computation in
> bitmap_print_to_pagebuf
>   lib/bitmap.c: simplify bitmap_print_to_pagebuf
>
>  include/linux/bitmap.h | 37 +++--
>  lib/bitmap.c   | 21 +++--
>  2 files changed, 22 insertions(+), 36 deletions(-)
>
> --
> 2.16.4
>


--
With Best Regards,
Andy Shevchenko

[PATCH 0/7] assorted minor bitmap patches

2018-08-18 Thread Rasmus Villemoes 
A recent LKML thread had me look into bitmap.{h,c} again, and I
stumbled on/rediscovered a few things.

Rasmus Villemoes (7):
  lib/bitmap.c: remove wrong documentation
  linux/bitmap.h: handle constant zero-size bitmaps correctly
  linux/bitmap.h: remove redundant uses of small_const_nbits()
  linux/bitmap.h: fix type of nbits in bitmap_shift_right()
  linux/bitmap.h: relax comment on compile-time constant nbits
  lib/bitmap.c: fix remaining space computation in
bitmap_print_to_pagebuf
  lib/bitmap.c: simplify bitmap_print_to_pagebuf

 include/linux/bitmap.h | 37 +++--
 lib/bitmap.c   | 21 +++--
 2 files changed, 22 insertions(+), 36 deletions(-)

-- 
2.16.4

[PATCH 0/7] assorted minor bitmap patches

2018-08-18 Thread Rasmus Villemoes 
A recent LKML thread had me look into bitmap.{h,c} again, and I
stumbled on/rediscovered a few things.

Rasmus Villemoes (7):
  lib/bitmap.c: remove wrong documentation
  linux/bitmap.h: handle constant zero-size bitmaps correctly
  linux/bitmap.h: remove redundant uses of small_const_nbits()
  linux/bitmap.h: fix type of nbits in bitmap_shift_right()
  linux/bitmap.h: relax comment on compile-time constant nbits
  lib/bitmap.c: fix remaining space computation in
bitmap_print_to_pagebuf
  lib/bitmap.c: simplify bitmap_print_to_pagebuf

 include/linux/bitmap.h | 37 +++--
 lib/bitmap.c   | 21 +++--
 2 files changed, 22 insertions(+), 36 deletions(-)

-- 
2.16.4