Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Fri, Feb 08, 2008 at 04:08:42PM -0500, Chuck Lever wrote: > On Feb 8, 2008, at 3:20 PM, Sam Ravnborg wrote: > >On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: > >>Clean up: Because NFSD_V4 "depends on" NFSD_V3, it appears as a > >>child of > >>the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. > >> > >>Replace the dependency on NFSD_V3 with a "select NFSD_V3". This > >>makes > >>NFSD_V4 look and work just like NFS_V3, while ensuring that > >>NFSD_V3 is > >>enabled if NFSD_V4 is. > >> > >>Signed-off-by: Chuck Lever <[EMAIL PROTECTED]> > >>--- > >> > >> fs/Kconfig |3 ++- > >> 1 files changed, 2 insertions(+), 1 deletions(-) > >> > >>diff --git a/fs/Kconfig b/fs/Kconfig > >>index 9ad62a9..4c16789 100644 > >>--- a/fs/Kconfig > >>+++ b/fs/Kconfig > >>@@ -1723,7 +1723,8 @@ config NFSD_V3_ACL > >> > >> config NFSD_V4 > >>bool "NFS server support for NFS version 4 (EXPERIMENTAL)" > >>- depends on NFSD && NFSD_V3 && EXPERIMENTAL > >>+ depends on NFSD && EXPERIMENTAL > >>+ select NFSD_V3 > >>select RPCSEC_GSS_KRB5 > >>help > >> This option enables support in your system's NFS server for > > > >This use of select is questionable. In general it is bad to select > >a symbol with dependencies. > >In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 > >so we will not se erratic configurations but do you remember to > >update NFSD_V4 when you add a depends on NFSD_V3? > > > >But I see no other clean way to do it rithg now. > > This patch is entirely optional, and I can just drop it for now. Keep it. My comment was more to say we have things to address in kconfig. This is abuse in the acceptable range. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Feb 8, 2008, at 3:20 PM, Sam Ravnborg wrote: On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: Clean up: Because NFSD_V4 "depends on" NFSD_V3, it appears as a child of the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. Replace the dependency on NFSD_V3 with a "select NFSD_V3". This makes NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is enabled if NFSD_V4 is. Signed-off-by: Chuck Lever <[EMAIL PROTECTED]> --- fs/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 9ad62a9..4c16789 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL config NFSD_V4 bool "NFS server support for NFS version 4 (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && EXPERIMENTAL + select NFSD_V3 select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for This use of select is questionable. In general it is bad to select a symbol with dependencies. In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 so we will not se erratic configurations but do you remember to update NFSD_V4 when you add a depends on NFSD_V3? But I see no other clean way to do it rithg now. This patch is entirely optional, and I can just drop it for now. Thanks for the review. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: > Clean up: Because NFSD_V4 "depends on" NFSD_V3, it appears as a child of > the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. > > Replace the dependency on NFSD_V3 with a "select NFSD_V3". This makes > NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is > enabled if NFSD_V4 is. > > Signed-off-by: Chuck Lever <[EMAIL PROTECTED]> > --- > > fs/Kconfig |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index 9ad62a9..4c16789 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL > > config NFSD_V4 > bool "NFS server support for NFS version 4 (EXPERIMENTAL)" > - depends on NFSD && NFSD_V3 && EXPERIMENTAL > + depends on NFSD && EXPERIMENTAL > + select NFSD_V3 > select RPCSEC_GSS_KRB5 > help > This option enables support in your system's NFS server for This use of select is questionable. In general it is bad to select a symbol with dependencies. In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 so we will not se erratic configurations but do you remember to update NFSD_V4 when you add a depends on NFSD_V3? But I see no other clean way to do it rithg now. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
Clean up: Because NFSD_V4 "depends on" NFSD_V3, it appears as a child of the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. Replace the dependency on NFSD_V3 with a "select NFSD_V3". This makes NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is enabled if NFSD_V4 is. Signed-off-by: Chuck Lever <[EMAIL PROTECTED]> --- fs/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 9ad62a9..4c16789 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL config NFSD_V4 bool "NFS server support for NFS version 4 (EXPERIMENTAL)" - depends on NFSD && NFSD_V3 && EXPERIMENTAL + depends on NFSD && EXPERIMENTAL + select NFSD_V3 select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Feb 8, 2008, at 3:20 PM, Sam Ravnborg wrote: On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: Clean up: Because NFSD_V4 depends on NFSD_V3, it appears as a child of the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. Replace the dependency on NFSD_V3 with a select NFSD_V3. This makes NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is enabled if NFSD_V4 is. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 9ad62a9..4c16789 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL config NFSD_V4 bool NFS server support for NFS version 4 (EXPERIMENTAL) - depends on NFSD NFSD_V3 EXPERIMENTAL + depends on NFSD EXPERIMENTAL + select NFSD_V3 select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for This use of select is questionable. In general it is bad to select a symbol with dependencies. In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 so we will not se erratic configurations but do you remember to update NFSD_V4 when you add a depends on NFSD_V3? But I see no other clean way to do it rithg now. This patch is entirely optional, and I can just drop it for now. Thanks for the review. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: Clean up: Because NFSD_V4 depends on NFSD_V3, it appears as a child of the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. Replace the dependency on NFSD_V3 with a select NFSD_V3. This makes NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is enabled if NFSD_V4 is. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 9ad62a9..4c16789 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL config NFSD_V4 bool NFS server support for NFS version 4 (EXPERIMENTAL) - depends on NFSD NFSD_V3 EXPERIMENTAL + depends on NFSD EXPERIMENTAL + select NFSD_V3 select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for This use of select is questionable. In general it is bad to select a symbol with dependencies. In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 so we will not se erratic configurations but do you remember to update NFSD_V4 when you add a depends on NFSD_V3? But I see no other clean way to do it rithg now. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/11] NFSD: Remove NFSv4 dependency on NFSv3
On Fri, Feb 08, 2008 at 04:08:42PM -0500, Chuck Lever wrote: On Feb 8, 2008, at 3:20 PM, Sam Ravnborg wrote: On Fri, Feb 08, 2008 at 12:52:08PM -0500, Chuck Lever wrote: Clean up: Because NFSD_V4 depends on NFSD_V3, it appears as a child of the NFSD_V3 menu entry, and is not visible if NFSD_V3 is unselected. Replace the dependency on NFSD_V3 with a select NFSD_V3. This makes NFSD_V4 look and work just like NFS_V3, while ensuring that NFSD_V3 is enabled if NFSD_V4 is. Signed-off-by: Chuck Lever [EMAIL PROTECTED] --- fs/Kconfig |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 9ad62a9..4c16789 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1723,7 +1723,8 @@ config NFSD_V3_ACL config NFSD_V4 bool NFS server support for NFS version 4 (EXPERIMENTAL) - depends on NFSD NFSD_V3 EXPERIMENTAL + depends on NFSD EXPERIMENTAL + select NFSD_V3 select RPCSEC_GSS_KRB5 help This option enables support in your system's NFS server for This use of select is questionable. In general it is bad to select a symbol with dependencies. In this case the dependencies of NFSD_V3 are duplicated for NFSD_V4 so we will not se erratic configurations but do you remember to update NFSD_V4 when you add a depends on NFSD_V3? But I see no other clean way to do it rithg now. This patch is entirely optional, and I can just drop it for now. Keep it. My comment was more to say we have things to address in kconfig. This is abuse in the acceptable range. Sam -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
