Re: [PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-27 Thread Miklos Szeredi
On Tue, Sep 27, 2016 at 5:40 AM, Al Viro wrote: > On Wed, Sep 14, 2016 at 10:37:11AM +0200, Miklos Szeredi wrote: > >> Things could happen to that page that make it not uptodate while sitting in >> the pipe, but it's questionable whether we should care about that. >>

Re: [PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-27 Thread Miklos Szeredi
On Tue, Sep 27, 2016 at 5:40 AM, Al Viro wrote: > On Wed, Sep 14, 2016 at 10:37:11AM +0200, Miklos Szeredi wrote: > >> Things could happen to that page that make it not uptodate while sitting in >> the pipe, but it's questionable whether we should care about that. >> Checking for being uptodate

Re: [PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-26 Thread Al Viro
On Wed, Sep 14, 2016 at 10:37:11AM +0200, Miklos Szeredi wrote: > Things could happen to that page that make it not uptodate while sitting in > the pipe, but it's questionable whether we should care about that. > Checking for being uptodate in the face of such page state change is always > going

Re: [PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-26 Thread Al Viro
On Wed, Sep 14, 2016 at 10:37:11AM +0200, Miklos Szeredi wrote: > Things could happen to that page that make it not uptodate while sitting in > the pipe, but it's questionable whether we should care about that. > Checking for being uptodate in the face of such page state change is always > going

[PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-14 Thread Miklos Szeredi
page_cache_pipe_buf_confirm() is used only in page_cache_pipe_buf_ops. page_cache_pipe_buf_ops is used in two places: 1) __generic_file_splice_read() This iterates all the pages, if not uptodate locks page, and if still not uptodate does ->readpage() which reads the page synchronously. 2)

[PATCH 06/11] pipe: no need to confirm page cache buf

2016-09-14 Thread Miklos Szeredi
page_cache_pipe_buf_confirm() is used only in page_cache_pipe_buf_ops. page_cache_pipe_buf_ops is used in two places: 1) __generic_file_splice_read() This iterates all the pages, if not uptodate locks page, and if still not uptodate does ->readpage() which reads the page synchronously. 2)