Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Mark Brown]

On Thu, Feb 01, 2018 at 01:19:28PM +, Olivier MOYSAN wrote:
> On 02/01/2018 10:10 AM, Ladislav Michl wrote:

> > depends on (ARCH_STM32 && OF) || COMPILE_TEST ?

> I can find in many configs "depends on OF && (ARCH_X || COMPILE_TEST)"
> This seems reasonable to me, as the driver always requires OF 
> dependency, regardless the compilation context.
> In fact, I cannot see why OF would not have to be selected
> for COMPILE_TEST.

There are some OF functions that are stubbed out when OF is disabled and
some that aren't, if the driver is using the more obscure APIs that
aren't stubbed it needs the hard dependency but if it's using the other
bits that do have the stubs then it can be compile tested without OF
being abled.


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Mark Brown]

On Thu, Feb 01, 2018 at 01:19:28PM +, Olivier MOYSAN wrote:
> On 02/01/2018 10:10 AM, Ladislav Michl wrote:

> > depends on (ARCH_STM32 && OF) || COMPILE_TEST ?

> I can find in many configs "depends on OF && (ARCH_X || COMPILE_TEST)"
> This seems reasonable to me, as the driver always requires OF 
> dependency, regardless the compilation context.
> In fact, I cannot see why OF would not have to be selected
> for COMPILE_TEST.

There are some OF functions that are stubbed out when OF is disabled and
some that aren't, if the driver is using the more obscure APIs that
aren't stubbed it needs the hard dependency but if it's using the other
bits that do have the stubs then it can be compile tested without OF
being abled.


signature.asc
Description: PGP signature

Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Olivier MOYSAN]

hello,

On 02/01/2018 10:10 AM, Ladislav Michl wrote:
> On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
>> Add of dependency for STM32 ASoC drivers.
>> DFSDM of dependency is already inherited
>> from STM32_DFSDM_ADC dependency.
>>
>> Signed-off-by: olivier moysan 
>> ---
>>   sound/soc/stm/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
>> index 3ad881f..b5375f9 100644
>> --- a/sound/soc/stm/Kconfig
>> +++ b/sound/soc/stm/Kconfig
>> @@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
>>   config SND_SOC_STM32_SAI
>>  tristate "STM32 SAI interface (Serial Audio Interface) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
> 
> depends on (ARCH_STM32 && OF) || COMPILE_TEST ?
> 

I can find in many configs "depends on OF && (ARCH_X || COMPILE_TEST)"
This seems reasonable to me, as the driver always requires OF 
dependency, regardless the compilation context.
In fact, I cannot see why OF would not have to be selected
for COMPILE_TEST.

BRs

>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> @@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
>>   config SND_SOC_STM32_I2S
>>  tristate "STM32 I2S interface (SPI/I2S block) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> @@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
>>   config SND_SOC_STM32_SPDIFRX
>>  tristate "STM32 S/PDIF receiver (SPDIFRX) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> -- 
>> 1.9.1
>>
>> ___
>> Alsa-devel mailing list
>> alsa-de...@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Olivier MOYSAN]

hello,

On 02/01/2018 10:10 AM, Ladislav Michl wrote:
> On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
>> Add of dependency for STM32 ASoC drivers.
>> DFSDM of dependency is already inherited
>> from STM32_DFSDM_ADC dependency.
>>
>> Signed-off-by: olivier moysan 
>> ---
>>   sound/soc/stm/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
>> index 3ad881f..b5375f9 100644
>> --- a/sound/soc/stm/Kconfig
>> +++ b/sound/soc/stm/Kconfig
>> @@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
>>   config SND_SOC_STM32_SAI
>>  tristate "STM32 SAI interface (Serial Audio Interface) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
> 
> depends on (ARCH_STM32 && OF) || COMPILE_TEST ?
> 

I can find in many configs "depends on OF && (ARCH_X || COMPILE_TEST)"
This seems reasonable to me, as the driver always requires OF 
dependency, regardless the compilation context.
In fact, I cannot see why OF would not have to be selected
for COMPILE_TEST.

BRs

>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> @@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
>>   config SND_SOC_STM32_I2S
>>  tristate "STM32 I2S interface (SPI/I2S block) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> @@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
>>   config SND_SOC_STM32_SPDIFRX
>>  tristate "STM32 S/PDIF receiver (SPDIFRX) support"
>>  depends on ARCH_STM32 || COMPILE_TEST
>> +depends on OF
>>  depends on SND_SOC
>>  select SND_SOC_GENERIC_DMAENGINE_PCM
>>  select REGMAP_MMIO
>> -- 
>> 1.9.1
>>
>> ___
>> Alsa-devel mailing list
>> alsa-de...@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Ladislav Michl]

On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
> Add of dependency for STM32 ASoC drivers.
> DFSDM of dependency is already inherited
> from STM32_DFSDM_ADC dependency.
> 
> Signed-off-by: olivier moysan 
> ---
>  sound/soc/stm/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
> index 3ad881f..b5375f9 100644
> --- a/sound/soc/stm/Kconfig
> +++ b/sound/soc/stm/Kconfig
> @@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
>  config SND_SOC_STM32_SAI
>   tristate "STM32 SAI interface (Serial Audio Interface) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF

depends on (ARCH_STM32 && OF) || COMPILE_TEST ?

>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> @@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
>  config SND_SOC_STM32_I2S
>   tristate "STM32 I2S interface (SPI/I2S block) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF
>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> @@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
>  config SND_SOC_STM32_SPDIFRX
>   tristate "STM32 S/PDIF receiver (SPDIFRX) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF
>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> -- 
> 1.9.1
> 
> ___
> Alsa-devel mailing list
> alsa-de...@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] [PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Ladislav Michl]

On Thu, Feb 01, 2018 at 09:54:41AM +0100, Olivier Moysan wrote:
> Add of dependency for STM32 ASoC drivers.
> DFSDM of dependency is already inherited
> from STM32_DFSDM_ADC dependency.
> 
> Signed-off-by: olivier moysan 
> ---
>  sound/soc/stm/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
> index 3ad881f..b5375f9 100644
> --- a/sound/soc/stm/Kconfig
> +++ b/sound/soc/stm/Kconfig
> @@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
>  config SND_SOC_STM32_SAI
>   tristate "STM32 SAI interface (Serial Audio Interface) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF

depends on (ARCH_STM32 && OF) || COMPILE_TEST ?

>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> @@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
>  config SND_SOC_STM32_I2S
>   tristate "STM32 I2S interface (SPI/I2S block) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF
>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> @@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
>  config SND_SOC_STM32_SPDIFRX
>   tristate "STM32 S/PDIF receiver (SPDIFRX) support"
>   depends on ARCH_STM32 || COMPILE_TEST
> + depends on OF
>   depends on SND_SOC
>   select SND_SOC_GENERIC_DMAENGINE_PCM
>   select REGMAP_MMIO
> -- 
> 1.9.1
> 
> ___
> Alsa-devel mailing list
> alsa-de...@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Olivier Moysan]

Add of dependency for STM32 ASoC drivers.
DFSDM of dependency is already inherited
from STM32_DFSDM_ADC dependency.

Signed-off-by: olivier moysan 
---
 sound/soc/stm/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
index 3ad881f..b5375f9 100644
--- a/sound/soc/stm/Kconfig
+++ b/sound/soc/stm/Kconfig
@@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
 config SND_SOC_STM32_SAI
tristate "STM32 SAI interface (Serial Audio Interface) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
@@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
 config SND_SOC_STM32_I2S
tristate "STM32 I2S interface (SPI/I2S block) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
@@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
 config SND_SOC_STM32_SPDIFRX
tristate "STM32 S/PDIF receiver (SPDIFRX) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
-- 
1.9.1

[PATCH 1/1] ASoC: stm32: add of dependency for stm32 drivers

[Olivier Moysan]

Add of dependency for STM32 ASoC drivers.
DFSDM of dependency is already inherited
from STM32_DFSDM_ADC dependency.

Signed-off-by: olivier moysan 
---
 sound/soc/stm/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig
index 3ad881f..b5375f9 100644
--- a/sound/soc/stm/Kconfig
+++ b/sound/soc/stm/Kconfig
@@ -3,6 +3,7 @@ menu "STMicroelectronics STM32 SOC audio support"
 config SND_SOC_STM32_SAI
tristate "STM32 SAI interface (Serial Audio Interface) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
@@ -12,6 +13,7 @@ config SND_SOC_STM32_SAI
 config SND_SOC_STM32_I2S
tristate "STM32 I2S interface (SPI/I2S block) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
@@ -21,6 +23,7 @@ config SND_SOC_STM32_I2S
 config SND_SOC_STM32_SPDIFRX
tristate "STM32 S/PDIF receiver (SPDIFRX) support"
depends on ARCH_STM32 || COMPILE_TEST
+   depends on OF
depends on SND_SOC
select SND_SOC_GENERIC_DMAENGINE_PCM
select REGMAP_MMIO
-- 
1.9.1