[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib kfree_call_rcu does not belong in linux/rcupdate.h and should be moved to slab_common.c Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 --

[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib kfree_call_rcu does not belong in linux/rcupdate.h and should be moved to slab_common.c Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 -- include/linux/slab.h | 42

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Mon, Apr 02, 2018 at 05:45:48PM +0800, kbuild test robot wrote: > Hi Rao, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on rcu/rcu/next] > [also build test WARNING on v4.16 next-20180329] > [if your patch is applied to the wrong git tree, please drop

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Mon, Apr 02, 2018 at 05:45:48PM +0800, kbuild test robot wrote: > Hi Rao, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on rcu/rcu/next] > [also build test WARNING on v4.16 next-20180329] > [if your patch is applied to the wrong git tree, please drop

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Rao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rcu/rcu/next] [also build test WARNING on v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Rao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rcu/rcu/next] [also build test WARNING on v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Rao, Thank you for the patch! Yet something to improve: [auto build test ERROR on rcu/rcu/next] [also build test ERROR on v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Rao, Thank you for the patch! Yet something to improve: [auto build test ERROR on rcu/rcu/next] [also build test ERROR on v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib kfree_call_rcu does not belong in linux/rcupdate.h and should be moved to slab_common.c Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 --

[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib kfree_call_rcu does not belong in linux/rcupdate.h and should be moved to slab_common.c Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 -- include/linux/slab.h | 42

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Mon, 2018-03-26 at 18:56 -0700, Rao Shoaib wrote: > Folks, > > Is anyone working on resolving the check patch issue as I am waiting to > resubmit my patch. Will it be fine if I submitted the patch with the > original macro as the check is in-correct. Yes. Of course. Anytime a person knows

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Mon, 2018-03-26 at 18:56 -0700, Rao Shoaib wrote: > Folks, > > Is anyone working on resolving the check patch issue as I am waiting to > resubmit my patch. Will it be fine if I submitted the patch with the > original macro as the check is in-correct. Yes. Of course. Anytime a person knows

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Folks, Is anyone working on resolving the check patch issue as I am waiting to resubmit my patch. Will it be fine if I submitted the patch with the original macro as the check is in-correct. I do not speak perl but I can do the process work. If folks think Joe's fix is fine I can submit it

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Folks, Is anyone working on resolving the check patch issue as I am waiting to resubmit my patch. Will it be fine if I submitted the patch with the original macro as the check is in-correct. I do not speak perl but I can do the process work. If folks think Joe's fix is fine I can submit it

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, 2018-01-04 at 16:07 -0800, Matthew Wilcox wrote: > On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: > > I was under the impression that typeof did not actually evaluate its > > argument, but rather only returned its type. And there are a few macros > > with this pattern

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, 2018-01-04 at 16:07 -0800, Matthew Wilcox wrote: > On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: > > I was under the impression that typeof did not actually evaluate its > > argument, but rather only returned its type. And there are a few macros > > with this pattern

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 04:07 PM, Matthew Wilcox wrote: On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: I was under the impression that typeof did not actually evaluate its argument, but rather only returned its type. And there are a few macros with this pattern in mainline. Or am I

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 04:07 PM, Matthew Wilcox wrote: On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: I was under the impression that typeof did not actually evaluate its argument, but rather only returned its type. And there are a few macros with this pattern in mainline. Or am I

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: > I was under the impression that typeof did not actually evaluate its > argument, but rather only returned its type. And there are a few macros > with this pattern in mainline. > > Or am I confused about what typeof does? I

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 03:47:32PM -0800, Paul E. McKenney wrote: > I was under the impression that typeof did not actually evaluate its > argument, but rather only returned its type. And there are a few macros > with this pattern in mainline. > > Or am I confused about what typeof does? I

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 03:13:07PM -0800, Matthew Wilcox wrote: > On Thu, Jan 04, 2018 at 02:18:50PM -0800, Rao Shoaib wrote: > > > > > > +#define kfree_rcu(ptr, rcu_head_name) \ > > > > > > +    do { \ > > > > > > +    typeof(ptr) __ptr = ptr;    \ > > > > > > +    unsigned long __off =

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 03:13:07PM -0800, Matthew Wilcox wrote: > On Thu, Jan 04, 2018 at 02:18:50PM -0800, Rao Shoaib wrote: > > > > > > +#define kfree_rcu(ptr, rcu_head_name) \ > > > > > > +    do { \ > > > > > > +    typeof(ptr) __ptr = ptr;    \ > > > > > > +    unsigned long __off =

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 02:18:50PM -0800, Rao Shoaib wrote: > > > > > +#define kfree_rcu(ptr, rcu_head_name) \ > > > > > +    do { \ > > > > > +    typeof(ptr) __ptr = ptr;    \ > > > > > +    unsigned long __off = offsetof(typeof(*(__ptr)), \ > > > > > + 

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 02:18:50PM -0800, Rao Shoaib wrote: > > > > > +#define kfree_rcu(ptr, rcu_head_name) \ > > > > > +    do { \ > > > > > +    typeof(ptr) __ptr = ptr;    \ > > > > > +    unsigned long __off = offsetof(typeof(*(__ptr)), \ > > > > > + 

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 01:46 PM, Matthew Wilcox wrote: On Thu, Jan 04, 2018 at 01:27:49PM -0800, Rao Shoaib wrote: On 01/04/2018 12:35 PM, Rao Shoaib wrote: As far as your previous comments are concerned, only the following one has not been addressed. Can you please elaborate as I do not understand

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 01:46 PM, Matthew Wilcox wrote: On Thu, Jan 04, 2018 at 01:27:49PM -0800, Rao Shoaib wrote: On 01/04/2018 12:35 PM, Rao Shoaib wrote: As far as your previous comments are concerned, only the following one has not been addressed. Can you please elaborate as I do not understand

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 01:27:49PM -0800, Rao Shoaib wrote: > On 01/04/2018 12:35 PM, Rao Shoaib wrote: > > As far as your previous comments are concerned, only the following one > > has not been addressed. Can you please elaborate as I do not understand > > the comment. The code was expanded

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Thu, Jan 04, 2018 at 01:27:49PM -0800, Rao Shoaib wrote: > On 01/04/2018 12:35 PM, Rao Shoaib wrote: > > As far as your previous comments are concerned, only the following one > > has not been addressed. Can you please elaborate as I do not understand > > the comment. The code was expanded

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 12:35 PM, Rao Shoaib wrote: Hi Boqun, Thanks a lot for all your guidance and for catching the cut and paster error. Please see inline. On 01/03/2018 05:38 PM, Boqun Feng wrote: But you introduced a bug here, you should use rcu_state_p instead of _sched_state as the third

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/04/2018 12:35 PM, Rao Shoaib wrote: Hi Boqun, Thanks a lot for all your guidance and for catching the cut and paster error. Please see inline. On 01/03/2018 05:38 PM, Boqun Feng wrote: But you introduced a bug here, you should use rcu_state_p instead of _sched_state as the third

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Boqun, Thanks a lot for all your guidance and for catching the cut and paster error. Please see inline. On 01/03/2018 05:38 PM, Boqun Feng wrote: But you introduced a bug here, you should use rcu_state_p instead of _sched_state as the third parameter for __call_rcu(). Please re-read:

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Boqun, Thanks a lot for all your guidance and for catching the cut and paster error. Please see inline. On 01/03/2018 05:38 PM, Boqun Feng wrote: But you introduced a bug here, you should use rcu_state_p instead of _sched_state as the third parameter for __call_rcu(). Please re-read:

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Shoaib, Good to see you set out a patchset ;-) On Tue, Jan 02, 2018 at 02:49:25PM -0800, Rao Shoaib wrote: > > > On 01/02/2018 02:23 PM, Matthew Wilcox wrote: > > On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: > > > -#define kfree_rcu(ptr, rcu_head)

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

Hi Shoaib, Good to see you set out a patchset ;-) On Tue, Jan 02, 2018 at 02:49:25PM -0800, Rao Shoaib wrote: > > > On 01/02/2018 02:23 PM, Matthew Wilcox wrote: > > On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: > > > -#define kfree_rcu(ptr, rcu_head)

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/02/2018 02:23 PM, Matthew Wilcox wrote: On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: -#define kfree_rcu(ptr, rcu_head) \ - __kfree_rcu(&((ptr)->rcu_head), offsetof(typeof(*(ptr)), rcu_head)) +#define kfree_rcu(ptr,

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On 01/02/2018 02:23 PM, Matthew Wilcox wrote: On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: -#define kfree_rcu(ptr, rcu_head) \ - __kfree_rcu(&((ptr)->rcu_head), offsetof(typeof(*(ptr)), rcu_head)) +#define kfree_rcu(ptr,

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: > -#define kfree_rcu(ptr, rcu_head) \ > - __kfree_rcu(&((ptr)->rcu_head), offsetof(typeof(*(ptr)), rcu_head)) > +#define kfree_rcu(ptr, rcu_head_name)\ > + do { \ > +

Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c

On Tue, Jan 02, 2018 at 12:11:37PM -0800, rao.sho...@oracle.com wrote: > -#define kfree_rcu(ptr, rcu_head) \ > - __kfree_rcu(&((ptr)->rcu_head), offsetof(typeof(*(ptr)), rcu_head)) > +#define kfree_rcu(ptr, rcu_head_name)\ > + do { \ > +

[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 -- include/linux/slab.h | 44

[PATCH 1/2] Move kfree_call_rcu() to slab_common.c

From: Rao Shoaib Signed-off-by: Rao Shoaib --- include/linux/rcupdate.h | 43 +++ include/linux/rcutree.h | 2 -- include/linux/slab.h | 44 kernel/rcu/tree.c| 24 ++--