Re: [PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-26 Thread Ioan-Adrian Ratiu
Hi On Mon, 26 Sep 2016, Benjamin Tissoires wrote: > Thanks for the patch series. I am not against it, but I'd rather see the > commit message of this one amended, and the second patch changed. Sorry if I came out too aggresive (I'll amend), I'm just annoyed that I

Re: [PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-26 Thread Ioan-Adrian Ratiu
Hi On Mon, 26 Sep 2016, Benjamin Tissoires wrote: > Thanks for the patch series. I am not against it, but I'd rather see the > commit message of this one amended, and the second patch changed. Sorry if I came out too aggresive (I'll amend), I'm just annoyed that I had to spend a weekend night

Re: [PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-26 Thread Benjamin Tissoires
Thanks for the patch series. I am not against it, but I'd rather see the commit message of this one amended, and the second patch changed. On Sep 26 2016 or thereabouts, Ioan-Adrian Ratiu wrote: > This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...") > because the "fix" is bogus. That

Re: [PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-26 Thread Benjamin Tissoires
Thanks for the patch series. I am not against it, but I'd rather see the commit message of this one amended, and the second patch changed. On Sep 26 2016 or thereabouts, Ioan-Adrian Ratiu wrote: > This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...") > because the "fix" is bogus. That

[PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-25 Thread Ioan-Adrian Ratiu
This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...") because the "fix" is bogus. That report descriptor is different in hardware (see below) and it's the way the hardware works, it can't be fixed at this level because it reuses axes by design. What this change tried to fix is a

[PATCH 1/2] Revert "HID: dragonrise: fix HID Descriptor for 0x0006 PID"

2016-09-25 Thread Ioan-Adrian Ratiu
This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...") because the "fix" is bogus. That report descriptor is different in hardware (see below) and it's the way the hardware works, it can't be fixed at this level because it reuses axes by design. What this change tried to fix is a