Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Justin 
On 03.03.2013 21:36, Yann E. MORIN wrote:
Hello,
> 
> In the light of the different mails on the subject, it appears that the
> ncurses*-config script are unreliable: at least one major distribution
> (Debian) is broken and, for various reasons, is not gonna fix it, and
> all its derivatives (eg. Ubuntu) do suffer from the same deficiency.

Indeed the config scripts come without the necessary build time deps.
But it ends in the same situation as current version of the Makefile.
The user will be asked to install the devel package.
So I don't see any problem here.

> 
> I think we should stick to:
>   - try with pkg-config;
>   - fallback to the legacy heuristic.
> 
> Does using pkg-config fix your use-case?

It does, nevertheless I would prefer to include the ncurses*-config
script as well to cover most situation we will find on users system.

Justin



signature.asc
Description: OpenPGP digital signature

Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN 
Justin, All,

On Friday 01 March 2013 j...@gentoo.org wrote:
> When building ncurses with --with-termlib several symbols get moved from
> libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
> additionally needs to link with libtinfo.so. Ncurses provides a config script
> (ncurses5-config) or in very recent version even a pkg-config module to assist
> finding ncurses.
> 
> The old heuristic for detection of ncurses libs will be extended to the
> pkg-config and the config scripts.
> 
> Signed-off-by: Justin Lecher 
> ---
>  scripts/kconfig/lxdialog/check-lxdialog.sh | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh 
> b/scripts/kconfig/lxdialog/check-lxdialog.sh
> index 8078813..8086874 100644
> --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
> +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
> @@ -4,6 +4,12 @@
>  # What library to link
>  ldflags()
>  {
> + pkg-config --libs ncursesw 2>/dev/null && exit
> + pkg-config --libs ncurses 2>/dev/null && exit
> + ncursesw5-config --libs 2>/dev/null && exit
> + ncurses5-config --libs 2>/dev/null && exit
> + ncursesw6-config --libs 2>/dev/null && exit
> + ncurses6-config --libs 2>/dev/null && exit

In the light of the different mails on the subject, it appears that the
ncurses*-config script are unreliable: at least one major distribution
(Debian) is broken and, for various reasons, is not gonna fix it, and
all its derivatives (eg. Ubuntu) do suffer from the same deficiency.

I think we should stick to:
  - try with pkg-config;
  - fallback to the legacy heuristic.

Does using pkg-config fix your use-case?

Regards,
Yann E. MORIN.

-- 
.-..--..
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN |  ___   |
| +33 223 225 172 `.---:  X  AGAINST  |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL|   v   conspiracy.  |
'--^---^--^'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Yann E. MORIN 
Justin, All,

On Friday 01 March 2013 j...@gentoo.org wrote:
 When building ncurses with --with-termlib several symbols get moved from
 libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
 additionally needs to link with libtinfo.so. Ncurses provides a config script
 (ncurses5-config) or in very recent version even a pkg-config module to assist
 finding ncurses.
 
 The old heuristic for detection of ncurses libs will be extended to the
 pkg-config and the config scripts.
 
 Signed-off-by: Justin Lecher j...@gentoo.org
 ---
  scripts/kconfig/lxdialog/check-lxdialog.sh | 6 ++
  1 file changed, 6 insertions(+)
 
 diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh 
 b/scripts/kconfig/lxdialog/check-lxdialog.sh
 index 8078813..8086874 100644
 --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
 +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
 @@ -4,6 +4,12 @@
  # What library to link
  ldflags()
  {
 + pkg-config --libs ncursesw 2/dev/null  exit
 + pkg-config --libs ncurses 2/dev/null  exit
 + ncursesw5-config --libs 2/dev/null  exit
 + ncurses5-config --libs 2/dev/null  exit
 + ncursesw6-config --libs 2/dev/null  exit
 + ncurses6-config --libs 2/dev/null  exit

In the light of the different mails on the subject, it appears that the
ncurses*-config script are unreliable: at least one major distribution
(Debian) is broken and, for various reasons, is not gonna fix it, and
all its derivatives (eg. Ubuntu) do suffer from the same deficiency.

I think we should stick to:
  - try with pkg-config;
  - fallback to the legacy heuristic.

Does using pkg-config fix your use-case?

Regards,
Yann E. MORIN.

-- 
.-..--..
|  Yann E. MORIN  | Real-Time Embedded | /\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN |  ___   |
| +33 223 225 172 `.---:  X  AGAINST  |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL|   v   conspiracy.  |
'--^---^--^'
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-03 Thread Justin 
On 03.03.2013 21:36, Yann E. MORIN wrote:
Hello,
 
 In the light of the different mails on the subject, it appears that the
 ncurses*-config script are unreliable: at least one major distribution
 (Debian) is broken and, for various reasons, is not gonna fix it, and
 all its derivatives (eg. Ubuntu) do suffer from the same deficiency.

Indeed the config scripts come without the necessary build time deps.
But it ends in the same situation as current version of the Makefile.
The user will be asked to install the devel package.
So I don't see any problem here.

 
 I think we should stick to:
   - try with pkg-config;
   - fallback to the legacy heuristic.
 
 Does using pkg-config fix your use-case?

It does, nevertheless I would prefer to include the ncurses*-config
script as well to cover most situation we will find on users system.

Justin



signature.asc
Description: OpenPGP digital signature

[PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-01 Thread jlec 
From: Justin Lecher 

When building ncurses with --with-termlib several symbols get moved from
libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
additionally needs to link with libtinfo.so. Ncurses provides a config script
(ncurses5-config) or in very recent version even a pkg-config module to assist
finding ncurses.

The old heuristic for detection of ncurses libs will be extended to the
pkg-config and the config scripts.

Signed-off-by: Justin Lecher 
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh 
b/scripts/kconfig/lxdialog/check-lxdialog.sh
index 8078813..8086874 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -4,6 +4,12 @@
 # What library to link
 ldflags()
 {
+   pkg-config --libs ncursesw 2>/dev/null && exit
+   pkg-config --libs ncurses 2>/dev/null && exit
+   ncursesw5-config --libs 2>/dev/null && exit
+   ncurses5-config --libs 2>/dev/null && exit
+   ncursesw6-config --libs 2>/dev/null && exit
+   ncurses6-config --libs 2>/dev/null && exit
for ext in so a dll.a dylib ; do
for lib in ncursesw ncurses curses ; do
$cc -print-file-name=lib${lib}.${ext} | grep -q /
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/2] menuconfig: use config scripts to detect ncurses libs

2013-03-01 Thread jlec 
From: Justin Lecher j...@gentoo.org

When building ncurses with --with-termlib several symbols get moved from
libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one
additionally needs to link with libtinfo.so. Ncurses provides a config script
(ncurses5-config) or in very recent version even a pkg-config module to assist
finding ncurses.

The old heuristic for detection of ncurses libs will be extended to the
pkg-config and the config scripts.

Signed-off-by: Justin Lecher j...@gentoo.org
---
 scripts/kconfig/lxdialog/check-lxdialog.sh | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh 
b/scripts/kconfig/lxdialog/check-lxdialog.sh
index 8078813..8086874 100644
--- a/scripts/kconfig/lxdialog/check-lxdialog.sh
+++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
@@ -4,6 +4,12 @@
 # What library to link
 ldflags()
 {
+   pkg-config --libs ncursesw 2/dev/null  exit
+   pkg-config --libs ncurses 2/dev/null  exit
+   ncursesw5-config --libs 2/dev/null  exit
+   ncurses5-config --libs 2/dev/null  exit
+   ncursesw6-config --libs 2/dev/null  exit
+   ncurses6-config --libs 2/dev/null  exit
for ext in so a dll.a dylib ; do
for lib in ncursesw ncurses curses ; do
$cc -print-file-name=lib${lib}.${ext} | grep -q /
-- 
1.8.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/