Re: [PATCH 1/2] perf tests: Remove duplicate bitmap test

2021-03-05 Thread Jiri Olsa
On Fri, Mar 05, 2021 at 06:41:57PM +0300, Denis Efremov wrote:
> test_bitmap("1,3-6,8-10,24,35-37") called twice in a row.
> Remove the second test.
> 
> Signed-off-by: Denis Efremov 

for both patches

Acked-by: Jiri Olsa 

thanks,
jirka


> ---
>  tools/perf/tests/bitmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/tests/bitmap.c b/tools/perf/tests/bitmap.c
> index 96c137360918..3320613400eb 100644
> --- a/tools/perf/tests/bitmap.c
> +++ b/tools/perf/tests/bitmap.c
> @@ -47,7 +47,6 @@ int test__bitmap_print(struct test *test __maybe_unused, 
> int subtest __maybe_unu
>   TEST_ASSERT_VAL("failed to convert map", 
> test_bitmap("1,3,5,7,9,11,13,15,17,19,21-40"));
>   TEST_ASSERT_VAL("failed to convert map", test_bitmap("2-5"));
>   TEST_ASSERT_VAL("failed to convert map", 
> test_bitmap("1,3-6,8-10,24,35-37"));
> - TEST_ASSERT_VAL("failed to convert map", 
> test_bitmap("1,3-6,8-10,24,35-37"));
>   TEST_ASSERT_VAL("failed to convert map", 
> test_bitmap("1-10,12-20,22-30,32-40"));
>   return 0;
>  }
> -- 
> 2.26.2
> 



[PATCH 1/2] perf tests: Remove duplicate bitmap test

2021-03-05 Thread Denis Efremov
test_bitmap("1,3-6,8-10,24,35-37") called twice in a row.
Remove the second test.

Signed-off-by: Denis Efremov 
---
 tools/perf/tests/bitmap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/bitmap.c b/tools/perf/tests/bitmap.c
index 96c137360918..3320613400eb 100644
--- a/tools/perf/tests/bitmap.c
+++ b/tools/perf/tests/bitmap.c
@@ -47,7 +47,6 @@ int test__bitmap_print(struct test *test __maybe_unused, int 
subtest __maybe_unu
TEST_ASSERT_VAL("failed to convert map", 
test_bitmap("1,3,5,7,9,11,13,15,17,19,21-40"));
TEST_ASSERT_VAL("failed to convert map", test_bitmap("2-5"));
TEST_ASSERT_VAL("failed to convert map", 
test_bitmap("1,3-6,8-10,24,35-37"));
-   TEST_ASSERT_VAL("failed to convert map", 
test_bitmap("1,3-6,8-10,24,35-37"));
TEST_ASSERT_VAL("failed to convert map", 
test_bitmap("1-10,12-20,22-30,32-40"));
return 0;
 }
-- 
2.26.2