Re: [PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

[Marek Vasut]

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> Remove parentheses surrounding the whole right side of an assignment.
> 
> Signed-off-by: Masahiro Yamada 

Reviewed-by: Marek Vasut 

> ---
> 
>  drivers/mtd/nand/denali.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index d482d8d..14e66ab 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1510,16 +1510,16 @@ int denali_init(struct denali_nand_info *denali)
>* the real pagesize and anything necessery
>*/
>   denali->devnum = ioread32(denali->flash_reg + DEVICES_CONNECTED);
> - denali->nand.chipsize <<= (denali->devnum - 1);
> - denali->nand.page_shift += (denali->devnum - 1);
> + denali->nand.chipsize <<= denali->devnum - 1;
> + denali->nand.page_shift += denali->devnum - 1;
>   denali->nand.pagemask = (denali->nand.chipsize >>
>   denali->nand.page_shift) - 1;
> - denali->nand.bbt_erase_shift += (denali->devnum - 1);
> + denali->nand.bbt_erase_shift += denali->devnum - 1;
>   denali->nand.phys_erase_shift = denali->nand.bbt_erase_shift;
> - denali->nand.chip_shift += (denali->devnum - 1);
> - mtd->writesize <<= (denali->devnum - 1);
> - mtd->oobsize <<= (denali->devnum - 1);
> - mtd->erasesize <<= (denali->devnum - 1);
> + denali->nand.chip_shift += denali->devnum - 1;
> + mtd->writesize <<= denali->devnum - 1;
> + mtd->oobsize <<= denali->devnum - 1;
> + mtd->erasesize <<= denali->devnum - 1;

I won't claim I completely understand what this code does, but it
certainly does raise some eyebrows.

>   mtd->size = denali->nand.numchips * denali->nand.chipsize;
>   denali->bbtskipbytes *= denali->devnum;
>  
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

[Marek Vasut]

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> Remove parentheses surrounding the whole right side of an assignment.
> 
> Signed-off-by: Masahiro Yamada 

Reviewed-by: Marek Vasut 

> ---
> 
>  drivers/mtd/nand/denali.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index d482d8d..14e66ab 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1510,16 +1510,16 @@ int denali_init(struct denali_nand_info *denali)
>* the real pagesize and anything necessery
>*/
>   denali->devnum = ioread32(denali->flash_reg + DEVICES_CONNECTED);
> - denali->nand.chipsize <<= (denali->devnum - 1);
> - denali->nand.page_shift += (denali->devnum - 1);
> + denali->nand.chipsize <<= denali->devnum - 1;
> + denali->nand.page_shift += denali->devnum - 1;
>   denali->nand.pagemask = (denali->nand.chipsize >>
>   denali->nand.page_shift) - 1;
> - denali->nand.bbt_erase_shift += (denali->devnum - 1);
> + denali->nand.bbt_erase_shift += denali->devnum - 1;
>   denali->nand.phys_erase_shift = denali->nand.bbt_erase_shift;
> - denali->nand.chip_shift += (denali->devnum - 1);
> - mtd->writesize <<= (denali->devnum - 1);
> - mtd->oobsize <<= (denali->devnum - 1);
> - mtd->erasesize <<= (denali->devnum - 1);
> + denali->nand.chip_shift += denali->devnum - 1;
> + mtd->writesize <<= denali->devnum - 1;
> + mtd->oobsize <<= denali->devnum - 1;
> + mtd->erasesize <<= denali->devnum - 1;

I won't claim I completely understand what this code does, but it
certainly does raise some eyebrows.

>   mtd->size = denali->nand.numchips * denali->nand.chipsize;
>   denali->bbtskipbytes *= denali->devnum;
>  
> 


-- 
Best regards,
Marek Vasut

[PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

[Masahiro Yamada]

Remove parentheses surrounding the whole right side of an assignment.

Signed-off-by: Masahiro Yamada 
---

 drivers/mtd/nand/denali.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index d482d8d..14e66ab 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1510,16 +1510,16 @@ int denali_init(struct denali_nand_info *denali)
 * the real pagesize and anything necessery
 */
denali->devnum = ioread32(denali->flash_reg + DEVICES_CONNECTED);
-   denali->nand.chipsize <<= (denali->devnum - 1);
-   denali->nand.page_shift += (denali->devnum - 1);
+   denali->nand.chipsize <<= denali->devnum - 1;
+   denali->nand.page_shift += denali->devnum - 1;
denali->nand.pagemask = (denali->nand.chipsize >>
denali->nand.page_shift) - 1;
-   denali->nand.bbt_erase_shift += (denali->devnum - 1);
+   denali->nand.bbt_erase_shift += denali->devnum - 1;
denali->nand.phys_erase_shift = denali->nand.bbt_erase_shift;
-   denali->nand.chip_shift += (denali->devnum - 1);
-   mtd->writesize <<= (denali->devnum - 1);
-   mtd->oobsize <<= (denali->devnum - 1);
-   mtd->erasesize <<= (denali->devnum - 1);
+   denali->nand.chip_shift += denali->devnum - 1;
+   mtd->writesize <<= denali->devnum - 1;
+   mtd->oobsize <<= denali->devnum - 1;
+   mtd->erasesize <<= denali->devnum - 1;
mtd->size = denali->nand.numchips * denali->nand.chipsize;
denali->bbtskipbytes *= denali->devnum;
 
-- 
1.9.1

[PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

[Masahiro Yamada]

Remove parentheses surrounding the whole right side of an assignment.

Signed-off-by: Masahiro Yamada 
---

 drivers/mtd/nand/denali.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index d482d8d..14e66ab 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1510,16 +1510,16 @@ int denali_init(struct denali_nand_info *denali)
 * the real pagesize and anything necessery
 */
denali->devnum = ioread32(denali->flash_reg + DEVICES_CONNECTED);
-   denali->nand.chipsize <<= (denali->devnum - 1);
-   denali->nand.page_shift += (denali->devnum - 1);
+   denali->nand.chipsize <<= denali->devnum - 1;
+   denali->nand.page_shift += denali->devnum - 1;
denali->nand.pagemask = (denali->nand.chipsize >>
denali->nand.page_shift) - 1;
-   denali->nand.bbt_erase_shift += (denali->devnum - 1);
+   denali->nand.bbt_erase_shift += denali->devnum - 1;
denali->nand.phys_erase_shift = denali->nand.bbt_erase_shift;
-   denali->nand.chip_shift += (denali->devnum - 1);
-   mtd->writesize <<= (denali->devnum - 1);
-   mtd->oobsize <<= (denali->devnum - 1);
-   mtd->erasesize <<= (denali->devnum - 1);
+   denali->nand.chip_shift += denali->devnum - 1;
+   mtd->writesize <<= denali->devnum - 1;
+   mtd->oobsize <<= denali->devnum - 1;
+   mtd->erasesize <<= denali->devnum - 1;
mtd->size = denali->nand.numchips * denali->nand.chipsize;
denali->bbtskipbytes *= denali->devnum;
 
-- 
1.9.1