subject:"\[PATCH 15\/34\] perf, core\: Add a concept of a weightened sample"

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-23 Thread Andi Kleen

On Tue, Oct 23, 2012 at 03:13:52PM +0200, Peter Zijlstra wrote:
> > @@ -562,6 +565,7 @@ enum perf_event_type {
> >  *  { u64   stream_id;} && PERF_SAMPLE_STREAM_ID
> >  *  { u32   cpu, res; } && PERF_SAMPLE_CPU
> >  *  { u64   period;   } && PERF_SAMPLE_PERIOD
> > +*  { u64   weight;   } && PERF_SAMPLE_WEIGHT
> >  *
> >  *  { struct read_formatvalues;   } && PERF_SAMPLE_READ
> >  * 
> 
> So the only issues I have are that his makes every sample more expensive
> by having to 0 out that weight data and the sample placement.

It's only reported when explicitely enabled (-W). So most users
shouldn't see any overhead (except two untaken if()s or so)

-Andi

-- 
a...@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-23 Thread Peter Zijlstra

On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> @@ -601,6 +602,7 @@ static inline void perf_sample_data_init(struct 
> perf_sample_data *data,
> data->regs_user.abi = PERF_SAMPLE_REGS_ABI_NONE;
> data->regs_user.regs = NULL;
> data->stack_user_size = 0;
> +   data->weight = 0;
>  }
>  
>  extern void perf_output_sample(struct perf_output_handle *handle,

> @@ -562,6 +565,7 @@ enum perf_event_type {
>  *  { u64   stream_id;} && PERF_SAMPLE_STREAM_ID
>  *  { u32   cpu, res; } && PERF_SAMPLE_CPU
>  *  { u64   period;   } && PERF_SAMPLE_PERIOD
> +*  { u64   weight;   } && PERF_SAMPLE_WEIGHT
>  *
>  *  { struct read_formatvalues;   } && PERF_SAMPLE_READ
>  * 

So the only issues I have are that his makes every sample more expensive
by having to 0 out that weight data and the sample placement.

I don't think avoiding that weight init is really worth the pain that'll
cause, so we'll just leave it there.

As to the placement, I suppose it makes sense, although Stephane once
complained about these fields not being in PERF_SAMPLE numeric order.
Since we're not that anyway, he'll have to deal with it.. Stephane, any
strong arguments against this placement?

Also, Stephane, you said you had something similar in you LL patches, do
you mean to re-use this or should we re-base this on top of your
patches.. ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-23 Thread Peter Zijlstra

On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
 @@ -601,6 +602,7 @@ static inline void perf_sample_data_init(struct 
 perf_sample_data *data,
 data-regs_user.abi = PERF_SAMPLE_REGS_ABI_NONE;
 data-regs_user.regs = NULL;
 data-stack_user_size = 0;
 +   data-weight = 0;
  }
  
  extern void perf_output_sample(struct perf_output_handle *handle,

 @@ -562,6 +565,7 @@ enum perf_event_type {
  *  { u64   stream_id;}  PERF_SAMPLE_STREAM_ID
  *  { u32   cpu, res; }  PERF_SAMPLE_CPU
  *  { u64   period;   }  PERF_SAMPLE_PERIOD
 +*  { u64   weight;   }  PERF_SAMPLE_WEIGHT
  *
  *  { struct read_formatvalues;   }  PERF_SAMPLE_READ
  * 

So the only issues I have are that his makes every sample more expensive
by having to 0 out that weight data and the sample placement.

I don't think avoiding that weight init is really worth the pain that'll
cause, so we'll just leave it there.

As to the placement, I suppose it makes sense, although Stephane once
complained about these fields not being in PERF_SAMPLE numeric order.
Since we're not that anyway, he'll have to deal with it.. Stephane, any
strong arguments against this placement?

Also, Stephane, you said you had something similar in you LL patches, do
you mean to re-use this or should we re-base this on top of your
patches.. ?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-23 Thread Andi Kleen

On Tue, Oct 23, 2012 at 03:13:52PM +0200, Peter Zijlstra wrote:
  @@ -562,6 +565,7 @@ enum perf_event_type {
   *  { u64   stream_id;}  PERF_SAMPLE_STREAM_ID
   *  { u32   cpu, res; }  PERF_SAMPLE_CPU
   *  { u64   period;   }  PERF_SAMPLE_PERIOD
  +*  { u64   weight;   }  PERF_SAMPLE_WEIGHT
   *
   *  { struct read_formatvalues;   }  PERF_SAMPLE_READ
   * 
 
 So the only issues I have are that his makes every sample more expensive
 by having to 0 out that weight data and the sample placement.

It's only reported when explicitely enabled (-W). So most users
shouldn't see any overhead (except two untaken if()s or so)

-Andi

-- 
a...@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-18 Thread Andi Kleen

From: Andi Kleen 

For some events it's useful to weight sample with a hardware
provided number. This expresses how expensive the action the
sample represent was.  This allows the profiler to scale
the samples to be more informative to the programmer.

There is already the period which is used similarly, but it means
something different, so I chose to not overload it. Instead
a new sample type for WEIGHT is added.

Can be used for multiple things. Initially it is used for TSX abort costs
and profiling by memory latencies (so to make expensive load appear higher
up in the histograms)  The concept is quite generic and can be extended
to many other kinds of events or architectures, as long as the hardware
provides suitable auxillary values. In principle it could be also
used for software tracpoints.

This adds the generic glue. A new optional sample format for a 64bit
weight value.

Signed-off-by: Andi Kleen 
---
 include/linux/perf_event.h  |2 ++
 include/uapi/linux/perf_event.h |8 ++--
 kernel/events/core.c|6 ++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 0e528fc..f4ded17 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -588,6 +588,7 @@ struct perf_sample_data {
struct perf_branch_stack*br_stack;
struct perf_regs_user   regs_user;
u64 stack_user_size;
+   u64 weight;
 };
 
 static inline void perf_sample_data_init(struct perf_sample_data *data,
@@ -601,6 +602,7 @@ static inline void perf_sample_data_init(struct 
perf_sample_data *data,
data->regs_user.abi = PERF_SAMPLE_REGS_ABI_NONE;
data->regs_user.regs = NULL;
data->stack_user_size = 0;
+   data->weight = 0;
 }
 
 extern void perf_output_sample(struct perf_output_handle *handle,
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 37a8c4d..c067c9c 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -132,8 +132,10 @@ enum perf_event_sample_format {
PERF_SAMPLE_BRANCH_STACK= 1U << 11,
PERF_SAMPLE_REGS_USER   = 1U << 12,
PERF_SAMPLE_STACK_USER  = 1U << 13,
+   PERF_SAMPLE_WEIGHT  = 1U << 14,
+
+   PERF_SAMPLE_MAX = 1U << 15, /* non-ABI */
 
-   PERF_SAMPLE_MAX = 1U << 14, /* non-ABI */
 };
 
 /*
@@ -201,8 +203,9 @@ enum perf_event_read_format {
PERF_FORMAT_TOTAL_TIME_RUNNING  = 1U << 1,
PERF_FORMAT_ID  = 1U << 2,
PERF_FORMAT_GROUP   = 1U << 3,
+   PERF_FORMAT_WEIGHT  = 1U << 4,
 
-   PERF_FORMAT_MAX = 1U << 4,  /* non-ABI */
+   PERF_FORMAT_MAX = 1U << 5,  /* non-ABI */
 };
 
 #define PERF_ATTR_SIZE_VER064  /* sizeof first published struct */
@@ -562,6 +565,7 @@ enum perf_event_type {
 *  { u64   stream_id;} && PERF_SAMPLE_STREAM_ID
 *  { u32   cpu, res; } && PERF_SAMPLE_CPU
 *  { u64   period;   } && PERF_SAMPLE_PERIOD
+*  { u64   weight;   } && PERF_SAMPLE_WEIGHT
 *
 *  { struct read_formatvalues;   } && PERF_SAMPLE_READ
 *
diff --git a/kernel/events/core.c b/kernel/events/core.c
index dbccf83..d633581 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -952,6 +952,9 @@ static void perf_event__header_size(struct perf_event 
*event)
if (sample_type & PERF_SAMPLE_PERIOD)
size += sizeof(data->period);
 
+   if (sample_type & PERF_SAMPLE_WEIGHT)
+   size += sizeof(data->weight);
+
if (sample_type & PERF_SAMPLE_READ)
size += event->read_size;
 
@@ -4080,6 +4083,9 @@ void perf_output_sample(struct perf_output_handle *handle,
if (sample_type & PERF_SAMPLE_PERIOD)
perf_output_put(handle, data->period);
 
+   if (sample_type & PERF_SAMPLE_WEIGHT)
+   perf_output_put(handle, data->weight);
+
if (sample_type & PERF_SAMPLE_READ)
perf_output_read(handle, event);
 
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 15/34] perf, core: Add a concept of a weightened sample

2012-10-18 Thread Andi Kleen

From: Andi Kleen a...@linux.intel.com

For some events it's useful to weight sample with a hardware
provided number. This expresses how expensive the action the
sample represent was.  This allows the profiler to scale
the samples to be more informative to the programmer.

There is already the period which is used similarly, but it means
something different, so I chose to not overload it. Instead
a new sample type for WEIGHT is added.

Can be used for multiple things. Initially it is used for TSX abort costs
and profiling by memory latencies (so to make expensive load appear higher
up in the histograms)  The concept is quite generic and can be extended
to many other kinds of events or architectures, as long as the hardware
provides suitable auxillary values. In principle it could be also
used for software tracpoints.

This adds the generic glue. A new optional sample format for a 64bit
weight value.

Signed-off-by: Andi Kleen a...@linux.intel.com
---
 include/linux/perf_event.h  |2 ++
 include/uapi/linux/perf_event.h |8 ++--
 kernel/events/core.c|6 ++
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 0e528fc..f4ded17 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -588,6 +588,7 @@ struct perf_sample_data {
struct perf_branch_stack*br_stack;
struct perf_regs_user   regs_user;
u64 stack_user_size;
+   u64 weight;
 };
 
 static inline void perf_sample_data_init(struct perf_sample_data *data,
@@ -601,6 +602,7 @@ static inline void perf_sample_data_init(struct 
perf_sample_data *data,
data-regs_user.abi = PERF_SAMPLE_REGS_ABI_NONE;
data-regs_user.regs = NULL;
data-stack_user_size = 0;
+   data-weight = 0;
 }
 
 extern void perf_output_sample(struct perf_output_handle *handle,
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 37a8c4d..c067c9c 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -132,8 +132,10 @@ enum perf_event_sample_format {
PERF_SAMPLE_BRANCH_STACK= 1U  11,
PERF_SAMPLE_REGS_USER   = 1U  12,
PERF_SAMPLE_STACK_USER  = 1U  13,
+   PERF_SAMPLE_WEIGHT  = 1U  14,
+
+   PERF_SAMPLE_MAX = 1U  15, /* non-ABI */
 
-   PERF_SAMPLE_MAX = 1U  14, /* non-ABI */
 };
 
 /*
@@ -201,8 +203,9 @@ enum perf_event_read_format {
PERF_FORMAT_TOTAL_TIME_RUNNING  = 1U  1,
PERF_FORMAT_ID  = 1U  2,
PERF_FORMAT_GROUP   = 1U  3,
+   PERF_FORMAT_WEIGHT  = 1U  4,
 
-   PERF_FORMAT_MAX = 1U  4,  /* non-ABI */
+   PERF_FORMAT_MAX = 1U  5,  /* non-ABI */
 };
 
 #define PERF_ATTR_SIZE_VER064  /* sizeof first published struct */
@@ -562,6 +565,7 @@ enum perf_event_type {
 *  { u64   stream_id;}  PERF_SAMPLE_STREAM_ID
 *  { u32   cpu, res; }  PERF_SAMPLE_CPU
 *  { u64   period;   }  PERF_SAMPLE_PERIOD
+*  { u64   weight;   }  PERF_SAMPLE_WEIGHT
 *
 *  { struct read_formatvalues;   }  PERF_SAMPLE_READ
 *
diff --git a/kernel/events/core.c b/kernel/events/core.c
index dbccf83..d633581 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -952,6 +952,9 @@ static void perf_event__header_size(struct perf_event 
*event)
if (sample_type  PERF_SAMPLE_PERIOD)
size += sizeof(data-period);
 
+   if (sample_type  PERF_SAMPLE_WEIGHT)
+   size += sizeof(data-weight);
+
if (sample_type  PERF_SAMPLE_READ)
size += event-read_size;
 
@@ -4080,6 +4083,9 @@ void perf_output_sample(struct perf_output_handle *handle,
if (sample_type  PERF_SAMPLE_PERIOD)
perf_output_put(handle, data-period);
 
+   if (sample_type  PERF_SAMPLE_WEIGHT)
+   perf_output_put(handle, data-weight);
+
if (sample_type  PERF_SAMPLE_READ)
perf_output_read(handle, event);
 
-- 
1.7.7.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

Re: [PATCH 15/34] perf, core: Add a concept of a weightened sample

[PATCH 15/34] perf, core: Add a concept of a weightened sample

[PATCH 15/34] perf, core: Add a concept of a weightened sample

6 matches

Site Navigation

Mail list logo

Footer information