Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Tue, May 15, 2018 at 02:11:48PM -0700, Joe Perches wrote: > On Tue, 2018-05-15 at 12:28 -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > > > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > > > On Mon, 2018-05-14 at 16:58

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Tue, May 15, 2018 at 02:11:48PM -0700, Joe Perches wrote: > On Tue, 2018-05-15 at 12:28 -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > > > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > > > On Mon, 2018-05-14 at 16:58

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Tue, 2018-05-15 at 12:28 -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > > > OK, so if I define pr_fmt as

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Tue, 2018-05-15 at 12:28 -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > > > OK, so if I define pr_fmt as

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > > OK, so if I define pr_fmt as follows, I get the old behavior? > > > > > > #define pr_fmt(fmt) fmt

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 05:32:05PM -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > > OK, so if I define pr_fmt as follows, I get the old behavior? > > > > > > #define pr_fmt(fmt) fmt

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 06:22:02PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 17:32 -0700, Paul E. McKenney wrote: > > So this change does not affect WARN_ON_ONCE() and friends? > > Changing define pr_fmt does not modify WARN_ON output. Very good, I removed my --squash patch adding

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 06:22:02PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 17:32 -0700, Paul E. McKenney wrote: > > So this change does not affect WARN_ON_ONCE() and friends? > > Changing define pr_fmt does not modify WARN_ON output. Very good, I removed my --squash patch adding

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 17:32 -0700, Paul E. McKenney wrote: > So this change does not affect WARN_ON_ONCE() and friends? Changing define pr_fmt does not modify WARN_ON output.

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 17:32 -0700, Paul E. McKenney wrote: > So this change does not affect WARN_ON_ONCE() and friends? Changing define pr_fmt does not modify WARN_ON output.

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > OK, so if I define pr_fmt as follows, I get the old behavior? > > > > #define pr_fmt(fmt) fmt > > yes. OK, then I will queue patches with this for the near term for

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 05:23:59PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > > OK, so if I define pr_fmt as follows, I get the old behavior? > > > > #define pr_fmt(fmt) fmt > > yes. OK, then I will queue patches with this for the near term for

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > OK, so if I define pr_fmt as follows, I get the old behavior? > > #define pr_fmt(fmt) fmt yes. > I just queued > a commit to be squashed into my version of your patch 18/18 that adds > this to kernel/rcu/rcu_segcblist.c. This

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 16:58 -0700, Paul E. McKenney wrote: > OK, so if I define pr_fmt as follows, I get the old behavior? > > #define pr_fmt(fmt) fmt yes. > I just queued > a commit to be squashed into my version of your patch 18/18 that adds > this to kernel/rcu/rcu_segcblist.c. This

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 03:54:13PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 15:24 -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > > > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > > > On Thu, May 10, 2018 at 08:45:44AM

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 03:54:13PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 15:24 -0700, Paul E. McKenney wrote: > > On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > > > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > > > On Thu, May 10, 2018 at 08:45:44AM

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 15:24 -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > > Use a consistent logging prefix for

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 15:24 -0700, Paul E. McKenney wrote: > On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > > Use a consistent logging prefix for

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > Use a consistent logging prefix for all rcu related output. > > > > > > Signed-off-by: Joe Perches

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 02:41:59PM -0700, Joe Perches wrote: > On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > Use a consistent logging prefix for all rcu related output. > > > > > > Signed-off-by: Joe Perches > >

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > Use a consistent logging prefix for all rcu related output. > > > > Signed-off-by: Joe Perches > > I took parts of this (thank you!) but have concerns

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, 2018-05-14 at 13:29 -0700, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > Use a consistent logging prefix for all rcu related output. > > > > Signed-off-by: Joe Perches > > I took parts of this (thank you!) but have concerns about other parts.

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 11:37:56PM +0300, Andy Shevchenko wrote: > On Mon, May 14, 2018 at 11:29 PM, Paul E. McKenney > wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > And I took this (but kept the period), plus used "%s" to make it fit

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 11:37:56PM +0300, Andy Shevchenko wrote: > On Mon, May 14, 2018 at 11:29 PM, Paul E. McKenney > wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > > > And I took this (but kept the period), plus used "%s" to make it fit in > > 80 characters: > > > >

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 01:52:48PM -0700, Randy Dunlap wrote: > On 05/14/2018 01:29 PM, Paul E. McKenney wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > >> Use a consistent logging prefix for all rcu related output. > >> > >> Signed-off-by: Joe Perches

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 01:52:48PM -0700, Randy Dunlap wrote: > On 05/14/2018 01:29 PM, Paul E. McKenney wrote: > > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > >> Use a consistent logging prefix for all rcu related output. > >> > >> Signed-off-by: Joe Perches > > > > I took

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On 05/14/2018 01:29 PM, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: >> Use a consistent logging prefix for all rcu related output. >> >> Signed-off-by: Joe Perches > > I took parts of this (thank you!) but have concerns about other

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On 05/14/2018 01:29 PM, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: >> Use a consistent logging prefix for all rcu related output. >> >> Signed-off-by: Joe Perches > > I took parts of this (thank you!) but have concerns about other parts. > >> --- >>

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 11:29 PM, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > And I took this (but kept the period), plus used "%s" to make it fit in > 80 characters: > > pr_info("\tRCU restricting CPUs from %s=%d

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Mon, May 14, 2018 at 11:29 PM, Paul E. McKenney wrote: > On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > And I took this (but kept the period), plus used "%s" to make it fit in > 80 characters: > > pr_info("\tRCU restricting CPUs from %s=%d to %s=%u.\n", >

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > Use a consistent logging prefix for all rcu related output. > > Signed-off-by: Joe Perches I took parts of this (thank you!) but have concerns about other parts. > --- > kernel/rcu/rcu_segcblist.c | 2 ++ >

Re: [PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

On Thu, May 10, 2018 at 08:45:44AM -0700, Joe Perches wrote: > Use a consistent logging prefix for all rcu related output. > > Signed-off-by: Joe Perches I took parts of this (thank you!) but have concerns about other parts. > --- > kernel/rcu/rcu_segcblist.c | 2 ++ > kernel/rcu/rcuperf.c

[PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

Use a consistent logging prefix for all rcu related output. Signed-off-by: Joe Perches --- kernel/rcu/rcu_segcblist.c | 2 ++ kernel/rcu/rcuperf.c | 10 --- kernel/rcu/rcutorture.c| 46 +++ kernel/rcu/srcutiny.c | 2 ++

[PATCH 18/18] rcu: Use pr_fmt to prefix "rcu: " to logging output

Use a consistent logging prefix for all rcu related output. Signed-off-by: Joe Perches --- kernel/rcu/rcu_segcblist.c | 2 ++ kernel/rcu/rcuperf.c | 10 --- kernel/rcu/rcutorture.c| 46 +++ kernel/rcu/srcutiny.c | 2 ++ kernel/rcu/srcutree.c