Re: [PATCH 2/2] ION handle already destroyed in ion_free.

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma 
> ---
>  drivers/staging/android/ion/ion.c |1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c 
> b/drivers/staging/android/ion/ion.c
> index 9e56d32..0d2b9a3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int 
> cmd, unsigned long arg)
>   if (IS_ERR(handle))
>   return PTR_ERR(handle);
>   ion_free(client, handle);
> - ion_handle_put(handle);
>   break;
>   }
>   case ION_IOC_SHARE:
> --
> 1.7.9.5

Are you sure about this?  Did you test it?  How?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 2/2] ION handle already destroyed in ion_free.

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Jan 17, 2015 at 12:04:21PM +0530, Shailendra Verma wrote:
 
 Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com
 ---
  drivers/staging/android/ion/ion.c |1 -
  1 file changed, 1 deletion(-)
 
 diff --git a/drivers/staging/android/ion/ion.c 
 b/drivers/staging/android/ion/ion.c
 index 9e56d32..0d2b9a3 100644
 --- a/drivers/staging/android/ion/ion.c
 +++ b/drivers/staging/android/ion/ion.c
 @@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int 
 cmd, unsigned long arg)
   if (IS_ERR(handle))
   return PTR_ERR(handle);
   ion_free(client, handle);
 - ion_handle_put(handle);
   break;
   }
   case ION_IOC_SHARE:
 --
 1.7.9.5

Are you sure about this?  Did you test it?  How?

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/2] ION handle already destroyed in ion_free.

2015-01-16 Thread Shailendra Verma

Signed-off-by: Shailendra Verma 
---
 drivers/staging/android/ion/ion.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c 
b/drivers/staging/android/ion/ion.c
index 9e56d32..0d2b9a3 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int 
cmd, unsigned long arg)
if (IS_ERR(handle))
return PTR_ERR(handle);
ion_free(client, handle);
-   ion_handle_put(handle);
break;
}
case ION_IOC_SHARE:
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 2/2] ION handle already destroyed in ion_free.

2015-01-16 Thread Shailendra Verma

Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com
---
 drivers/staging/android/ion/ion.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c 
b/drivers/staging/android/ion/ion.c
index 9e56d32..0d2b9a3 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1279,7 +1279,6 @@ static long ion_ioctl(struct file *filp, unsigned int 
cmd, unsigned long arg)
if (IS_ERR(handle))
return PTR_ERR(handle);
ion_free(client, handle);
-   ion_handle_put(handle);
break;
}
case ION_IOC_SHARE:
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/