Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-05 Thread Azael Avalos
Hi Joe, 2015-03-05 13:59 GMT-07:00 Joseph Salisbury : > On 03/04/2015 07:05 PM, Azael Avalos wrote: >> Hi there, >> >> 2015-03-04 14:52 GMT-07:00 Joseph Salisbury : >> ... >>> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } }, >>> + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } }, >> ... >> >> These

Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-05 Thread Joseph Salisbury
On 03/05/2015 04:04 PM, Azael Avalos wrote: > Hi Joe, > > 2015-03-05 13:59 GMT-07:00 Joseph Salisbury : >> On 03/04/2015 07:05 PM, Azael Avalos wrote: >>> Hi there, >>> >>> 2015-03-04 14:52 GMT-07:00 Joseph Salisbury >>> : >>> ... + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } }, +

Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-05 Thread Joseph Salisbury
On 03/04/2015 07:05 PM, Azael Avalos wrote: > Hi there, > > 2015-03-04 14:52 GMT-07:00 Joseph Salisbury : > ... >> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } }, >> + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } }, > ... > > These two are not neccesary, as they may collide with "previous song" >

Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-05 Thread Joseph Salisbury
On 03/04/2015 07:05 PM, Azael Avalos wrote: > Hi there, > > 2015-03-04 14:52 GMT-07:00 Joseph Salisbury : > ... >> + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } }, >> + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } }, > ... > > These two are not neccesary, as they may collide with "previous song" >

Re: [PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-04 Thread Azael Avalos
Hi there, 2015-03-04 14:52 GMT-07:00 Joseph Salisbury : ... > + { KE_KEY, 0x140, { KEY_BRIGHTNESSDOWN } }, > + { KE_KEY, 0x141, { KEY_BRIGHTNESSUP } }, ... These two are not neccesary, as they may collide with "previous song" and "playpause" in case Toshiba (or its manufacturers) deci

[PATCH 2/2] toshiba_acpi: Add Satellite P50W-B to alternative keymap and create new mappings.

2015-03-04 Thread Joseph Salisbury
BugLink: http://bugs.launchpad.net/bugs/1416277 The Toshiba Satellite P50W-B is required in the alternate keymap for all keys to properly function. There are also some new key ids that need to be added(PREVIOUSSONG, NEXTSONG and PLAYPAUSE). Also, the alt keymap has changed the key ids for mute,