Re: [PATCH 4/5] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

2017-10-09 Thread Steven Rostedt
On Sat, 12 Aug 2017 11:30:46 -0600 Michael Sartain wrote: > Signed int values were being used where the original code used uint32_t types: > > http://www.azillionmonkeys.com/qed/hash.html > > Right shifting negative int values has implementation-defined and left >

Re: [PATCH 4/5] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

2017-10-09 Thread Steven Rostedt
On Sat, 12 Aug 2017 11:30:46 -0600 Michael Sartain wrote: > Signed int values were being used where the original code used uint32_t types: > > http://www.azillionmonkeys.com/qed/hash.html > > Right shifting negative int values has implementation-defined and left > shifting > has undefined

[PATCH 4/5] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

2017-08-12 Thread Michael Sartain
Signed int values were being used where the original code used uint32_t types: http://www.azillionmonkeys.com/qed/hash.html Right shifting negative int values has implementation-defined and left shifting has undefined behavior. On my platform (x86_64) right shifting was doing sign extension

[PATCH 4/5] trace-cmd: Use unsigned values in Hsieh's trace_hash fast hash function

2017-08-12 Thread Michael Sartain
Signed int values were being used where the original code used uint32_t types: http://www.azillionmonkeys.com/qed/hash.html Right shifting negative int values has implementation-defined and left shifting has undefined behavior. On my platform (x86_64) right shifting was doing sign extension