Re: [PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

2007-10-23 Thread David Miller 
From: Chuck Lever <[EMAIL PROTECTED]>
Date: Tue, 23 Oct 2007 11:44:33 -0400

> The tcp_minshall_update() function is called in exactly one place, and is
> passed an unsigned integer for the mss_len argument.  Make the sign of the
> argument match the sign of the passed variable in order to eliminate an
> unneeded implicit type cast and a mixed sign comparison in
> tcp_minshall_update().
> 
> Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>

Applied, thanks.

> Cc: <[EMAIL PROTECTED]>

Actually, you only CC:'d linux-kernel on these patches.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

2007-10-23 Thread Chuck Lever 
The tcp_minshall_update() function is called in exactly one place, and is
passed an unsigned integer for the mss_len argument.  Make the sign of the
argument match the sign of the passed variable in order to eliminate an
unneeded implicit type cast and a mixed sign comparison in
tcp_minshall_update().

Signed-off-by: Chuck Lever <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
---

 include/net/tcp.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 92049e6..d695cea 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -803,7 +803,7 @@ static inline int tcp_is_cwnd_limited(const struct sock 
*sk, u32 in_flight)
return left <= tcp_max_burst(tp);
 }
 
-static inline void tcp_minshall_update(struct tcp_sock *tp, int mss,
+static inline void tcp_minshall_update(struct tcp_sock *tp, unsigned int mss,
   const struct sk_buff *skb)
 {
if (skb->len < mss)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

2007-10-23 Thread Chuck Lever 
The tcp_minshall_update() function is called in exactly one place, and is
passed an unsigned integer for the mss_len argument.  Make the sign of the
argument match the sign of the passed variable in order to eliminate an
unneeded implicit type cast and a mixed sign comparison in
tcp_minshall_update().

Signed-off-by: Chuck Lever [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---

 include/net/tcp.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 92049e6..d695cea 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -803,7 +803,7 @@ static inline int tcp_is_cwnd_limited(const struct sock 
*sk, u32 in_flight)
return left = tcp_max_burst(tp);
 }
 
-static inline void tcp_minshall_update(struct tcp_sock *tp, int mss,
+static inline void tcp_minshall_update(struct tcp_sock *tp, unsigned int mss,
   const struct sk_buff *skb)
 {
if (skb-len  mss)

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 5/5] NET: Remove unneeded implicit type case when calling tcp_minshall_update()

2007-10-23 Thread David Miller 
From: Chuck Lever [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 11:44:33 -0400

 The tcp_minshall_update() function is called in exactly one place, and is
 passed an unsigned integer for the mss_len argument.  Make the sign of the
 argument match the sign of the passed variable in order to eliminate an
 unneeded implicit type cast and a mixed sign comparison in
 tcp_minshall_update().
 
 Signed-off-by: Chuck Lever [EMAIL PROTECTED]

Applied, thanks.

 Cc: [EMAIL PROTECTED]

Actually, you only CC:'d linux-kernel on these patches.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/