Re: [PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-10 Thread Djalal Harouni
On Fri, Nov 10, 2017 at 11:36 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: >> --- a/fs/proc/base.c >> +++ b/fs/proc/base.c > >> -static bool has_pid_permissions(struct pid_namespace *pid, >> +static bool has_pid_permissions(struct

Re: [PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-10 Thread Djalal Harouni
On Fri, Nov 10, 2017 at 11:36 AM, Alexey Dobriyan wrote: > On 11/9/17, Djalal Harouni wrote: >> --- a/fs/proc/base.c >> +++ b/fs/proc/base.c > >> -static bool has_pid_permissions(struct pid_namespace *pid, >> +static bool has_pid_permissions(struct proc_fs_info *fs_info, > > More "const". > >>

Re: [PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-10 Thread Alexey Dobriyan
On 11/9/17, Djalal Harouni wrote: > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > -static bool has_pid_permissions(struct pid_namespace *pid, > +static bool has_pid_permissions(struct proc_fs_info *fs_info, More "const". > diff --git a/fs/proc/inode.c b/fs/proc/inode.c >

Re: [PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-10 Thread Alexey Dobriyan
On 11/9/17, Djalal Harouni wrote: > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > -static bool has_pid_permissions(struct pid_namespace *pid, > +static bool has_pid_permissions(struct proc_fs_info *fs_info, More "const". > diff --git a/fs/proc/inode.c b/fs/proc/inode.c > index 9abc370..bdd808d

[PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-09 Thread Djalal Harouni
This is a cleaning patch to add helpers to set and get proc mount options instead of a direct access. This allows later to easily track what's happening, how these fields are accessed, and in case we need to update them in the future. Later we will move these mount options to proc_fs_info struct.

[PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options

2017-11-09 Thread Djalal Harouni
This is a cleaning patch to add helpers to set and get proc mount options instead of a direct access. This allows later to easily track what's happening, how these fields are accessed, and in case we need to update them in the future. Later we will move these mount options to proc_fs_info struct.