RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-05 Thread Haiyang Zhang
xdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Move state setting for link query > > On 03/05/2014 12:57 AM, Haiyang Zhang wrote: > > > >> -Original Message- > >> From: Jason Wang [mailto:jasow...@redhat.com] > >> Sent: Monday, March 3, 20

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-05 Thread Haiyang Zhang
: Re: [PATCH net-next] hyperv: Move state setting for link query On 03/05/2014 12:57 AM, Haiyang Zhang wrote: -Original Message- From: Jason Wang [mailto:jasow...@redhat.com] Sent: Monday, March 3, 2014 10:10 PM To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org Cc

Re: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Jason Wang
.de; linux-kernel@vger.kernel.org; driverdev- >> de...@linuxdriverproject.org >> Subject: Re: [PATCH net-next] hyperv: Move state setting for link query >> >> On 03/04/2014 07:54 AM, Haiyang Zhang wrote: >>> It moves the state setting for query into rndis_fil

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Haiyang Zhang
xdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Move state setting for link query > > On 03/04/2014 07:54 AM, Haiyang Zhang wrote: > > It moves the state setting for query into rndis_filter_receive_response(). > > All callbacks including query-complete and status-c

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Haiyang Zhang
xdriverproject.org > Subject: Re: [PATCH net-next] hyperv: Move state setting for link query > > On 03/04/2014 07:54 AM, Haiyang Zhang wrote: > > It moves the state setting for query into rndis_filter_receive_response(). > > All callbacks including query-complete and status-c

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Haiyang Zhang
: [PATCH net-next] hyperv: Move state setting for link query On 03/04/2014 07:54 AM, Haiyang Zhang wrote: It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel-inbound_lock

RE: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Haiyang Zhang
: [PATCH net-next] hyperv: Move state setting for link query On 03/04/2014 07:54 AM, Haiyang Zhang wrote: It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel-inbound_lock

Re: [PATCH net-next] hyperv: Move state setting for link query

2014-03-04 Thread Jason Wang
- de...@linuxdriverproject.org Subject: Re: [PATCH net-next] hyperv: Move state setting for link query On 03/04/2014 07:54 AM, Haiyang Zhang wrote: It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback

Re: [PATCH net-next] hyperv: Move state setting for link query

2014-03-03 Thread Jason Wang
On 03/04/2014 07:54 AM, Haiyang Zhang wrote: > It moves the state setting for query into rndis_filter_receive_response(). > All callbacks including query-complete and status-callback are synchronized > by channel->inbound_lock. This prevents pentential race between them. This still looks racy to

[PATCH net-next] hyperv: Move state setting for link query

2014-03-03 Thread Haiyang Zhang
It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel->inbound_lock. This prevents pentential race between them. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/rndis_filter.c | 21

[PATCH net-next] hyperv: Move state setting for link query

2014-03-03 Thread Haiyang Zhang
It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel-inbound_lock. This prevents pentential race between them. Signed-off-by: Haiyang Zhang haiya...@microsoft.com ---

Re: [PATCH net-next] hyperv: Move state setting for link query

2014-03-03 Thread Jason Wang
On 03/04/2014 07:54 AM, Haiyang Zhang wrote: It moves the state setting for query into rndis_filter_receive_response(). All callbacks including query-complete and status-callback are synchronized by channel-inbound_lock. This prevents pentential race between them. This still looks racy to me.