Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:52 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: >> On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: >> > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> >>

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:52 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: >> On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: >> > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> >> > +#ifdef __KERNEL__ >> >> >> > +#include

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> >> > +#ifdef __KERNEL__ > >> >> > +#include > >> >> > +#else > >> >> > +#include

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:42:13PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> >> > +#ifdef __KERNEL__ > >> >> > +#include > >> >> > +#else > >> >> > +#include > >> >> > +#endif

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> > +#ifdef __KERNEL__ >> >> > +#include >> >> > +#else >> >> > +#include >> >> > +#endif /* __KERNEL__ */ >> >> >> >> This will break applications

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 5:33 PM, Mikko Rapeli wrote: > On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: >> >> > +#ifdef __KERNEL__ >> >> > +#include >> >> > +#else >> >> > +#include >> >> > +#endif /* __KERNEL__ */ >> >> >> >> This will break applications that include manually.

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> > +#ifdef __KERNEL__ > >> > +#include > >> > +#else > >> > +#include > >> > +#endif /* __KERNEL__ */ > >> > >> This will break applications that include manually. > >> I previously sent a patch to use libc-compat to make

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 05:24:20PM -0400, Willem de Bruijn wrote: > >> > +#ifdef __KERNEL__ > >> > +#include > >> > +#else > >> > +#include > >> > +#endif /* __KERNEL__ */ > >> > >> This will break applications that include manually. > >> I previously sent a patch to use libc-compat to make

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

>> > +#ifdef __KERNEL__ >> > +#include >> > +#else >> > +#include >> > +#endif /* __KERNEL__ */ >> >> This will break applications that include manually. >> I previously sent a patch to use libc-compat to make compilation succeed >> when both are included in the case where is included after >>

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

>> > +#ifdef __KERNEL__ >> > +#include >> > +#else >> > +#include >> > +#endif /* __KERNEL__ */ >> >> This will break applications that include manually. >> I previously sent a patch to use libc-compat to make compilation succeed >> when both are included in the case where is included after >>

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:26:50PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn > wrote: > > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > >> linux/time.h conflicts with user space header time.h.

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:26:50PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn > wrote: > > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > >> linux/time.h conflicts with user space header time.h. Try to be compatible > >> with both. > >> > >> Fixes

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:23:16PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > > linux/time.h conflicts with user space header time.h. Try to be compatible > > with both. > > > > Fixes userspace compilation error: > > > > error:

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 06, 2017 at 04:23:16PM -0400, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > > linux/time.h conflicts with user space header time.h. Try to be compatible > > with both. > > > > Fixes userspace compilation error: > > > > error: array type has

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: >> linux/time.h conflicts with user space header time.h. Try to be compatible >> with both. >> >> Fixes userspace compilation

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 4:23 PM, Willem de Bruijn wrote: > On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: >> linux/time.h conflicts with user space header time.h. Try to be compatible >> with both. >> >> Fixes userspace compilation error: >> >> error: array type has incomplete element type

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > linux/time.h conflicts with user space header time.h. Try to be compatible > with both. > > Fixes userspace compilation error: > > error: array type has incomplete element type > struct timespec ts[3]; > > Signed-off-by:

Re: [PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

On Sun, Aug 6, 2017 at 12:44 PM, Mikko Rapeli wrote: > linux/time.h conflicts with user space header time.h. Try to be compatible > with both. > > Fixes userspace compilation error: > > error: array type has incomplete element type > struct timespec ts[3]; > > Signed-off-by: Mikko Rapeli > Cc:

[PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

linux/time.h conflicts with user space header time.h. Try to be compatible with both. Fixes userspace compilation error: error: array type has incomplete element type struct timespec ts[3]; Signed-off-by: Mikko Rapeli Cc: Willem de Bruijn Cc: Soheil

[PATCH v06 18/36] uapi linux/errqueue.h: include linux/time.h in user space

linux/time.h conflicts with user space header time.h. Try to be compatible with both. Fixes userspace compilation error: error: array type has incomplete element type struct timespec ts[3]; Signed-off-by: Mikko Rapeli Cc: Willem de Bruijn Cc: Soheil Hassas Yeganeh Cc: net...@vger.kernel.org