Re: [PATCH v10 0/3] arm: npcm: add basic support for Nuvoton BMCs

2018-02-13 Thread Florian Fainelli 
On 02/13/2018 12:09 PM, Brendan Higgins wrote:
> Addressed comments from:
>  - Joel: https://www.spinics.net/lists/arm-kernel/msg634074.html
>  - Arnd: https://www.spinics.net/lists/arm-kernel/msg634091.html
> 
> Summary of changes since previous update:
>  - Replaced "nuvoton,npcm7xx-smp" compatibility string with
>"nuvoton,npcm750-smp".
>  - Fixed some whitespace issues.
>  - Added EVB DTS to Makefile.
> 
> All changes tested on Nuvoton NPCM750 EVB.
> 

Thanks for keeping me CC, FWIW: Reviewed-by: Florian Fainelli


FWIW, I don't have a vested interest in BMCs in general, just happened
to do a drive by review of your SMP code, no need to CC me on future
submissions (e.g: boards, drivers etc.). Cheers
-- 
Florian

Re: [PATCH v10 0/3] arm: npcm: add basic support for Nuvoton BMCs

2018-02-13 Thread Florian Fainelli 
On 02/13/2018 12:09 PM, Brendan Higgins wrote:
> Addressed comments from:
>  - Joel: https://www.spinics.net/lists/arm-kernel/msg634074.html
>  - Arnd: https://www.spinics.net/lists/arm-kernel/msg634091.html
> 
> Summary of changes since previous update:
>  - Replaced "nuvoton,npcm7xx-smp" compatibility string with
>"nuvoton,npcm750-smp".
>  - Fixed some whitespace issues.
>  - Added EVB DTS to Makefile.
> 
> All changes tested on Nuvoton NPCM750 EVB.
> 

Thanks for keeping me CC, FWIW: Reviewed-by: Florian Fainelli


FWIW, I don't have a vested interest in BMCs in general, just happened
to do a drive by review of your SMP code, no need to CC me on future
submissions (e.g: boards, drivers etc.). Cheers
-- 
Florian

[PATCH v10 0/3] arm: npcm: add basic support for Nuvoton BMCs

2018-02-13 Thread Brendan Higgins 
Addressed comments from:
 - Joel: https://www.spinics.net/lists/arm-kernel/msg634074.html
 - Arnd: https://www.spinics.net/lists/arm-kernel/msg634091.html

Summary of changes since previous update:
 - Replaced "nuvoton,npcm7xx-smp" compatibility string with
   "nuvoton,npcm750-smp".
 - Fixed some whitespace issues.
 - Added EVB DTS to Makefile.

All changes tested on Nuvoton NPCM750 EVB.

[PATCH v10 0/3] arm: npcm: add basic support for Nuvoton BMCs

2018-02-13 Thread Brendan Higgins 
Addressed comments from:
 - Joel: https://www.spinics.net/lists/arm-kernel/msg634074.html
 - Arnd: https://www.spinics.net/lists/arm-kernel/msg634091.html

Summary of changes since previous update:
 - Replaced "nuvoton,npcm7xx-smp" compatibility string with
   "nuvoton,npcm750-smp".
 - Fixed some whitespace issues.
 - Added EVB DTS to Makefile.

All changes tested on Nuvoton NPCM750 EVB.