Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Tue, Jun 19, 2018 at 5:23 PM, Pavel Tatashin wrote: >> > > + *ts = (struct timespec64){0, 0}; >> >> I dunno if additional variable would be better for readability, like >> >> struct timespec64 null_ts = {0,0}; > > I don't mind adding ts_null, but I think, as-is ok here,

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Tue, Jun 19, 2018 at 5:23 PM, Pavel Tatashin wrote: >> > > + *ts = (struct timespec64){0, 0}; >> >> I dunno if additional variable would be better for readability, like >> >> struct timespec64 null_ts = {0,0}; > > I don't mind adding ts_null, but I think, as-is ok here,

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

> > > +void __init read_boot_clock64(struct timespec64 *now, struct timespec64 > > > *ts) > > > +{ > > > + u64 ns_boot = sched_clock_cpu(smp_processor_id()); > > > + bool valid_clock; > > > + u64 ns_now; > > > + > > > + ns_now = timespec64_to_ns(now); > > > +

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

> > > +void __init read_boot_clock64(struct timespec64 *now, struct timespec64 > > > *ts) > > > +{ > > > + u64 ns_boot = sched_clock_cpu(smp_processor_id()); > > > + bool valid_clock; > > > + u64 ns_now; > > > + > > > + ns_now = timespec64_to_ns(now); > > > +

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Mon, Jun 18, 2018 at 11:42 AM Andy Shevchenko wrote: > > On Fri, Jun 15, 2018 at 8:48 PM Pavel Tatashin > wrote: > > > > read_boot_clock64() returns time of when system was started. Now, that > > early boot clock is going to be available on x86 it is possible to > > implement x86 specific

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Mon, Jun 18, 2018 at 11:42 AM Andy Shevchenko wrote: > > On Fri, Jun 15, 2018 at 8:48 PM Pavel Tatashin > wrote: > > > > read_boot_clock64() returns time of when system was started. Now, that > > early boot clock is going to be available on x86 it is possible to > > implement x86 specific

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Fri, Jun 15, 2018 at 8:48 PM Pavel Tatashin wrote: > > read_boot_clock64() returns time of when system was started. Now, that > early boot clock is going to be available on x86 it is possible to > implement x86 specific version of read_boot_clock64() that takes advantage > of this new feature.

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

On Fri, Jun 15, 2018 at 8:48 PM Pavel Tatashin wrote: > > read_boot_clock64() returns time of when system was started. Now, that > early boot clock is going to be available on x86 it is possible to > implement x86 specific version of read_boot_clock64() that takes advantage > of this new feature.

[PATCH v10 3/7] x86/time: read_boot_clock64() implementation

read_boot_clock64() returns time of when system was started. Now, that early boot clock is going to be available on x86 it is possible to implement x86 specific version of read_boot_clock64() that takes advantage of this new feature. Signed-off-by: Pavel Tatashin --- arch/x86/kernel/time.c | 30

[PATCH v10 3/7] x86/time: read_boot_clock64() implementation

read_boot_clock64() returns time of when system was started. Now, that early boot clock is going to be available on x86 it is possible to implement x86 specific version of read_boot_clock64() that takes advantage of this new feature. Signed-off-by: Pavel Tatashin --- arch/x86/kernel/time.c | 30

[PATCH v10 3/7] x86/time: read_boot_clock64() implementation

read_boot_clock64() returns time of when system was started. Now, that early boot clock is going to be available on x86 it is possible to implement x86 specific version of read_boot_clock64() that takes advantage of this new feature. Signed-off-by: Pavel Tatashin ---

[PATCH v10 3/7] x86/time: read_boot_clock64() implementation

read_boot_clock64() returns time of when system was started. Now, that early boot clock is going to be available on x86 it is possible to implement x86 specific version of read_boot_clock64() that takes advantage of this new feature. Signed-off-by: Pavel Tatashin --- arch/x86/kernel/time.c | 30