> [...]
> You have been directly contributing to this patch because several
> improvements of next version are from you. I experienced a similar
> situation when submitting patches for QEMU. The only difference is
> that the feedbacks on the QEMU patches were also given in the format
> of patch.
On Sun, Oct 18, 2020 at 12:23:14PM +, Barnabás Pőcze wrote:
[...]
> > > > > +static int i2c_hid_polling_thread(void *i2c_hid)
> > > > > +{
> > > > >
> > > > > - struct i2c_hid *ihid = i2c_hid;
> > > > > - struct i2c_client *client = ihid->client;
> > > > > - unsigned int
On Sat, Oct 17, 2020 at 02:58:13PM +, Barnabás Pőcze wrote:
[...]
>> >> +static int get_gpio_pin_state(struct irq_desc *irq_desc)
>> >> +{
>> >> + struct gpio_chip *gc =
irq_data_get_irq_chip_data(_desc->irq_data);
>> >> +
>> >> + return gc->get(gc, irq_desc->irq_data.hwirq);
>> >>
> [...]
> > > > > > +static int i2c_hid_polling_thread(void *i2c_hid)
> > > > > > +{
> > > > > >
> > > > > > - struct i2c_hid *ihid = i2c_hid;
> > > > > > - struct i2c_client *client = ihid->client;
> > > > > > - unsigned int polling_interval_idle;
> > > > > > -
> > > > > > - while (1) {
>
> [...]
> >> >> +static int get_gpio_pin_state(struct irq_desc *irq_desc)
> >> >> +{
> >> >> + struct gpio_chip *gc =
> >> >> irq_data_get_irq_chip_data(_desc->irq_data);
> >> >> +
> >> >> + return gc->get(gc, irq_desc->irq_data.hwirq);
> >> >> +}
> >> >> +
> >> >> +static bool
Hi,
On Sat, Oct 17, 2020 at 01:06:14PM +, Barnabás Pőcze wrote:
Hi
[...]
>> +static int get_gpio_pin_state(struct irq_desc *irq_desc)
>> +{
>> + struct gpio_chip *gc =
irq_data_get_irq_chip_data(_desc->irq_data);
>> +
>> + return gc->get(gc, irq_desc->irq_data.hwirq);
>> +}
>>
Hi
> [...]
> >> +static int get_gpio_pin_state(struct irq_desc *irq_desc)
> >> +{
> >> + struct gpio_chip *gc = irq_data_get_irq_chip_data(_desc->irq_data);
> >> +
> >> + return gc->get(gc, irq_desc->irq_data.hwirq);
> >> +}
> >> +
> >> +static bool interrupt_line_active(struct i2c_client
Hi,
Thank you for examine this patch in such a careful way!
On Fri, Oct 16, 2020 at 03:00:49PM +, Barnabás Pőcze wrote:
Hi,
I still think that `i2c_hid_resume()` and `i2c_hid_suspend()` are asymmetric and
that might lead to issues.
Do you think this commit message is relevant to your
Hi,
I still think that `i2c_hid_resume()` and `i2c_hid_suspend()` are asymmetric and
that might lead to issues.
> [...]
> When polling mode is enabled, an I2C device can't wake up the suspended
> system since enable/disable_irq_wake is invalid for polling mode.
>
Excuse my ignorance, but could
For a broken touchpad, it may take several months or longer to be fixed.
Polling mode could be a fallback solution for enthusiastic Linux users
when they have a new laptop. It also acts like a debugging feature. If
polling mode works for a broken touchpad, we can almost be certain
the root cause
10 matches
Mail list logo
