Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Mon, Jun 04, 2018 at 11:27:43AM +0200, Benjamin Berg wrote: > Hi, > > On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote: > > I've made my change to set the brightness level directly in the > > driver, but the > > OSD doesn't show correctly correspond to the level value. The brightness > >

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Mon, Jun 04, 2018 at 11:27:43AM +0200, Benjamin Berg wrote: > Hi, > > On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote: > > I've made my change to set the brightness level directly in the > > driver, but the > > OSD doesn't show correctly correspond to the level value. The brightness > >

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi, On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote: > I've made my change to set the brightness level directly in the > driver, but the > OSD doesn't show correctly correspond to the level value. The brightness shows > OK in /sys/class/led//brighness but the OSD always shows level 0. I

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi, On Thu, 2018-05-24 at 16:33 +0800, Chris Chiu wrote: > I've made my change to set the brightness level directly in the > driver, but the > OSD doesn't show correctly correspond to the level value. The brightness shows > OK in /sys/class/led//brighness but the OSD always shows level 0. I

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 9:48 PM, Daniel Drake wrote: > On Tue, May 22, 2018 at 4:11 AM, Chris Chiu wrote: >> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >>> Btw, I mistakenly thought that patch in the queue for-next, while it's >>> not. So, I'm going

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 9:48 PM, Daniel Drake wrote: > On Tue, May 22, 2018 at 4:11 AM, Chris Chiu wrote: >> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >>> Btw, I mistakenly thought that patch in the queue for-next, while it's >>> not. So, I'm going to drop it now. >>> Feel free to

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 4:11 AM, Chris Chiu wrote: > On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >> Btw, I mistakenly thought that patch in the queue for-next, while it's >> not. So, I'm going to drop it now. >> Feel free to re-submit a new (better) version. > > So it's

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 4:11 AM, Chris Chiu wrote: > On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko >> Btw, I mistakenly thought that patch in the queue for-next, while it's >> not. So, I'm going to drop it now. >> Feel free to re-submit a new (better) version. > > So it's better to handle

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > >> I had a quick chat with Bastien about this. The conclusion was that >> reusing the TOGGLE key may be problematic for

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko wrote: > On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > >> I had a quick chat with Bastien about this. The conclusion was that >> reusing the TOGGLE key may be problematic for gnome-settings-daemon. >> And the alternative of a new CYCLE

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > I had a quick chat with Bastien about this. The conclusion was that > reusing the TOGGLE key may be problematic for gnome-settings-daemon. > And the alternative of a new CYCLE key also has some caveats. > > The most

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 15, 2018 at 4:41 PM, Benjamin Berg wrote: > I had a quick chat with Bastien about this. The conclusion was that > reusing the TOGGLE key may be problematic for gnome-settings-daemon. > And the alternative of a new CYCLE key also has some caveats. > > The most straight forward

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Daniel, I had a quick chat with Bastien about this. The conclusion was that reusing the TOGGLE key may be problematic for gnome-settings-daemon. And the alternative of a new CYCLE key also has some caveats. The most straight forward solution is

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Daniel, I had a quick chat with Bastien about this. The conclusion was that reusing the TOGGLE key may be problematic for gnome-settings-daemon. And the alternative of a new CYCLE key also has some caveats. The most straight forward solution is

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 15, 2018 at 3:25 AM, Daniel Drake wrote: > Hi Andy, > > On Mon, May 7, 2018 at 8:46 AM, Daniel Drake wrote: >> > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard >> > > backlight toggle. In this UX550GE, the hotkey incremet the

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 15, 2018 at 3:25 AM, Daniel Drake wrote: > Hi Andy, > > On Mon, May 7, 2018 at 8:46 AM, Daniel Drake wrote: >> > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard >> > > backlight toggle. In this UX550GE, the hotkey incremet the level >> > > of brightness for each

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi Andy, On Mon, May 7, 2018 at 8:46 AM, Daniel Drake wrote: > > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > > > backlight toggle. In this UX550GE, the hotkey incremet the level > > > of brightness for each keypress from 1 to 3, and then switch it > > >

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi Andy, On Mon, May 7, 2018 at 8:46 AM, Daniel Drake wrote: > > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > > > backlight toggle. In this UX550GE, the hotkey incremet the level > > > of brightness for each keypress from 1 to 3, and then switch it > > > off when the

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi Andy, On Mon, May 7, 2018 at 8:10 AM, Andy Shevchenko wrote: > > On Thu, May 3, 2018 at 6:04 AM, Chris Chiu wrote: > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > > backlight toggle. In this UX550GE, the hotkey incremet the

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Hi Andy, On Mon, May 7, 2018 at 8:10 AM, Andy Shevchenko wrote: > > On Thu, May 3, 2018 at 6:04 AM, Chris Chiu wrote: > > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > > backlight toggle. In this UX550GE, the hotkey incremet the level > > of brightness for each keypress from

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Thu, May 3, 2018 at 6:04 AM, Chris Chiu wrote: > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > backlight toggle. In this UX550GE, the hotkey incremet the level > of brightness for each keypress from 1 to 3, and then switch it > off when the brightness has

Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Thu, May 3, 2018 at 6:04 AM, Chris Chiu wrote: > Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard > backlight toggle. In this UX550GE, the hotkey incremet the level > of brightness for each keypress from 1 to 3, and then switch it > off when the brightness has been the max. This

[PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard backlight toggle. In this UX550GE, the hotkey incremet the level of brightness for each keypress from 1 to 3, and then switch it off when the brightness has been the max. This commit interprets the code 0xc7 generated from hotkey to

[PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

Some Asus laptops like UX550GE has hotkey (Fn+F7) for keyboard backlight toggle. In this UX550GE, the hotkey incremet the level of brightness for each keypress from 1 to 3, and then switch it off when the brightness has been the max. This commit interprets the code 0xc7 generated from hotkey to