Re: [PATCH v2 07/11] usb: gadget: bdc: avoid precedence issues

2020-09-03 Thread Florian Fainelli




On 8/20/2020 4:30 AM, Chunfeng Yun wrote:

Add () around macro argument to avoid precedence issues

Cc: Florian Fainelli 
Signed-off-by: Chunfeng Yun 


Acked-by: Florian Fainelli 
--
Florian


[PATCH v2 07/11] usb: gadget: bdc: avoid precedence issues

2020-08-20 Thread Chunfeng Yun
Add () around macro argument to avoid precedence issues

Cc: Florian Fainelli 
Signed-off-by: Chunfeng Yun 
---
v2: add Cc Florian
---
 drivers/usb/gadget/udc/bdc/bdc.h | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/usb/gadget/udc/bdc/bdc.h b/drivers/usb/gadget/udc/bdc/bdc.h
index 658abef..f8d5958 100644
--- a/drivers/usb/gadget/udc/bdc/bdc.h
+++ b/drivers/usb/gadget/udc/bdc/bdc.h
@@ -86,20 +86,20 @@
 #define BDC_EPSTS5 0x74
 #define BDC_EPSTS6 0x78
 #define BDC_EPSTS7 0x7c
-#define BDC_SRRBAL(n)  (0x200 + (n * 0x10))
-#define BDC_SRRBAH(n)  (0x204 + (n * 0x10))
-#define BDC_SRRINT(n)  (0x208 + (n * 0x10))
-#define BDC_INTCTLS(n) (0x20c + (n * 0x10))
+#define BDC_SRRBAL(n)  (0x200 + ((n) * 0x10))
+#define BDC_SRRBAH(n)  (0x204 + ((n) * 0x10))
+#define BDC_SRRINT(n)  (0x208 + ((n) * 0x10))
+#define BDC_INTCTLS(n) (0x20c + ((n) * 0x10))
 
 /* Extended capability regs */
 #define BDC_FSCNOC 0xcd4
 #define BDC_FSCNIC 0xce4
-#define NUM_NCS(p) (p >> 28)
+#define NUM_NCS(p) ((p) >> 28)
 
 /* Register bit fields and Masks */
 /* BDC Configuration 0 */
 #define BDC_PGS(p) (((p) & (0x7 << 8)) >> 8)
-#define BDC_SPB(p) (p & 0x7)
+#define BDC_SPB(p) ((p) & 0x7)
 
 /* BDC Capability1 */
 #define BDC_P64(1 << 0)
@@ -113,7 +113,7 @@
 #define BDC_CMD_DVC0x1
 #define BDC_CMD_CWS(0x1 << 5)
 #define BDC_CMD_CST(p) (((p) & (0xf << 6))>>6)
-#define BDC_CMD_EPN(p) ((p & 0x1f) << 10)
+#define BDC_CMD_EPN(p) (((p) & 0x1f) << 10)
 #define BDC_SUB_CMD_ADD(0x1 << 17)
 #define BDC_SUB_CMD_FWK(0x4 << 17)
 /* Reset sequence number */
@@ -163,7 +163,7 @@
 #define BDC_SPEED_HS   0x3
 #define BDC_SPEED_SS   0x4
 
-#define BDC_PST(p) (p & 0xf)
+#define BDC_PST(p) ((p) & 0xf)
 #define BDC_PST_MASK   0xf
 
 /* USPPMS */
@@ -228,7 +228,7 @@
 /* status report defines */
 #define SR_XSF 0
 #define SR_USPC4
-#define SR_BD_LEN(p)(p & 0xff)
+#define SR_BD_LEN(p)((p) & 0xff)
 
 #define XSF_SUCC   0x1
 #define XSF_SHORT  0x3
-- 
1.9.1