Re: [PATCH v2 08/17] arm64: dts: qcom: pms405: add spmi node

2018-11-05 Thread Bjorn Andersson 
On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote:

> Add the pms405 DT file with spmi node.
> 
> Signed-off-by: Vinod Koul 
> ---
>  arch/arm64/boot/dts/qcom/pms405.dtsi | 15 +++
>  1 file changed, 15 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/pms405.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi 
> b/arch/arm64/boot/dts/qcom/pms405.dtsi
> new file mode 100644
> index ..8a585180f102
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2018, Linaro Limited
> +
> +#include 
> +
> +_bus {
> +

Please drop the empty line.

Reviewed-by: Bjorn Andersson 

Regards,
Bjorn

> + pms405_0: pms405@0 {
> + compatible = "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + };
> +};
> -- 
> 2.14.4
>

Re: [PATCH v2 08/17] arm64: dts: qcom: pms405: add spmi node

2018-11-05 Thread Bjorn Andersson 
On Mon 05 Nov 07:45 PST 2018, Vinod Koul wrote:

> Add the pms405 DT file with spmi node.
> 
> Signed-off-by: Vinod Koul 
> ---
>  arch/arm64/boot/dts/qcom/pms405.dtsi | 15 +++
>  1 file changed, 15 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/pms405.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi 
> b/arch/arm64/boot/dts/qcom/pms405.dtsi
> new file mode 100644
> index ..8a585180f102
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2018, Linaro Limited
> +
> +#include 
> +
> +_bus {
> +

Please drop the empty line.

Reviewed-by: Bjorn Andersson 

Regards,
Bjorn

> + pms405_0: pms405@0 {
> + compatible = "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + };
> +};
> -- 
> 2.14.4
>

[PATCH v2 08/17] arm64: dts: qcom: pms405: add spmi node

2018-11-05 Thread Vinod Koul 
Add the pms405 DT file with spmi node.

Signed-off-by: Vinod Koul 
---
 arch/arm64/boot/dts/qcom/pms405.dtsi | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pms405.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi 
b/arch/arm64/boot/dts/qcom/pms405.dtsi
new file mode 100644
index ..8a585180f102
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2018, Linaro Limited
+
+#include 
+
+_bus {
+
+   pms405_0: pms405@0 {
+   compatible = "qcom,spmi-pmic";
+   reg = <0x0 SPMI_USID>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   };
+};
-- 
2.14.4

[PATCH v2 08/17] arm64: dts: qcom: pms405: add spmi node

2018-11-05 Thread Vinod Koul 
Add the pms405 DT file with spmi node.

Signed-off-by: Vinod Koul 
---
 arch/arm64/boot/dts/qcom/pms405.dtsi | 15 +++
 1 file changed, 15 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pms405.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi 
b/arch/arm64/boot/dts/qcom/pms405.dtsi
new file mode 100644
index ..8a585180f102
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2018, Linaro Limited
+
+#include 
+
+_bus {
+
+   pms405_0: pms405@0 {
+   compatible = "qcom,spmi-pmic";
+   reg = <0x0 SPMI_USID>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   };
+};
-- 
2.14.4