Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

2020-07-31 Thread Rob Herring
On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote:
> This patch adds DT bindings for the new Microchip S/PDIF TX Controller
> embedded inside sama7g5 SoCs.
> 
> Signed-off-by: Codrin Ciubotariu 
> ---
> 
> Changes in v2:
>  - replaced https with http
>  - reworked example, included bindings;
> 
>  .../bindings/sound/mchp,spdiftx.yaml  | 80 +++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml 
> b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> new file mode 100644
> index ..2b7c27391f0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip S/PDIF Tx Controller Device Tree Bindings
> +
> +maintainers:
> +  - Codrin Ciubotariu 
> +
> +description:
> +The Microchip Sony/Philips Digital Interface Transmitter is a
> +serial port compliant with the IEC-60958 standard.
> +
> +properties:
> +  "#sound-dai-cells":
> +const: 0
> +
> +  compatible:
> +oneOf:
> +  - const: microchip,sama7g5-spdiftx

No need for 'oneOf' when only 1 entry.

> +
> +  reg:
> +maxItems: 1
> +
> +  interrupts:
> +maxItems: 1
> +
> +  clocks:
> +items:
> +  - description: Peripheral Bus Clock
> +  - description: Generic Clock
> +
> +  clock-names:
> +items:
> +  - const: pclk
> +  - const: gclk
> +
> +  dmas:
> +description: TX DMA Channel

How many? (maxItems: 1)

> +
> +  dma-names:
> +const: tx
> +
> +  pinctrl-0: true
> +
> +  pinctrl-names:
> +const: default

You can drop pinctrl props. They are always allowed.

> +
> +required:
> +  - "#sound-dai-cells"
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - dmas
> +  - dma-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +#include 
> +#include 
> +#include 
> +
> +spdiftx@e1618000 {
> +#sound-dai-cells = <0>;
> +compatible = "microchip,sama7g5-spdiftx";
> +reg = <0xe1618000 0x4000>;
> +interrupts = ;
> +dmas = < AT91_XDMAC_DT_PERID(50)>;
> +dma-names = "tx";
> +clocks = < PMC_TYPE_PERIPHERAL 85>, < PMC_TYPE_GCK 85>;
> +clock-names = "pclk", "gclk";
> +pinctrl-names = "default";
> +pinctrl-0 = <_spdiftx_default>;
> +};
> -- 
> 2.25.1
> 


[PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

2020-07-29 Thread Codrin Ciubotariu
This patch adds DT bindings for the new Microchip S/PDIF TX Controller
embedded inside sama7g5 SoCs.

Signed-off-by: Codrin Ciubotariu 
---

Changes in v2:
 - replaced https with http
 - reworked example, included bindings;

 .../bindings/sound/mchp,spdiftx.yaml  | 80 +++
 1 file changed, 80 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml

diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml 
b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
new file mode 100644
index ..2b7c27391f0d
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip S/PDIF Tx Controller Device Tree Bindings
+
+maintainers:
+  - Codrin Ciubotariu 
+
+description:
+The Microchip Sony/Philips Digital Interface Transmitter is a
+serial port compliant with the IEC-60958 standard.
+
+properties:
+  "#sound-dai-cells":
+const: 0
+
+  compatible:
+oneOf:
+  - const: microchip,sama7g5-spdiftx
+
+  reg:
+maxItems: 1
+
+  interrupts:
+maxItems: 1
+
+  clocks:
+items:
+  - description: Peripheral Bus Clock
+  - description: Generic Clock
+
+  clock-names:
+items:
+  - const: pclk
+  - const: gclk
+
+  dmas:
+description: TX DMA Channel
+
+  dma-names:
+const: tx
+
+  pinctrl-0: true
+
+  pinctrl-names:
+const: default
+
+required:
+  - "#sound-dai-cells"
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - dmas
+  - dma-names
+
+additionalProperties: false
+
+examples:
+  - |
+#include 
+#include 
+#include 
+
+spdiftx@e1618000 {
+#sound-dai-cells = <0>;
+compatible = "microchip,sama7g5-spdiftx";
+reg = <0xe1618000 0x4000>;
+interrupts = ;
+dmas = < AT91_XDMAC_DT_PERID(50)>;
+dma-names = "tx";
+clocks = < PMC_TYPE_PERIPHERAL 85>, < PMC_TYPE_GCK 85>;
+clock-names = "pclk", "gclk";
+pinctrl-names = "default";
+pinctrl-0 = <_spdiftx_default>;
+};
-- 
2.25.1