Re: [PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors

2019-09-19 Thread Hawa, Hanna




On 9/19/2019 9:33 AM, Robert Richter wrote:

On 12.09.19 15:53:04, Hanna Hawa wrote:

Add an API for EDAC device to report multiple errors with same type.

Signed-off-by: Hanna Hawa 
---
  drivers/edac/edac_device.c | 91 ++
  drivers/edac/edac_device.h | 40 +
  2 files changed, 131 insertions(+)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 65cf2b9355c4..78ac44103acc 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_info 
*edac_dev,
block ? block->name : "N/A", msg);
  }
  EXPORT_SYMBOL_GPL(edac_device_handle_ue);
+
+void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
+unsigned int count, int inst_nr, int block_nr,
+const char *msg)
+{


Please do not add a copy here, instead modify the existing function
and share the code with both, old and new functions.


Will be fixed.



Thanks,

-Robert



Re: [PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors

2019-09-19 Thread Robert Richter
On 12.09.19 15:53:04, Hanna Hawa wrote:
> Add an API for EDAC device to report multiple errors with same type.
> 
> Signed-off-by: Hanna Hawa 
> ---
>  drivers/edac/edac_device.c | 91 ++
>  drivers/edac/edac_device.h | 40 +
>  2 files changed, 131 insertions(+)
> 
> diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
> index 65cf2b9355c4..78ac44103acc 100644
> --- a/drivers/edac/edac_device.c
> +++ b/drivers/edac/edac_device.c
> @@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_info 
> *edac_dev,
>   block ? block->name : "N/A", msg);
>  }
>  EXPORT_SYMBOL_GPL(edac_device_handle_ue);
> +
> +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
> +  unsigned int count, int inst_nr, int block_nr,
> +  const char *msg)
> +{

Please do not add a copy here, instead modify the existing function
and share the code with both, old and new functions.

Thanks,

-Robert


[PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors

2019-09-12 Thread Hanna Hawa
Add an API for EDAC device to report multiple errors with same type.

Signed-off-by: Hanna Hawa 
---
 drivers/edac/edac_device.c | 91 ++
 drivers/edac/edac_device.h | 40 +
 2 files changed, 131 insertions(+)

diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c
index 65cf2b9355c4..78ac44103acc 100644
--- a/drivers/edac/edac_device.c
+++ b/drivers/edac/edac_device.c
@@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_info 
*edac_dev,
block ? block->name : "N/A", msg);
 }
 EXPORT_SYMBOL_GPL(edac_device_handle_ue);
+
+void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev,
+unsigned int count, int inst_nr, int block_nr,
+const char *msg)
+{
+   struct edac_device_instance *instance;
+   struct edac_device_block *block = NULL;
+
+   if (!count)
+   return;
+
+   if ((inst_nr >= edac_dev->nr_instances) || (inst_nr < 0)) {
+   edac_device_printk(edac_dev, KERN_ERR,
+  "INTERNAL ERROR: 'instance' out of range (%d 
>= %d)\n",
+  inst_nr, edac_dev->nr_instances);
+   return;
+   }
+
+   instance = edac_dev->instances + inst_nr;
+
+   if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) {
+   edac_device_printk(edac_dev, KERN_ERR,
+   "INTERNAL ERROR: instance %d 'block' out of 
range (%d >= %d)\n",
+   inst_nr, block_nr, instance->nr_blocks);
+   return;
+   }
+
+   if (instance->nr_blocks > 0) {
+   block = instance->blocks + block_nr;
+   block->counters.ce_count += count;
+   }
+
+   /* Propagate the count up the 'totals' tree */
+   instance->counters.ce_count += count;
+   edac_dev->counters.ce_count += count;
+
+   if (edac_device_get_log_ce(edac_dev))
+   edac_device_printk(edac_dev, KERN_WARNING,
+  "CE: %s instance: %s block: %s count: %d 
'%s'\n",
+  edac_dev->ctl_name, instance->name,
+  block ? block->name : "N/A", count, msg);
+}
+EXPORT_SYMBOL_GPL(__edac_device_handle_ce);
+
+void __edac_device_handle_ue(struct edac_device_ctl_info *edac_dev,
+unsigned int count, int inst_nr, int block_nr,
+const char *msg)
+{
+   struct edac_device_instance *instance;
+   struct edac_device_block *block = NULL;
+
+   if (!count)
+   return;
+
+   if ((inst_nr >= edac_dev->nr_instances) || (inst_nr < 0)) {
+   edac_device_printk(edac_dev, KERN_ERR,
+  "INTERNAL ERROR: 'instance' out of range (%d 
>= %d)\n",
+  inst_nr, edac_dev->nr_instances);
+   return;
+   }
+
+   instance = edac_dev->instances + inst_nr;
+
+   if ((block_nr >= instance->nr_blocks) || (block_nr < 0)) {
+   edac_device_printk(edac_dev, KERN_ERR,
+  "INTERNAL ERROR: instance %d 'block' out of 
range (%d >= %d)\n",
+  inst_nr, block_nr, instance->nr_blocks);
+   return;
+   }
+
+   if (instance->nr_blocks > 0) {
+   block = instance->blocks + block_nr;
+   block->counters.ue_count += count;
+   }
+
+   /* Propagate the count up the 'totals' tree */
+   instance->counters.ue_count += count;
+   edac_dev->counters.ue_count += count;
+
+   if (edac_device_get_log_ue(edac_dev))
+   edac_device_printk(edac_dev, KERN_EMERG,
+  "UE: %s instance: %s block: %s count: %d 
'%s'\n",
+  edac_dev->ctl_name, instance->name,
+  block ? block->name : "N/A", count, msg);
+
+   if (edac_device_get_panic_on_ue(edac_dev))
+   panic("EDAC %s: UE instance: %s block %s count: %d '%s'\n",
+ edac_dev->ctl_name, instance->name,
+ block ? block->name : "N/A", count, msg);
+}
+EXPORT_SYMBOL_GPL(__edac_device_handle_ue);
diff --git a/drivers/edac/edac_device.h b/drivers/edac/edac_device.h
index 1aaba74ae411..30dc5f5979c8 100644
--- a/drivers/edac/edac_device.h
+++ b/drivers/edac/edac_device.h
@@ -317,4 +317,44 @@ extern void edac_device_handle_ce(struct 
edac_device_ctl_info *edac_dev,
 extern int edac_device_alloc_index(void);
 extern const char *edac_layer_name[];
 
+/**
+ * __edac_device_handle_ue():
+ * perform a common output and handling of an 'edac_dev' UE event
+ *
+ * @edac_dev: pointer to struct _device_ctl_info
+ * @error_count: number of errors of the same type
+ * @inst_nr: number of the instance where the UE error happened
+ * @block_nr: