Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-02 Thread Zhang Rui
On Wed, 2020-07-01 at 11:50 +0200, Daniel Lezcano wrote: > On 01/07/2020 09:57, Zhang Rui wrote: > > [ ... ] > > > > Do you want to move them out? > > > > Then no. I don't have any objection of removing thermal_helper.c, > > so > > you can just leave these functions in thermal_core.c > > Shall

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 11:26, Amit Kucheria wrote: > On Wed, Jul 1, 2020 at 1:27 PM Zhang Rui wrote: [ ... ] >> Then no. I don't have any objection of removing thermal_helper.c, so >> you can just leave these functions in thermal_core.c > > In that case, Daniel, please find attached a patch to move the

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 09:57, Zhang Rui wrote: [ ... ] >> Do you want to move them out? > > Then no. I don't have any objection of removing thermal_helper.c, so > you can just leave these functions in thermal_core.c Shall I consider that as an ack for this patch ? --

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Amit Kucheria
On Wed, Jul 1, 2020 at 1:27 PM Zhang Rui wrote: > > On Wed, 2020-07-01 at 09:35 +0200, Daniel Lezcano wrote: > > On 30/06/2020 17:09, Zhang Rui wrote: > > > Hi, Daniel, > > > > > > seems that you forgot to cc linux-pm mailing list. > > > > > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Zhang Rui
On Wed, 2020-07-01 at 09:35 +0200, Daniel Lezcano wrote: > On 30/06/2020 17:09, Zhang Rui wrote: > > Hi, Daniel, > > > > seems that you forgot to cc linux-pm mailing list. > > > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: > > > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano > > >

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Daniel Lezcano
On 30/06/2020 17:09, Zhang Rui wrote: > Hi, Daniel, > > seems that you forgot to cc linux-pm mailing list. > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: >> On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano >> wrote: >>> >>> The cdev, tz and governor list, as well as their respective

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Daniel Lezcano
On 30/06/2020 20:46, Amit Kucheria wrote: > On Tue, Jun 30, 2020 at 8:40 PM Zhang Rui wrote: >> >> Hi, Daniel, >> >> seems that you forgot to cc linux-pm mailing list. >> >> On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: >>> On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano >>> wrote:

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-06-30 Thread Amit Kucheria
On Tue, Jun 30, 2020 at 8:40 PM Zhang Rui wrote: > > Hi, Daniel, > > seems that you forgot to cc linux-pm mailing list. > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: > > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano > > wrote: > > > > > > The cdev, tz and governor list, as well as

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-06-30 Thread Zhang Rui
Hi, Daniel, seems that you forgot to cc linux-pm mailing list. On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano > wrote: > > > > The cdev, tz and governor list, as well as their respective locks > > are > > statically defined in the

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-06-30 Thread Amit Kucheria
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano wrote: > > The cdev, tz and governor list, as well as their respective locks are > statically defined in the thermal_core.c file. > > In order to give a sane access to these list, like browsing all the > thermal zones or all the cooling devices,

[PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-06-25 Thread Daniel Lezcano
The cdev, tz and governor list, as well as their respective locks are statically defined in the thermal_core.c file. In order to give a sane access to these list, like browsing all the thermal zones or all the cooling devices, let's define a set of helpers where we pass a callback as a parameter