Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Sun, Aug 13, 2017 at 2:00 AM, Srinivas Pandruvada wrote: > On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote: >> On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada >> wrote: >> > >> > On Sat, 2017-08-12 at

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Sun, Aug 13, 2017 at 2:00 AM, Srinivas Pandruvada wrote: > On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote: >> On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada >> wrote: >> > >> > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: >> > [...] >> > >> > > >> > > > >> > >

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Srinivas Pandruvada
On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote: > On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada > wrote: > > > > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: > > [...] > > > > > > > > > > > > > + > > > > +struct

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Srinivas Pandruvada
On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote: > On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada > wrote: > > > > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: > > [...] > > > > > > > > > > > > > + > > > > +struct lpi_constraints { > > > > +   char *name; > > >

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada wrote: > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: > [...] > >> > + >> > +struct lpi_constraints { >> > + char *name; >> > + int min_dstate; >> If you store the handle here as well, you

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada wrote: > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: > [...] > >> > + >> > +struct lpi_constraints { >> > + char *name; >> > + int min_dstate; >> If you store the handle here as well, you won't need to >> look it up every

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Srinivas Pandruvada
On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: [...] > > + > > +struct lpi_constraints { > > + char *name; > > + int min_dstate; > If you store the handle here as well, you won't need to > look it up every time _check_constraints() is called. The reason I didn't keep handle

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Srinivas Pandruvada
On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote: [...] > > + > > +struct lpi_constraints { > > + char *name; > > + int min_dstate; > If you store the handle here as well, you won't need to > look it up every time _check_constraints() is called. The reason I didn't keep handle

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Friday, August 11, 2017 8:23:55 PM CEST Srinivas Pandruvada wrote: > For SoC to achieve its lowest power platform idle state a set of hardware > preconditions must be met. These preconditions or constraints can be > obtained by issuing a device specific method (_DSM) with function "1". > Refer

Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-12 Thread Rafael J. Wysocki
On Friday, August 11, 2017 8:23:55 PM CEST Srinivas Pandruvada wrote: > For SoC to achieve its lowest power platform idle state a set of hardware > preconditions must be met. These preconditions or constraints can be > obtained by issuing a device specific method (_DSM) with function "1". > Refer

[PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-11 Thread Srinivas Pandruvada
For SoC to achieve its lowest power platform idle state a set of hardware preconditions must be met. These preconditions or constraints can be obtained by issuing a device specific method (_DSM) with function "1". Refer to the document provided in the link below. Here during initialization (from

[PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only

2017-08-11 Thread Srinivas Pandruvada
For SoC to achieve its lowest power platform idle state a set of hardware preconditions must be met. These preconditions or constraints can be obtained by issuing a device specific method (_DSM) with function "1". Refer to the document provided in the link below. Here during initialization (from