> Hmm, I forgot about that quirk. I would expect the TDX Module to inject a #GP
> for that case. I can't find anything in the spec that confirms or denies
> that,
> but injecting #VE would be weird and pointless.
>
> Andi/Sathya, the TDX Module spec should be updated to state that XSETBV will
On Tue, Mar 30, 2021, Andy Lutomirski wrote:
>
> > On Mar 30, 2021, at 8:14 AM, Sean Christopherson wrote:
> >
> > On Mon, Mar 29, 2021, Andy Lutomirski wrote:
> >>
> On Mar 29, 2021, at 7:04 PM, Andi Kleen wrote:
> >>>
> >>>
>
> > No, if these instructions take a #VE then
> On Mar 30, 2021, at 8:14 AM, Sean Christopherson wrote:
>
> On Mon, Mar 29, 2021, Andy Lutomirski wrote:
>>
On Mar 29, 2021, at 7:04 PM, Andi Kleen wrote:
>>>
>>>
> No, if these instructions take a #VE then they were executed at CPL=0.
> MONITOR
> and MWAIT
On Mon, Mar 29, 2021, Andy Lutomirski wrote:
>
> > On Mar 29, 2021, at 7:04 PM, Andi Kleen wrote:
> >
> >
> >>
> >>> No, if these instructions take a #VE then they were executed at CPL=0.
> >>> MONITOR
> >>> and MWAIT will #UD without VM-Exit->#VE. Same for WBINVD, s/#UD/#GP.
> >>
> >>
> On Mar 29, 2021, at 7:04 PM, Andi Kleen wrote:
>
>
>>
>>> No, if these instructions take a #VE then they were executed at CPL=0.
>>> MONITOR
>>> and MWAIT will #UD without VM-Exit->#VE. Same for WBINVD, s/#UD/#GP.
>>
>> Dare I ask about XSETBV?
>
> XGETBV does not cause a #VE, it
> > No, if these instructions take a #VE then they were executed at CPL=0.
> > MONITOR
> > and MWAIT will #UD without VM-Exit->#VE. Same for WBINVD, s/#UD/#GP.
>
> Dare I ask about XSETBV?
XGETBV does not cause a #VE, it just works normally. The guest has full
AVX capabilities.
-Andi
On Mon, Mar 29, 2021 at 4:42 PM Sean Christopherson wrote:
>
> On Mon, Mar 29, 2021, Kuppuswamy, Sathyanarayanan wrote:
> >
> >
> > On 3/29/21 4:23 PM, Andy Lutomirski wrote:
> > >
> > > > On Mar 29, 2021, at 4:17 PM, Kuppuswamy Sathyanarayanan
> > > > wrote:
> > > >
> > > > In non-root TDX
On Mon, Mar 29, 2021, Kuppuswamy, Sathyanarayanan wrote:
>
>
> On 3/29/21 4:23 PM, Andy Lutomirski wrote:
> >
> > > On Mar 29, 2021, at 4:17 PM, Kuppuswamy Sathyanarayanan
> > > wrote:
> > >
> > > In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
> > > are not supported. So
On Mon, Mar 29, 2021, Andy Lutomirski wrote:
>
> > On Mar 29, 2021, at 4:17 PM, Kuppuswamy Sathyanarayanan
> > wrote:
> >
> > In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
> > are not supported. So handle #VE due to these instructions
> > appropriately.
>
> Is there
On 3/29/21 4:16 PM, Kuppuswamy Sathyanarayanan wrote:
> In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
> are not supported. So handle #VE due to these instructions
> appropriately.
This misses a key detail:
"are not supported" ... and other patches have prevented a
On 3/29/21 4:23 PM, Andy Lutomirski wrote:
On Mar 29, 2021, at 4:17 PM, Kuppuswamy Sathyanarayanan
wrote:
In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
are not supported. So handle #VE due to these instructions
appropriately.
Is there something I missed elsewhere
> On Mar 29, 2021, at 4:17 PM, Kuppuswamy Sathyanarayanan
> wrote:
>
> In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
> are not supported. So handle #VE due to these instructions
> appropriately.
Is there something I missed elsewhere in the code that checks CPL?
In non-root TDX guest mode, MWAIT, MONITOR and WBINVD instructions
are not supported. So handle #VE due to these instructions
appropriately.
Since the impact of executing WBINVD instruction in non ring-0 mode
can be heavy, use BUG() to report it. For others, raise a WARNING
message.
13 matches
Mail list logo