Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style
On Mon, Apr 05, 2021 at 12:53:22PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > > Changed the permissions to preferred octal style. > > > > Signed-off-by: Luiz Sampaio > > --- > > drivers/w1/slaves/w1_ds2438.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c > > index 56e53a748059..ccb06b8c2d78 100644 > > --- a/drivers/w1/slaves/w1_ds2438.c > > +++ b/drivers/w1/slaves/w1_ds2438.c > > @@ -388,7 +388,7 @@ static ssize_t vdd_read(struct file *filp, struct > > kobject *kobj, > > return ret; > > } > > > > -static BIN_ATTR(iad, S_IRUGO | S_IWUSR | S_IWGRP, iad_read, iad_write, 0); > > +static BIN_ATTR(iad, 0664, iad_read, iad_write, 0); > > Why not BIN_ATTR_RW() instead? > > thanks, > > greg k-h I agree! Thanks for the review. I will change for the next version.
Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style
On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c > index 56e53a748059..ccb06b8c2d78 100644 > --- a/drivers/w1/slaves/w1_ds2438.c > +++ b/drivers/w1/slaves/w1_ds2438.c > @@ -388,7 +388,7 @@ static ssize_t vdd_read(struct file *filp, struct kobject > *kobj, > return ret; > } > > -static BIN_ATTR(iad, S_IRUGO | S_IWUSR | S_IWGRP, iad_read, iad_write, 0); > +static BIN_ATTR(iad, 0664, iad_read, iad_write, 0); Why not BIN_ATTR_RW() instead? thanks, greg k-h
[PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/w1/slaves/w1_ds2438.c +++ b/drivers/w1/slaves/w1_ds2438.c @@ -388,7 +388,7 @@ static ssize_t vdd_read(struct file *filp, struct kobject *kobj, return ret; } -static BIN_ATTR(iad, S_IRUGO | S_IWUSR | S_IWGRP, iad_read, iad_write, 0); +static BIN_ATTR(iad, 0664, iad_read, iad_write, 0); static BIN_ATTR_RO(page0, DS2438_PAGE_SIZE); static BIN_ATTR_RO(temperature, 0/* real length varies */); static BIN_ATTR_RO(vad, 0/* real length varies */); -- 2.30.1