Re: [PATCH v4 tip/core/rcu 05/38] rcu-tasks: Move Tasks RCU to its own file

2020-05-10 Thread Paul E. McKenney
On Sun, May 10, 2020 at 03:42:52PM +0800, Lai Jiangshan wrote:
> On Thu, Apr 16, 2020 at 2:19 AM  wrote:
> >
> > From: "Paul E. McKenney" 
> >
> > This code-movement-only commit is in preparation for adding an additional
> > flavor of Tasks RCU, which relies on workqueues to detect grace periods.
> >
> > Signed-off-by: Paul E. McKenney 
> > ---
> >  kernel/rcu/tasks.h  | 370 
> > 
> >  kernel/rcu/update.c | 366 
> > +--
> 
> Hello Paul
> 
> Makes it kernel/rcu/tasks.c?
> 
> One of my old patch split it into a c-file, and it did work.
> Is there anything new or planed that prevents it to be a c-file?

It quite likely could be a c-file, but let's see things play out with
your suggestion of replacing Tasks RCU with a check in the scheduler
before making such a change.

Thanx, Paul

> thanks
> Lai
> 
> >
> > +#include "tasks.h"
> > +
> >  #ifndef CONFIG_TINY_RCU
> >
> >  /*
> > --
> > 2.9.5
> >


Re: [PATCH v4 tip/core/rcu 05/38] rcu-tasks: Move Tasks RCU to its own file

2020-05-10 Thread Lai Jiangshan
On Thu, Apr 16, 2020 at 2:19 AM  wrote:
>
> From: "Paul E. McKenney" 
>
> This code-movement-only commit is in preparation for adding an additional
> flavor of Tasks RCU, which relies on workqueues to detect grace periods.
>
> Signed-off-by: Paul E. McKenney 
> ---
>  kernel/rcu/tasks.h  | 370 
> 
>  kernel/rcu/update.c | 366 +--

Hello Paul

Makes it kernel/rcu/tasks.c?

One of my old patch split it into a c-file, and it did work.
Is there anything new or planed that prevents it to be a c-file?

thanks
Lai

>
> +#include "tasks.h"
> +
>  #ifndef CONFIG_TINY_RCU
>
>  /*
> --
> 2.9.5
>