Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-27 Thread Oleg Nesterov
On 07/24, Ravi Bangoria wrote: > > > Perhaps we can even add another flag later, MMF_HAS_DELAYED_UPROBES set by > > delayed_uprobe_add(). > > Yes, good idea. But let me repeat, lets do this later. We can do even better I think, say, move this delaed-list into uprobes_state. But imo the 1st

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-27 Thread Oleg Nesterov
On 07/24, Ravi Bangoria wrote: > > > Perhaps we can even add another flag later, MMF_HAS_DELAYED_UPROBES set by > > delayed_uprobe_add(). > > Yes, good idea. But let me repeat, lets do this later. We can do even better I think, say, move this delaed-list into uprobes_state. But imo the 1st

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-24 Thread Masami Hiramatsu
Hi Ravi, Thank you for updating the series. At least trace_uprobe side, it looks good to me ;) Reviewed-by: Masami Hiramatsu Thanks! On Mon, 16 Jul 2018 14:17:03 +0530 Ravi Bangoria wrote: > Userspace Statically Defined Tracepoints[1] are dtrace style markers > inside userspace

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-24 Thread Masami Hiramatsu
Hi Ravi, Thank you for updating the series. At least trace_uprobe side, it looks good to me ;) Reviewed-by: Masami Hiramatsu Thanks! On Mon, 16 Jul 2018 14:17:03 +0530 Ravi Bangoria wrote: > Userspace Statically Defined Tracepoints[1] are dtrace style markers > inside userspace

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-23 Thread Ravi Bangoria
Hi Oleg, On 07/23/2018 09:56 PM, Oleg Nesterov wrote: > I have a mixed feeling about this series... I'll try to summarise my thinking > tomorrow, but I do not see any obvious problem so far. Although I have some > concerns about 5/6, I need to re-read it after sleep. Sure. > > > On 07/16,

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-23 Thread Ravi Bangoria
Hi Oleg, On 07/23/2018 09:56 PM, Oleg Nesterov wrote: > I have a mixed feeling about this series... I'll try to summarise my thinking > tomorrow, but I do not see any obvious problem so far. Although I have some > concerns about 5/6, I need to re-read it after sleep. Sure. > > > On 07/16,

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-23 Thread Oleg Nesterov
I have a mixed feeling about this series... I'll try to summarise my thinking tomorrow, but I do not see any obvious problem so far. Although I have some concerns about 5/6, I need to re-read it after sleep. On 07/16, Ravi Bangoria wrote: > > +static int delayed_uprobe_install(struct

Re: [PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-23 Thread Oleg Nesterov
I have a mixed feeling about this series... I'll try to summarise my thinking tomorrow, but I do not see any obvious problem so far. Although I have some concerns about 5/6, I need to re-read it after sleep. On 07/16, Ravi Bangoria wrote: > > +static int delayed_uprobe_install(struct

[PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-16 Thread Ravi Bangoria
Userspace Statically Defined Tracepoints[1] are dtrace style markers inside userspace applications. Applications like PostgreSQL, MySQL, Pthread, Perl, Python, Java, Ruby, Node.js, libvirt, QEMU, glib etc have these markers embedded in them. These markers are added by developer at important places

[PATCH v6 3/6] Uprobes: Support SDT markers having reference count (semaphore)

2018-07-16 Thread Ravi Bangoria
Userspace Statically Defined Tracepoints[1] are dtrace style markers inside userspace applications. Applications like PostgreSQL, MySQL, Pthread, Perl, Python, Java, Ruby, Node.js, libvirt, QEMU, glib etc have these markers embedded in them. These markers are added by developer at important places