Re: [PATCH v6 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests

2021-04-07 Thread Andrew Jones
On Wed, Apr 07, 2021 at 12:14:29PM +0200, Auger Eric wrote: > >> +int _kvm_create_device(struct kvm_vm *vm, uint64_t type, bool test) > >> +{ > >> + struct kvm_create_device create_dev; > >> + int ret; > >> + > >> + create_dev.type = type; > >> + create_dev.fd = -1; > >> + create_dev.flags =

Re: [PATCH v6 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests

2021-04-07 Thread Auger Eric
Hi Drew, On 4/6/21 5:09 PM, Andrew Jones wrote: > > Hi Eric, > > It looks like Marc already picked this patch up, but, FWIW, here's > a few more comments you may consider. I will send a fixup patch on top of the one taken my Marc. Few comments below. > > On Mon, Apr 05, 2021 at 06:39:41PM

Re: [PATCH v6 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests

2021-04-06 Thread Marc Zyngier
On Tue, 06 Apr 2021 16:09:16 +0100, Andrew Jones wrote: > > > Hi Eric, > > It looks like Marc already picked this patch up, but, FWIW, here's > a few more comments you may consider. FWIW, I'm happy to drop this patch from the queue (the series is on its own branch for this reason), or take

Re: [PATCH v6 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests

2021-04-06 Thread Andrew Jones
Hi Eric, It looks like Marc already picked this patch up, but, FWIW, here's a few more comments you may consider. On Mon, Apr 05, 2021 at 06:39:41PM +0200, Eric Auger wrote: > The tests exercise the VGIC_V3 device creation including the > associated KVM_DEV_ARM_VGIC_GRP_ADDR group attributes:

[PATCH v6 9/9] KVM: selftests: aarch64/vgic-v3 init sequence tests

2021-04-05 Thread Eric Auger
The tests exercise the VGIC_V3 device creation including the associated KVM_DEV_ARM_VGIC_GRP_ADDR group attributes: - KVM_VGIC_V3_ADDR_TYPE_DIST/REDIST - KVM_VGIC_V3_ADDR_TYPE_REDIST_REGION Some other tests dedicate to KVM_DEV_ARM_VGIC_GRP_REDIST_REGS group and especially the GICR_TYPER read.