Re: [PATCHv7 04/14] x86/boot/efi: Fix __KERNEL_CS definition of GDT entry on 64-bit configuration

2017-06-08 Thread Matt Fleming
On Tue, 06 Jun, at 02:31:23PM, Kirill A. Shutemov wrote:
> Define __KERNEL_CS GDT entry as long mode (.L=1, .D=0) on 64-bit
> configuration.
> 
> Signed-off-by: Kirill A. Shutemov 
> Cc: Matt Fleming 
> ---
>  arch/x86/boot/compressed/eboot.c | 9 +++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Matt Fleming 


Re: [PATCHv7 04/14] x86/boot/efi: Fix __KERNEL_CS definition of GDT entry on 64-bit configuration

2017-06-08 Thread Matt Fleming
On Tue, 06 Jun, at 02:31:23PM, Kirill A. Shutemov wrote:
> Define __KERNEL_CS GDT entry as long mode (.L=1, .D=0) on 64-bit
> configuration.
> 
> Signed-off-by: Kirill A. Shutemov 
> Cc: Matt Fleming 
> ---
>  arch/x86/boot/compressed/eboot.c | 9 +++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Matt Fleming 


[PATCHv7 04/14] x86/boot/efi: Fix __KERNEL_CS definition of GDT entry on 64-bit configuration

2017-06-06 Thread Kirill A. Shutemov
Define __KERNEL_CS GDT entry as long mode (.L=1, .D=0) on 64-bit
configuration.

Signed-off-by: Kirill A. Shutemov 
Cc: Matt Fleming 
---
 arch/x86/boot/compressed/eboot.c | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 1d5093d1f319..b75c20f779ea 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -1059,8 +1059,13 @@ struct boot_params *efi_main(struct efi_config *c,
desc->p = 1;
desc->limit = 0xf;
desc->avl = 0;
-   desc->l = 0;
-   desc->d = SEG_OP_SIZE_32BIT;
+   if (IS_ENABLED(CONFIG_X86_64)) {
+   desc->l = 1;
+   desc->d = 0;
+   } else {
+   desc->l = 0;
+   desc->d = SEG_OP_SIZE_32BIT;
+   }
desc->g = SEG_GRANULARITY_4KB;
desc->base2 = 0x00;
desc++;
-- 
2.11.0



[PATCHv7 04/14] x86/boot/efi: Fix __KERNEL_CS definition of GDT entry on 64-bit configuration

2017-06-06 Thread Kirill A. Shutemov
Define __KERNEL_CS GDT entry as long mode (.L=1, .D=0) on 64-bit
configuration.

Signed-off-by: Kirill A. Shutemov 
Cc: Matt Fleming 
---
 arch/x86/boot/compressed/eboot.c | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 1d5093d1f319..b75c20f779ea 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -1059,8 +1059,13 @@ struct boot_params *efi_main(struct efi_config *c,
desc->p = 1;
desc->limit = 0xf;
desc->avl = 0;
-   desc->l = 0;
-   desc->d = SEG_OP_SIZE_32BIT;
+   if (IS_ENABLED(CONFIG_X86_64)) {
+   desc->l = 1;
+   desc->d = 0;
+   } else {
+   desc->l = 0;
+   desc->d = SEG_OP_SIZE_32BIT;
+   }
desc->g = SEG_GRANULARITY_4KB;
desc->base2 = 0x00;
desc++;
-- 
2.11.0