Re: [RFC 1/6] perf: Remove unused hist_entry__annotate function

[Arnaldo Carvalho de Melo]

Em Fri, Jun 24, 2016 at 05:23:55PM +0530, Ravi Bangoria escreveu:
> hist_entry__annotate looks part of API but I don't find any caller
> of this function. Removing it.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Ravi Bangoria 
> ---
>  tools/perf/util/annotate.c | 5 -
>  tools/perf/util/annotate.h | 2 --
>  2 files changed, 7 deletions(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 7e5a1e8..b2c7ae4 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct 
> map *map,
>   return 0;
>  }
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize)
> -{
> - return symbol__annotate(he->ms.sym, he->ms.map, privsize);
> -}
> -
>  bool ui__has_annotation(void)
>  {
>   return use_browser == 1 && perf_hpp_list.sym;
> diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> index 9241f8c..82f3781 100644
> --- a/tools/perf/util/annotate.h
> +++ b/tools/perf/util/annotate.h
> @@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
>  
>  int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize);
> -
>  int symbol__annotate_init(struct map *map, struct symbol *sym);
>  int symbol__annotate_printf(struct symbol *sym, struct map *map,
>   struct perf_evsel *evsel, bool full_paths,
> -- 
> 2.5.5

Re: [RFC 1/6] perf: Remove unused hist_entry__annotate function

[Arnaldo Carvalho de Melo]

Em Fri, Jun 24, 2016 at 05:23:55PM +0530, Ravi Bangoria escreveu:
> hist_entry__annotate looks part of API but I don't find any caller
> of this function. Removing it.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Ravi Bangoria 
> ---
>  tools/perf/util/annotate.c | 5 -
>  tools/perf/util/annotate.h | 2 --
>  2 files changed, 7 deletions(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 7e5a1e8..b2c7ae4 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct 
> map *map,
>   return 0;
>  }
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize)
> -{
> - return symbol__annotate(he->ms.sym, he->ms.map, privsize);
> -}
> -
>  bool ui__has_annotation(void)
>  {
>   return use_browser == 1 && perf_hpp_list.sym;
> diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> index 9241f8c..82f3781 100644
> --- a/tools/perf/util/annotate.h
> +++ b/tools/perf/util/annotate.h
> @@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
>  
>  int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
>  
> -int hist_entry__annotate(struct hist_entry *he, size_t privsize);
> -
>  int symbol__annotate_init(struct map *map, struct symbol *sym);
>  int symbol__annotate_printf(struct symbol *sym, struct map *map,
>   struct perf_evsel *evsel, bool full_paths,
> -- 
> 2.5.5

[RFC 1/6] perf: Remove unused hist_entry__annotate function

[Ravi Bangoria]

hist_entry__annotate looks part of API but I don't find any caller
of this function. Removing it.

Signed-off-by: Ravi Bangoria 
---
 tools/perf/util/annotate.c | 5 -
 tools/perf/util/annotate.h | 2 --
 2 files changed, 7 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 7e5a1e8..b2c7ae4 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map 
*map,
return 0;
 }
 
-int hist_entry__annotate(struct hist_entry *he, size_t privsize)
-{
-   return symbol__annotate(he->ms.sym, he->ms.map, privsize);
-}
-
 bool ui__has_annotation(void)
 {
return use_browser == 1 && perf_hpp_list.sym;
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 9241f8c..82f3781 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
 
 int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
 
-int hist_entry__annotate(struct hist_entry *he, size_t privsize);
-
 int symbol__annotate_init(struct map *map, struct symbol *sym);
 int symbol__annotate_printf(struct symbol *sym, struct map *map,
struct perf_evsel *evsel, bool full_paths,
-- 
2.5.5

[RFC 1/6] perf: Remove unused hist_entry__annotate function

[Ravi Bangoria]

hist_entry__annotate looks part of API but I don't find any caller
of this function. Removing it.

Signed-off-by: Ravi Bangoria 
---
 tools/perf/util/annotate.c | 5 -
 tools/perf/util/annotate.h | 2 --
 2 files changed, 7 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 7e5a1e8..b2c7ae4 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -1676,11 +1676,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map 
*map,
return 0;
 }
 
-int hist_entry__annotate(struct hist_entry *he, size_t privsize)
-{
-   return symbol__annotate(he->ms.sym, he->ms.map, privsize);
-}
-
 bool ui__has_annotation(void)
 {
return use_browser == 1 && perf_hpp_list.sym;
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 9241f8c..82f3781 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -156,8 +156,6 @@ void symbol__annotate_zero_histograms(struct symbol *sym);
 
 int symbol__annotate(struct symbol *sym, struct map *map, size_t privsize);
 
-int hist_entry__annotate(struct hist_entry *he, size_t privsize);
-
 int symbol__annotate_init(struct map *map, struct symbol *sym);
 int symbol__annotate_printf(struct symbol *sym, struct map *map,
struct perf_evsel *evsel, bool full_paths,
-- 
2.5.5