Re: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Takashi Sakamoto 
(May 29 2014 01:42), Dan Carpenter wrote:
> There was a typo here so we return directly instead of freeing "hwinfo".
> 
> Signed-off-by: Dan Carpenter 

Reviewd-by: Takashi Sakamoto 
Tested-by: Takashi Sakamoto 

> diff --git a/sound/firewire/fireworks/fireworks.c 
> b/sound/firewire/fireworks/fireworks.c
> index 8e856cc..996fdc4 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
>   /* Hardware metering. */
>   if (hwinfo->phys_in_grp_count  > HWINFO_MAX_CAPS_GROUPS ||
>   hwinfo->phys_out_grp_count > HWINFO_MAX_CAPS_GROUPS) {
> - return -EIO;
> + err = -EIO;
>   goto end;
>   }
>   efw->phys_in = hwinfo->phys_in;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Takashi Sakamoto 
(May 29 2014 01:42), Dan Carpenter wrote:
 There was a typo here so we return directly instead of freeing hwinfo.
 
 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Reviewd-by: Takashi Sakamoto o-taka...@sakamocchi.jp
Tested-by: Takashi Sakamoto o-taka...@sakamocchi.jp

 diff --git a/sound/firewire/fireworks/fireworks.c 
 b/sound/firewire/fireworks/fireworks.c
 index 8e856cc..996fdc4 100644
 --- a/sound/firewire/fireworks/fireworks.c
 +++ b/sound/firewire/fireworks/fireworks.c
 @@ -157,7 +157,7 @@ get_hardware_info(struct snd_efw *efw)
   /* Hardware metering. */
   if (hwinfo-phys_in_grp_count   HWINFO_MAX_CAPS_GROUPS ||
   hwinfo-phys_out_grp_count  HWINFO_MAX_CAPS_GROUPS) {
 - return -EIO;
 + err = -EIO;
   goto end;
   }
   efw-phys_in = hwinfo-phys_in;

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/