Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-07-07 Thread Linus Walleij 
On Mon, Jun 23, 2014 at 1:38 PM, Sachin Kamat  wrote:

> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat 

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-07-07 Thread Linus Walleij 
On Mon, Jun 23, 2014 at 1:38 PM, Sachin Kamat sachin.ka...@samsung.com wrote:

 bcm281xx_pinctrl_probe is local to this file. Make it static.

 Signed-off-by: Sachin Kamat sachin.ka...@samsung.com

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat 
Hi Sherman,

On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin  wrote:
> Hi Sachin,
>
> Looks good, thanks.  How did you come across the need for this change?

Thanks for the review. Sparse threw up a warning while doing a regular build.

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sherman Yin 

Hi Sachin,

Looks good, thanks.  How did you come across the need for this change?

Regards,
Sherman

On 14-06-23 04:38 AM, Sachin Kamat wrote:

bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat 
---
  drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c 
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
  };

-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
  {
struct bcm281xx_pinctrl_data *pdata = _pinctrl;
struct resource *res;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat 
bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat 
---
 drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c 
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
 };
 
-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
 {
struct bcm281xx_pinctrl_data *pdata = _pinctrl;
struct resource *res;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sherman Yin 

Hi Sachin,

Looks good, thanks.  How did you come across the need for this change?

Regards,
Sherman

On 14-06-23 04:38 AM, Sachin Kamat wrote:

bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
  drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c 
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
  };

-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
  {
struct bcm281xx_pinctrl_data *pdata = bcm281xx_pinctrl;
struct resource *res;



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat 
Hi Sherman,

On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin s...@broadcom.com wrote:
 Hi Sachin,

 Looks good, thanks.  How did you come across the need for this change?

Thanks for the review. Sparse threw up a warning while doing a regular build.

Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

2014-06-23 Thread Sachin Kamat 
bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
 drivers/pinctrl/pinctrl-bcm281xx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c 
b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
 };
 
-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
 {
struct bcm281xx_pinctrl_data *pdata = bcm281xx_pinctrl;
struct resource *res;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/