Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 16.3.2018 16:18, Rob Herring wrote:
> On Wed, Mar 14, 2018 at 10:04 AM, Michal Simek  wrote:
>> On 12.3.2018 11:21, Michal Simek wrote:
>>> On 12.3.2018 08:52, Alvaro G. M. wrote:
 On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
> wrote:
>> Hi,
>>
>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>> makes microblaze unbootable.
>>
>> I'm sorry I can't provide any console output, as nothing appears at all,
>> even when setting earlyprintk (or at least I wasn't able to get anything
>> back!).
>
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
>
> Rob
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes

 Hi, Rob!

 This branch does indeed solve the issue. My microblaze system is now
 booting as it did before, and everything seems normal now. Thanks!

 Tested-by: Alvaro Gamez Machado 

>>>
>>> I have tested it and I can also confirm that your two patches are fixing
>>> issue with
>>>
>>> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
>>> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
>>> 809d0e4c: 73657479 69616620 2164656c ytes failed!
>>> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
>>> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
>>>
>>> Can you please update that second commit with reasonable description and
>>> send it out? I will take it via my tree and will send pull request to Linus.
>>>
>>
>> I couldn't wait to fix current issue till 4.16 is done that's why I have
>> sent that patches with updated commit message to lkml.
> 
> Thanks for writing my commit msg. :) I got distracted looking at
> whether other arches got broken too and didn't get this sent out.
> 
> BTW, there is a more simple fix of just moving setup_memory() call to
> before unflattening if you prefer for 4.16.

I have sent pull request to Linus with your two patches and a lot of
architectures is setting this up that's why not a problem. I need to
also look at the rest of your patches and how in-kernel dtb is handled
because there is a size limit which was fine for years but we have
reached the case that it is not enough. Simple extension is easy but not
generic solution.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 16.3.2018 16:18, Rob Herring wrote:
> On Wed, Mar 14, 2018 at 10:04 AM, Michal Simek  wrote:
>> On 12.3.2018 11:21, Michal Simek wrote:
>>> On 12.3.2018 08:52, Alvaro G. M. wrote:
 On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
> wrote:
>> Hi,
>>
>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>> makes microblaze unbootable.
>>
>> I'm sorry I can't provide any console output, as nothing appears at all,
>> even when setting earlyprintk (or at least I wasn't able to get anything
>> back!).
>
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
>
> Rob
>
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes

 Hi, Rob!

 This branch does indeed solve the issue. My microblaze system is now
 booting as it did before, and everything seems normal now. Thanks!

 Tested-by: Alvaro Gamez Machado 

>>>
>>> I have tested it and I can also confirm that your two patches are fixing
>>> issue with
>>>
>>> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
>>> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
>>> 809d0e4c: 73657479 69616620 2164656c ytes failed!
>>> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
>>> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
>>>
>>> Can you please update that second commit with reasonable description and
>>> send it out? I will take it via my tree and will send pull request to Linus.
>>>
>>
>> I couldn't wait to fix current issue till 4.16 is done that's why I have
>> sent that patches with updated commit message to lkml.
> 
> Thanks for writing my commit msg. :) I got distracted looking at
> whether other arches got broken too and didn't get this sent out.
> 
> BTW, there is a more simple fix of just moving setup_memory() call to
> before unflattening if you prefer for 4.16.

I have sent pull request to Linus with your two patches and a lot of
architectures is setting this up that's why not a problem. I need to
also look at the rest of your patches and how in-kernel dtb is handled
because there is a size limit which was fine for years but we have
reached the case that it is not enough. Simple extension is easy but not
generic solution.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Rob Herring]

On Wed, Mar 14, 2018 at 10:04 AM, Michal Simek  wrote:
> On 12.3.2018 11:21, Michal Simek wrote:
>> On 12.3.2018 08:52, Alvaro G. M. wrote:
>>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
 On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
 wrote:
> Hi,
>
> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> makes microblaze unbootable.
>
> I'm sorry I can't provide any console output, as nothing appears at all,
> even when setting earlyprintk (or at least I wasn't able to get anything
> back!).

 Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
 memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
 !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
 it can be removed, but I'm still investigating. Can you try out this
 branch[1].

 Rob

 [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
 microblaze-fixes
>>>
>>> Hi, Rob!
>>>
>>> This branch does indeed solve the issue. My microblaze system is now
>>> booting as it did before, and everything seems normal now. Thanks!
>>>
>>> Tested-by: Alvaro Gamez Machado 
>>>
>>
>> I have tested it and I can also confirm that your two patches are fixing
>> issue with
>>
>> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
>> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
>> 809d0e4c: 73657479 69616620 2164656c ytes failed!
>> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
>> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
>>
>> Can you please update that second commit with reasonable description and
>> send it out? I will take it via my tree and will send pull request to Linus.
>>
>
> I couldn't wait to fix current issue till 4.16 is done that's why I have
> sent that patches with updated commit message to lkml.

Thanks for writing my commit msg. :) I got distracted looking at
whether other arches got broken too and didn't get this sent out.

BTW, there is a more simple fix of just moving setup_memory() call to
before unflattening if you prefer for 4.16.

Rob

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Rob Herring]

On Wed, Mar 14, 2018 at 10:04 AM, Michal Simek  wrote:
> On 12.3.2018 11:21, Michal Simek wrote:
>> On 12.3.2018 08:52, Alvaro G. M. wrote:
>>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
 On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
 wrote:
> Hi,
>
> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> makes microblaze unbootable.
>
> I'm sorry I can't provide any console output, as nothing appears at all,
> even when setting earlyprintk (or at least I wasn't able to get anything
> back!).

 Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
 memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
 !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
 it can be removed, but I'm still investigating. Can you try out this
 branch[1].

 Rob

 [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
 microblaze-fixes
>>>
>>> Hi, Rob!
>>>
>>> This branch does indeed solve the issue. My microblaze system is now
>>> booting as it did before, and everything seems normal now. Thanks!
>>>
>>> Tested-by: Alvaro Gamez Machado 
>>>
>>
>> I have tested it and I can also confirm that your two patches are fixing
>> issue with
>>
>> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
>> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
>> 809d0e4c: 73657479 69616620 2164656c ytes failed!
>> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
>> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
>>
>> Can you please update that second commit with reasonable description and
>> send it out? I will take it via my tree and will send pull request to Linus.
>>
>
> I couldn't wait to fix current issue till 4.16 is done that's why I have
> sent that patches with updated commit message to lkml.

Thanks for writing my commit msg. :) I got distracted looking at
whether other arches got broken too and didn't get this sent out.

BTW, there is a more simple fix of just moving setup_memory() call to
before unflattening if you prefer for 4.16.

Rob

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 12.3.2018 11:21, Michal Simek wrote:
> On 12.3.2018 08:52, Alvaro G. M. wrote:
>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
>>> wrote:
 Hi,

 I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
 makes microblaze unbootable.

 I'm sorry I can't provide any console output, as nothing appears at all,
 even when setting earlyprintk (or at least I wasn't able to get anything
 back!).
>>>
>>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>>> it can be removed, but I'm still investigating. Can you try out this
>>> branch[1].
>>>
>>> Rob
>>>
>>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>>> microblaze-fixes
>>
>> Hi, Rob!
>>
>> This branch does indeed solve the issue. My microblaze system is now
>> booting as it did before, and everything seems normal now. Thanks!
>>
>> Tested-by: Alvaro Gamez Machado 
>>
> 
> I have tested it and I can also confirm that your two patches are fixing
> issue with
> 
> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
> 809d0e4c: 73657479 69616620 2164656c ytes failed!
> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
> 
> Can you please update that second commit with reasonable description and
> send it out? I will take it via my tree and will send pull request to Linus.
> 

I couldn't wait to fix current issue till 4.16 is done that's why I have
sent that patches with updated commit message to lkml.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 12.3.2018 11:21, Michal Simek wrote:
> On 12.3.2018 08:52, Alvaro G. M. wrote:
>> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  
>>> wrote:
 Hi,

 I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
 makes microblaze unbootable.

 I'm sorry I can't provide any console output, as nothing appears at all,
 even when setting earlyprintk (or at least I wasn't able to get anything
 back!).
>>>
>>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>>> it can be removed, but I'm still investigating. Can you try out this
>>> branch[1].
>>>
>>> Rob
>>>
>>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>>> microblaze-fixes
>>
>> Hi, Rob!
>>
>> This branch does indeed solve the issue. My microblaze system is now
>> booting as it did before, and everything seems normal now. Thanks!
>>
>> Tested-by: Alvaro Gamez Machado 
>>
> 
> I have tested it and I can also confirm that your two patches are fixing
> issue with
> 
> 809d0e2c: 00240034 2600 746f6f62 206d656d4.$
> 809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
> 809d0e4c: 73657479 69616620 2164656c ytes failed!
> 809d0e5c:  0029003c 0600 6e72654b<.).Kern
> 809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s
> 
> Can you please update that second commit with reasonable description and
> send it out? I will take it via my tree and will send pull request to Linus.
> 

I couldn't wait to fix current issue till 4.16 is done that's why I have
sent that patches with updated commit message to lkml.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 12.3.2018 08:52, Alvaro G. M. wrote:
> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
>>> Hi,
>>>
>>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>>> makes microblaze unbootable.
>>>
>>> I'm sorry I can't provide any console output, as nothing appears at all,
>>> even when setting earlyprintk (or at least I wasn't able to get anything
>>> back!).
>>
>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>> it can be removed, but I'm still investigating. Can you try out this
>> branch[1].
>>
>> Rob
>>
>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>> microblaze-fixes
> 
> Hi, Rob!
> 
> This branch does indeed solve the issue. My microblaze system is now
> booting as it did before, and everything seems normal now. Thanks!
> 
> Tested-by: Alvaro Gamez Machado 
> 

I have tested it and I can also confirm that your two patches are fixing
issue with

809d0e2c: 00240034 2600 746f6f62 206d656d4.$
809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
809d0e4c: 73657479 69616620 2164656c ytes failed!
809d0e5c:  0029003c 0600 6e72654b<.).Kern
809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s

Can you please update that second commit with reasonable description and
send it out? I will take it via my tree and will send pull request to Linus.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 12.3.2018 08:52, Alvaro G. M. wrote:
> On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
>> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
>>> Hi,
>>>
>>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>>> makes microblaze unbootable.
>>>
>>> I'm sorry I can't provide any console output, as nothing appears at all,
>>> even when setting earlyprintk (or at least I wasn't able to get anything
>>> back!).
>>
>> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
>> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
>> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
>> it can be removed, but I'm still investigating. Can you try out this
>> branch[1].
>>
>> Rob
>>
>> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>> microblaze-fixes
> 
> Hi, Rob!
> 
> This branch does indeed solve the issue. My microblaze system is now
> booting as it did before, and everything seems normal now. Thanks!
> 
> Tested-by: Alvaro Gamez Machado 
> 

I have tested it and I can also confirm that your two patches are fixing
issue with

809d0e2c: 00240034 2600 746f6f62 206d656d4.$
809d0e3c: 6f6c6c61 666f2063 33353220 62203830alloc of 25308 b
809d0e4c: 73657479 69616620 2164656c ytes failed!
809d0e5c:  0029003c 0600 6e72654b<.).Kern
809d0e6c: 70206c65 63696e61 6e202d20 7320746fel panic - not s

Can you please update that second commit with reasonable description and
send it out? I will take it via my tree and will send pull request to Linus.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Alvaro G. M.]

On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
> > Hi,
> >
> > I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> > makes microblaze unbootable.
> >
> > I'm sorry I can't provide any console output, as nothing appears at all,
> > even when setting earlyprintk (or at least I wasn't able to get anything
> > back!).
> 
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
> 
> Rob
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes

Hi, Rob!

This branch does indeed solve the issue. My microblaze system is now
booting as it did before, and everything seems normal now. Thanks!

Tested-by: Alvaro Gamez Machado 


-- 
Alvaro G. M.

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Alvaro G. M.]

On Fri, Mar 09, 2018 at 01:05:11PM -0600, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
> > Hi,
> >
> > I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> > makes microblaze unbootable.
> >
> > I'm sorry I can't provide any console output, as nothing appears at all,
> > even when setting earlyprintk (or at least I wasn't able to get anything
> > back!).
> 
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
> 
> Rob
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes

Hi, Rob!

This branch does indeed solve the issue. My microblaze system is now
booting as it did before, and everything seems normal now. Thanks!

Tested-by: Alvaro Gamez Machado 


-- 
Alvaro G. M.

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 9.3.2018 20:05, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
>> Hi,
>>
>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>> makes microblaze unbootable.
>>
>> I'm sorry I can't provide any console output, as nothing appears at all,
>> even when setting earlyprintk (or at least I wasn't able to get anything
>> back!).
> 
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
> 
> Rob
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes
> 

Let me take a look at it on Monday with the rest of patches sent by you.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Michal Simek]

On 9.3.2018 20:05, Rob Herring wrote:
> On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
>> Hi,
>>
>> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
>> makes microblaze unbootable.
>>
>> I'm sorry I can't provide any console output, as nothing appears at all,
>> even when setting earlyprintk (or at least I wasn't able to get anything
>> back!).
> 
> Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
> memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
> !CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
> it can be removed, but I'm still investigating. Can you try out this
> branch[1].
> 
> Rob
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> microblaze-fixes
> 

Let me take a look at it on Monday with the rest of patches sent by you.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs




signature.asc
Description: OpenPGP digital signature

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Rob Herring]

On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
> Hi,
>
> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> makes microblaze unbootable.
>
> I'm sorry I can't provide any console output, as nothing appears at all,
> even when setting earlyprintk (or at least I wasn't able to get anything
> back!).

Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
!CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
it can be removed, but I'm still investigating. Can you try out this
branch[1].

Rob

[1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
microblaze-fixes

Re: Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Rob Herring]

On Fri, Mar 9, 2018 at 6:51 AM, Alvaro G. M.  wrote:
> Hi,
>
> I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
> makes microblaze unbootable.
>
> I'm sorry I can't provide any console output, as nothing appears at all,
> even when setting earlyprintk (or at least I wasn't able to get anything
> back!).

Ah, looks like microblaze doesn't set CONFIG_NO_BOOTMEM and so
memblock_virt_alloc() doesn't work for CONFIG_HAVE_MEMBLOCK &&
!CONFIG_NO_BOOTMEM. AFAICT, microblaze doesn't really need bootmem and
it can be removed, but I'm still investigating. Can you try out this
branch[1].

Rob

[1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
microblaze-fixes

Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Alvaro G. M.]

Hi,

I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
makes microblaze unbootable.

I'm sorry I can't provide any console output, as nothing appears at all,
even when setting earlyprintk (or at least I wasn't able to get anything
back!).

I'm providing both dts and defconfig in case it helps.

Best regards

CONFIG_SYSVIPC=y
CONFIG_POSIX_MQUEUE=y
CONFIG_FHANDLE=y
CONFIG_LOG_BUF_SHIFT=16
CONFIG_BLK_DEV_INITRD=y
CONFIG_EMBEDDED=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_KERNEL_BASE_ADDR=0x8000
CONFIG_XILINX_MICROBLAZE0_FAMILY="artix7"
CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR=1
CONFIG_XILINX_MICROBLAZE0_USE_PCMP_INSTR=1
CONFIG_XILINX_MICROBLAZE0_USE_BARREL=1
CONFIG_XILINX_MICROBLAZE0_USE_DIV=1
CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL=2
CONFIG_HZ_100=y
CONFIG_MMU=y
CONFIG_CMDLINE_BOOL=y
CONFIG_CMDLINE="console=ttyUL0,9600"
CONFIG_HIGHMEM=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
CONFIG_MTD=y
CONFIG_MTD_TESTS=m
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_M25P80=y
CONFIG_MTD_SPI_NOR=y
CONFIG_NETDEVICES=y
CONFIG_XILINX_EMACLITE=y
CONFIG_DP83848_PHY=y
CONFIG_DP83620_PHY=y
CONFIG_SERIAL_UARTLITE=y
CONFIG_SERIAL_UARTLITE_CONSOLE=y
CONFIG_I2C=y
CONFIG_I2C_CHARDEV=y
CONFIG_I2C_XILINX=y
CONFIG_SPI=y
CONFIG_SPI_XILINX=y
CONFIG_SPI_SPIDEV=y
CONFIG_GPIOLIB=y
CONFIG_GPIO_SYSFS=y
CONFIG_GPIO_XILINX=y
CONFIG_SENSORS_IIO_HWMON=y
CONFIG_REGULATOR=y
CONFIG_REGULATOR_FIXED_VOLTAGE=y
CONFIG_FB=y
CONFIG_FB_XILINX=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_GPIO=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_ONESHOT=y
CONFIG_LEDS_TRIGGER_HEARTBEAT=y
CONFIG_LEDS_TRIGGER_BACKLIGHT=y
CONFIG_LEDS_TRIGGER_CPU=y
CONFIG_LEDS_TRIGGER_GPIO=y
CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
CONFIG_LEDS_TRIGGER_TRANSIENT=y
CONFIG_LEDS_TRIGGER_CAMERA=y
CONFIG_UIO=y
CONFIG_UIO_PDRV_GENIRQ=y
CONFIG_IIO=y
CONFIG_AD799X=y
CONFIG_XILINX_XADC=y
CONFIG_PWM=y
CONFIG_JFFS2_FS=y
CONFIG_SQUASHFS=y
CONFIG_SQUASHFS_LZ4=y
CONFIG_SQUASHFS_4K_DEVBLK_SIZE=y
CONFIG_ROMFS_FS=y
CONFIG_ROMFS_BACKED_BY_BOTH=y
CONFIG_NFS_FS=y
CONFIG_ROOT_NFS=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_SLAB=y
CONFIG_DETECT_HUNG_TASK=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_EARLY_PRINTK=y
CONFIG_CRYPTO_MANAGER=y

/dts-v1/;
/ {
#address-cells = <1>;
#size-cells = <1>;
compatible = "xlnx,microblaze";
model = "Xilinx MicroBlaze";
cpus {
#address-cells = <1>;
#cpus = <1>;
#size-cells = <0>;
microblaze_0: cpu@0 {
bus-handle = <_pl>;
clock-frequency = <8325>;
clocks = <_cpu>;
compatible = "xlnx,microblaze-9.5";
d-cache-baseaddr = <0x8000>;
d-cache-highaddr = <0x8fff>;
d-cache-line-size = <0x10>;
d-cache-size = <0x8000>;
device_type = "cpu";
i-cache-baseaddr = <0x8000>;
i-cache-highaddr = <0x8fff>;
i-cache-line-size = <0x20>;
i-cache-size = <0x8000>;
interrupt-handle = <_0_axi_intc>;
model = "microblaze,9.5";
timebase-frequency = <8325>;
xlnx,addr-tag-bits = <0xd>;
xlnx,allow-dcache-wr = <0x1>;
xlnx,allow-icache-wr = <0x1>;
xlnx,area-optimized = <0x0>;
xlnx,async-interrupt = <0x1>;
xlnx,avoid-primitives = <0x0>;
xlnx,base-vectors = <0x>;
xlnx,branch-target-cache-size = <0x0>;
xlnx,cache-byte-size = <0x8000>;
xlnx,d-axi = <0x1>;
xlnx,d-lmb = <0x1>;
xlnx,d-lmb-mon = <0x0>;
xlnx,data-size = <0x20>;
xlnx,dc-axi-mon = <0x0>;
xlnx,dcache-addr-tag = <0xd>;
xlnx,dcache-always-used = <0x1>;
xlnx,dcache-byte-size = <0x8000>;
xlnx,dcache-data-width = <0x0>;
xlnx,dcache-force-tag-lutram = <0x0>;
xlnx,dcache-line-len = <0x4>;
xlnx,dcache-use-writeback = <0x0>;
xlnx,dcache-victims = <0x8>;
xlnx,debug-counter-width = <0x20>;
xlnx,debug-enabled = <0x1>;
xlnx,debug-event-counters = <0x5>;
xlnx,debug-external-trace = <0x0>;
xlnx,debug-latency-counters = <0x1>;
xlnx,debug-profile-size = 

Bug: Microblaze stopped booting after 0fa1c579349fdd90173381712ad78aa99c09d38b

[Alvaro G. M.]

Hi,

I've found via git bisect that 0fa1c579349fdd90173381712ad78aa99c09d38b
makes microblaze unbootable.

I'm sorry I can't provide any console output, as nothing appears at all,
even when setting earlyprintk (or at least I wasn't able to get anything
back!).

I'm providing both dts and defconfig in case it helps.

Best regards

CONFIG_SYSVIPC=y
CONFIG_POSIX_MQUEUE=y
CONFIG_FHANDLE=y
CONFIG_LOG_BUF_SHIFT=16
CONFIG_BLK_DEV_INITRD=y
CONFIG_EMBEDDED=y
CONFIG_SLAB=y
CONFIG_MODULES=y
CONFIG_KERNEL_BASE_ADDR=0x8000
CONFIG_XILINX_MICROBLAZE0_FAMILY="artix7"
CONFIG_XILINX_MICROBLAZE0_USE_MSR_INSTR=1
CONFIG_XILINX_MICROBLAZE0_USE_PCMP_INSTR=1
CONFIG_XILINX_MICROBLAZE0_USE_BARREL=1
CONFIG_XILINX_MICROBLAZE0_USE_DIV=1
CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL=2
CONFIG_HZ_100=y
CONFIG_MMU=y
CONFIG_CMDLINE_BOOL=y
CONFIG_CMDLINE="console=ttyUL0,9600"
CONFIG_HIGHMEM=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
CONFIG_IP_PNP=y
CONFIG_IP_PNP_DHCP=y
CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
CONFIG_MTD=y
CONFIG_MTD_TESTS=m
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_M25P80=y
CONFIG_MTD_SPI_NOR=y
CONFIG_NETDEVICES=y
CONFIG_XILINX_EMACLITE=y
CONFIG_DP83848_PHY=y
CONFIG_DP83620_PHY=y
CONFIG_SERIAL_UARTLITE=y
CONFIG_SERIAL_UARTLITE_CONSOLE=y
CONFIG_I2C=y
CONFIG_I2C_CHARDEV=y
CONFIG_I2C_XILINX=y
CONFIG_SPI=y
CONFIG_SPI_XILINX=y
CONFIG_SPI_SPIDEV=y
CONFIG_GPIOLIB=y
CONFIG_GPIO_SYSFS=y
CONFIG_GPIO_XILINX=y
CONFIG_SENSORS_IIO_HWMON=y
CONFIG_REGULATOR=y
CONFIG_REGULATOR_FIXED_VOLTAGE=y
CONFIG_FB=y
CONFIG_FB_XILINX=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_GPIO=y
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=y
CONFIG_LEDS_TRIGGER_ONESHOT=y
CONFIG_LEDS_TRIGGER_HEARTBEAT=y
CONFIG_LEDS_TRIGGER_BACKLIGHT=y
CONFIG_LEDS_TRIGGER_CPU=y
CONFIG_LEDS_TRIGGER_GPIO=y
CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
CONFIG_LEDS_TRIGGER_TRANSIENT=y
CONFIG_LEDS_TRIGGER_CAMERA=y
CONFIG_UIO=y
CONFIG_UIO_PDRV_GENIRQ=y
CONFIG_IIO=y
CONFIG_AD799X=y
CONFIG_XILINX_XADC=y
CONFIG_PWM=y
CONFIG_JFFS2_FS=y
CONFIG_SQUASHFS=y
CONFIG_SQUASHFS_LZ4=y
CONFIG_SQUASHFS_4K_DEVBLK_SIZE=y
CONFIG_ROMFS_FS=y
CONFIG_ROMFS_BACKED_BY_BOTH=y
CONFIG_NFS_FS=y
CONFIG_ROOT_NFS=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_SLAB=y
CONFIG_DETECT_HUNG_TASK=y
CONFIG_DEBUG_SPINLOCK=y
CONFIG_EARLY_PRINTK=y
CONFIG_CRYPTO_MANAGER=y

/dts-v1/;
/ {
#address-cells = <1>;
#size-cells = <1>;
compatible = "xlnx,microblaze";
model = "Xilinx MicroBlaze";
cpus {
#address-cells = <1>;
#cpus = <1>;
#size-cells = <0>;
microblaze_0: cpu@0 {
bus-handle = <_pl>;
clock-frequency = <8325>;
clocks = <_cpu>;
compatible = "xlnx,microblaze-9.5";
d-cache-baseaddr = <0x8000>;
d-cache-highaddr = <0x8fff>;
d-cache-line-size = <0x10>;
d-cache-size = <0x8000>;
device_type = "cpu";
i-cache-baseaddr = <0x8000>;
i-cache-highaddr = <0x8fff>;
i-cache-line-size = <0x20>;
i-cache-size = <0x8000>;
interrupt-handle = <_0_axi_intc>;
model = "microblaze,9.5";
timebase-frequency = <8325>;
xlnx,addr-tag-bits = <0xd>;
xlnx,allow-dcache-wr = <0x1>;
xlnx,allow-icache-wr = <0x1>;
xlnx,area-optimized = <0x0>;
xlnx,async-interrupt = <0x1>;
xlnx,avoid-primitives = <0x0>;
xlnx,base-vectors = <0x>;
xlnx,branch-target-cache-size = <0x0>;
xlnx,cache-byte-size = <0x8000>;
xlnx,d-axi = <0x1>;
xlnx,d-lmb = <0x1>;
xlnx,d-lmb-mon = <0x0>;
xlnx,data-size = <0x20>;
xlnx,dc-axi-mon = <0x0>;
xlnx,dcache-addr-tag = <0xd>;
xlnx,dcache-always-used = <0x1>;
xlnx,dcache-byte-size = <0x8000>;
xlnx,dcache-data-width = <0x0>;
xlnx,dcache-force-tag-lutram = <0x0>;
xlnx,dcache-line-len = <0x4>;
xlnx,dcache-use-writeback = <0x0>;
xlnx,dcache-victims = <0x8>;
xlnx,debug-counter-width = <0x20>;
xlnx,debug-enabled = <0x1>;
xlnx,debug-event-counters = <0x5>;
xlnx,debug-external-trace = <0x0>;
xlnx,debug-latency-counters = <0x1>;
xlnx,debug-profile-size =