Re: [PATCH rdma-next] RDMA/qedr: remove set but not used variable 'ctx'
On Sat, Sep 01, 2018 at 03:53:46AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_create_srq': > drivers/infiniband/hw/qedr/verbs.c:1450:24: warning: > variable 'ctx' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing > Acked-by: Rahul Verma > --- > drivers/infiniband/hw/qedr/verbs.c | 2 -- > 1 file changed, 2 deletions(-) Applied to for-next, thanks Jason
Re: [PATCH rdma-next] RDMA/qedr: remove set but not used variable 'ctx'
On Sat, Sep 01, 2018 at 03:53:46AM +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_create_srq': > drivers/infiniband/hw/qedr/verbs.c:1450:24: warning: > variable 'ctx' set but not used [-Wunused-but-set-variable] > > Signed-off-by: YueHaibing > Acked-by: Rahul Verma > --- > drivers/infiniband/hw/qedr/verbs.c | 2 -- > 1 file changed, 2 deletions(-) Applied to for-next, thanks Jason
RE: [PATCH rdma-next] RDMA/qedr: remove set but not used variable 'ctx'
> -Original Message-
> From: YueHaibing
> Sent: Saturday, September 1, 2018 6:54 AM
> To: Kalderon, Michal ; Elior, Ariel
> ; Doug Ledford ; Jason
> Gunthorpe
> Cc: YueHaibing ; linux-r...@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel-janit...@vger.kernel.org
> Subject: [PATCH rdma-next] RDMA/qedr: remove set but not used variable
> 'ctx'
>
> External Email
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_create_srq':
> drivers/infiniband/hw/qedr/verbs.c:1450:24: warning:
> variable 'ctx' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing
> ---
> drivers/infiniband/hw/qedr/verbs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 8cc3df2..9d4d165 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -1447,7 +1447,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
> u64 pbl_base_addr, phy_prod_pair_addr;
> struct ib_ucontext *ib_ctx = NULL;
> struct qedr_srq_hwq_info *hw_srq;
> - struct qedr_ucontext *ctx = NULL;
> u32 page_cnt, page_size;
> struct qedr_srq *srq;
> int rc = 0;
> @@ -1473,7 +1472,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
>
> if (udata && ibpd->uobject && ibpd->uobject->context) {
> ib_ctx = ibpd->uobject->context;
> - ctx = get_qedr_ucontext(ib_ctx);
>
> if (ib_copy_from_udata(, udata, sizeof(ureq))) {
> DP_ERR(dev,
Thank Yue.
Acked-by: Rahul Verma
RE: [PATCH rdma-next] RDMA/qedr: remove set but not used variable 'ctx'
> -Original Message-
> From: YueHaibing
> Sent: Saturday, September 1, 2018 6:54 AM
> To: Kalderon, Michal ; Elior, Ariel
> ; Doug Ledford ; Jason
> Gunthorpe
> Cc: YueHaibing ; linux-r...@vger.kernel.org;
> linux-kernel@vger.kernel.org; kernel-janit...@vger.kernel.org
> Subject: [PATCH rdma-next] RDMA/qedr: remove set but not used variable
> 'ctx'
>
> External Email
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/infiniband/hw/qedr/verbs.c: In function 'qedr_create_srq':
> drivers/infiniband/hw/qedr/verbs.c:1450:24: warning:
> variable 'ctx' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing
> ---
> drivers/infiniband/hw/qedr/verbs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/verbs.c
> b/drivers/infiniband/hw/qedr/verbs.c
> index 8cc3df2..9d4d165 100644
> --- a/drivers/infiniband/hw/qedr/verbs.c
> +++ b/drivers/infiniband/hw/qedr/verbs.c
> @@ -1447,7 +1447,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
> u64 pbl_base_addr, phy_prod_pair_addr;
> struct ib_ucontext *ib_ctx = NULL;
> struct qedr_srq_hwq_info *hw_srq;
> - struct qedr_ucontext *ctx = NULL;
> u32 page_cnt, page_size;
> struct qedr_srq *srq;
> int rc = 0;
> @@ -1473,7 +1472,6 @@ struct ib_srq *qedr_create_srq(struct ib_pd
> *ibpd,
>
> if (udata && ibpd->uobject && ibpd->uobject->context) {
> ib_ctx = ibpd->uobject->context;
> - ctx = get_qedr_ucontext(ib_ctx);
>
> if (ib_copy_from_udata(, udata, sizeof(ureq))) {
> DP_ERR(dev,
Thank Yue.
Acked-by: Rahul Verma
