RE: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings
Hi Leo,
Thanks a lot for your comments!
> -Original Message-
> From: Li Yang
> Sent: 2018年10月27日 4:58
> To: Z.q. Hou
> Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> ; lkml ;
> linux-...@vger.kernel.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS ; Rob Herring
> ; Shawn Guo ; Mark Rutland
> ; Bjorn Helgaas ; Mingkai
> Hu ; M.h. Lian
> Subject: Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller
> compatible strings
>
> On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou wrote:
>
> The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
> ...", and it should be better to mention the string removed in the title too.
Will correct it in v3.
>
> >
> > From: Hou Zhiqiang
> >
> > Removed the wrong compatible string "snps,dw-pcie", in case match
> > incorrect driver.
> >
> > Signed-off-by: Hou Zhiqiang
> > ---
> > V2:
> > - no change
> >
> > arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index bdd6e66a79ad..1aaa3288a450
> > 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -716,7 +716,7 @@
> > };
> >
> > pcie@340 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x0340 0x0 0x0001
> /* controller registers */
> >0x40 0x 0x0 0x2000>;
> /* configuration space */
> > reg-names = "regs", "config"; @@ -739,7
> +739,7
> > @@
> > };
> >
> > pcie@350 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x0350 0x0 0x0001
> /* controller registers */
> >0x48 0x 0x0 0x2000>;
> /* configuration space */
> > reg-names = "regs", "config";
> > --
> > 2.17.1
> >
Thanks,
Zhiqiang
RE: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings
Hi Leo,
Thanks a lot for your comments!
> -Original Message-
> From: Li Yang
> Sent: 2018年10月27日 4:58
> To: Z.q. Hou
> Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> ; lkml ;
> linux-...@vger.kernel.org; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS ; Rob Herring
> ; Shawn Guo ; Mark Rutland
> ; Bjorn Helgaas ; Mingkai
> Hu ; M.h. Lian
> Subject: Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller
> compatible strings
>
> On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou wrote:
>
> The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
> ...", and it should be better to mention the string removed in the title too.
Will correct it in v3.
>
> >
> > From: Hou Zhiqiang
> >
> > Removed the wrong compatible string "snps,dw-pcie", in case match
> > incorrect driver.
> >
> > Signed-off-by: Hou Zhiqiang
> > ---
> > V2:
> > - no change
> >
> > arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index bdd6e66a79ad..1aaa3288a450
> > 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -716,7 +716,7 @@
> > };
> >
> > pcie@340 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x0340 0x0 0x0001
> /* controller registers */
> >0x40 0x 0x0 0x2000>;
> /* configuration space */
> > reg-names = "regs", "config"; @@ -739,7
> +739,7
> > @@
> > };
> >
> > pcie@350 {
> > - compatible = "fsl,ls1021a-pcie",
> "snps,dw-pcie";
> > + compatible = "fsl,ls1021a-pcie";
> > reg = <0x00 0x0350 0x0 0x0001
> /* controller registers */
> >0x48 0x 0x0 0x2000>;
> /* configuration space */
> > reg-names = "regs", "config";
> > --
> > 2.17.1
> >
Thanks,
Zhiqiang
Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings
On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou wrote:
The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
...", and it should be better to mention the string removed in the
title too.
>
> From: Hou Zhiqiang
>
> Removed the wrong compatible string "snps,dw-pcie", in case
> match incorrect driver.
>
> Signed-off-by: Hou Zhiqiang
> ---
> V2:
> - no change
>
> arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index bdd6e66a79ad..1aaa3288a450 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -716,7 +716,7 @@
> };
>
> pcie@340 {
> - compatible = "fsl,ls1021a-pcie", "snps,dw-pcie";
> + compatible = "fsl,ls1021a-pcie";
> reg = <0x00 0x0340 0x0 0x0001 /* controller
> registers */
>0x40 0x 0x0 0x2000>; /*
> configuration space */
> reg-names = "regs", "config";
> @@ -739,7 +739,7 @@
> };
>
> pcie@350 {
> - compatible = "fsl,ls1021a-pcie", "snps,dw-pcie";
> + compatible = "fsl,ls1021a-pcie";
> reg = <0x00 0x0350 0x0 0x0001 /* controller
> registers */
>0x48 0x 0x0 0x2000>; /*
> configuration space */
> reg-names = "regs", "config";
> --
> 2.17.1
>
Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings
On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou wrote:
The correct prefix for arm dts patches should be: "ARM: dts: ls1021a:
...", and it should be better to mention the string removed in the
title too.
>
> From: Hou Zhiqiang
>
> Removed the wrong compatible string "snps,dw-pcie", in case
> match incorrect driver.
>
> Signed-off-by: Hou Zhiqiang
> ---
> V2:
> - no change
>
> arch/arm/boot/dts/ls1021a.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index bdd6e66a79ad..1aaa3288a450 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -716,7 +716,7 @@
> };
>
> pcie@340 {
> - compatible = "fsl,ls1021a-pcie", "snps,dw-pcie";
> + compatible = "fsl,ls1021a-pcie";
> reg = <0x00 0x0340 0x0 0x0001 /* controller
> registers */
>0x40 0x 0x0 0x2000>; /*
> configuration space */
> reg-names = "regs", "config";
> @@ -739,7 +739,7 @@
> };
>
> pcie@350 {
> - compatible = "fsl,ls1021a-pcie", "snps,dw-pcie";
> + compatible = "fsl,ls1021a-pcie";
> reg = <0x00 0x0350 0x0 0x0001 /* controller
> registers */
>0x48 0x 0x0 0x2000>; /*
> configuration space */
> reg-names = "regs", "config";
> --
> 2.17.1
>
