RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael, Andy,

Just pinging to see if there are updates on ACPI / PMIC opregion patch...

Thanks
Raj

> -Original Message-
> From: Mani, Rajmohan
> Sent: Thursday, September 07, 2017 5:46 PM
> To: 'Rafael J. Wysocki' <raf...@kernel.org>
> Cc: 'Rafael J. Wysocki' <r...@rjwysocki.net>; 'Andy Shevchenko'
> <andy.shevche...@gmail.com>; 'linux-kernel@vger.kernel.org'  ker...@vger.kernel.org>; 'linux-g...@vger.kernel.org'  g...@vger.kernel.org>; 'linux-a...@vger.kernel.org'  a...@vger.kernel.org>; 'Lee Jones' <lee.jo...@linaro.org>; 'Linus Walleij'
> <linus.wall...@linaro.org>; 'Alexandre Courbot' <gnu...@gmail.com>; 'Len
> Brown' <l...@kernel.org>; 'sakari.ai...@linux.intel.com'
> <sakari.ai...@linux.intel.com>
> Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> 
> Hi Rafael,
> 
> > Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> >
> > Hi Rafael,
> >
> > > >> > >> > This is the patch series for TPS68470 PMIC that works as a
> > > >> > >> > camera
> > > PMIC.
> > > >> > >> >
> > > >> > >> > The patch series provide the following 3 drivers, to help
> > > >> > >> > configure the
> > > >> voltage regulators, clocks and GPIOs provided by the TPS68470
> > > >> PMIC, to be able to use the camera sensors connected to this PMIC.
> > > >> > >> >
> > > >> > >> > TPS68470 MFD driver:
> > > >> > >> > This is the multi function driver that initializes the
> > > >> > >> > TPS68470 PMIC and
> > > >> supports the GPIO and Op Region functions.
> > > >> > >> >
> > > >> > >> > TPS68470 GPIO driver:
> > > >> > >> > This is the PMIC GPIO driver that will be used by the OS
> > > >> > >> > GPIO layer,
> > > >> when the BIOS / firmware triggered GPIO access is done.
> > > >> > >> >
> > > >> > >> > TPS68470 Op Region driver:
> > > >> > >> > This is the driver that will be invoked, when the BIOS /
> > > >> > >> > firmware
> > > >> configures the voltage / clock for the sensors / vcm devices
> > > >> connected to the PMIC.
> > > >> > >> >
> > > >> > >>
> > > >> > >> All three patches are good to me (we did few rounds of
> > > >> > >> internal review before posting v4)
> > > >> > >>
> > > >> > >> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
> > > >> > >
> > > >> > > OK, so how should they be routed?
> > > >> >
> > > >> > Good question. I don't know how last time PMIC drivers were
> > > >> > merged, here I think is just sane to route vi MFD with
> > > >> > immutable branch created.
> > > >>
> > > >> OK
> > > >>
> > > >> I will assume that the series will go in through MFD then.
> > > >>
> > > >
> > > > Now that the MFD and GPIO patches of v6 of this series have been
> > > > applied
> > > on respective trees, can you advise the next steps for the ACPI /
> > > PMIC Opregion driver?
> > >
> > > Well, it would have been better to route the whole series through one
> tree.
> > > Now it's better to wait until the two other trees get merged and
> > > then apply the opregion patch.
> > >
> >
> > Ack.
> > Let me get back once the other 2 trees are merged.
> >
> 
> Both MFD and GPIO patches of this series got merged upstream as of today.
> 
> Thanks
> Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael, Andy,

Just pinging to see if there are updates on ACPI / PMIC opregion patch...

Thanks
Raj

> -Original Message-
> From: Mani, Rajmohan
> Sent: Thursday, September 07, 2017 5:46 PM
> To: 'Rafael J. Wysocki' 
> Cc: 'Rafael J. Wysocki' ; 'Andy Shevchenko'
> ; 'linux-kernel@vger.kernel.org'  ker...@vger.kernel.org>; 'linux-g...@vger.kernel.org'  g...@vger.kernel.org>; 'linux-a...@vger.kernel.org'  a...@vger.kernel.org>; 'Lee Jones' ; 'Linus Walleij'
> ; 'Alexandre Courbot' ; 'Len
> Brown' ; 'sakari.ai...@linux.intel.com'
> 
> Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> 
> Hi Rafael,
> 
> > Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> >
> > Hi Rafael,
> >
> > > >> > >> > This is the patch series for TPS68470 PMIC that works as a
> > > >> > >> > camera
> > > PMIC.
> > > >> > >> >
> > > >> > >> > The patch series provide the following 3 drivers, to help
> > > >> > >> > configure the
> > > >> voltage regulators, clocks and GPIOs provided by the TPS68470
> > > >> PMIC, to be able to use the camera sensors connected to this PMIC.
> > > >> > >> >
> > > >> > >> > TPS68470 MFD driver:
> > > >> > >> > This is the multi function driver that initializes the
> > > >> > >> > TPS68470 PMIC and
> > > >> supports the GPIO and Op Region functions.
> > > >> > >> >
> > > >> > >> > TPS68470 GPIO driver:
> > > >> > >> > This is the PMIC GPIO driver that will be used by the OS
> > > >> > >> > GPIO layer,
> > > >> when the BIOS / firmware triggered GPIO access is done.
> > > >> > >> >
> > > >> > >> > TPS68470 Op Region driver:
> > > >> > >> > This is the driver that will be invoked, when the BIOS /
> > > >> > >> > firmware
> > > >> configures the voltage / clock for the sensors / vcm devices
> > > >> connected to the PMIC.
> > > >> > >> >
> > > >> > >>
> > > >> > >> All three patches are good to me (we did few rounds of
> > > >> > >> internal review before posting v4)
> > > >> > >>
> > > >> > >> Reviewed-by: Andy Shevchenko 
> > > >> > >
> > > >> > > OK, so how should they be routed?
> > > >> >
> > > >> > Good question. I don't know how last time PMIC drivers were
> > > >> > merged, here I think is just sane to route vi MFD with
> > > >> > immutable branch created.
> > > >>
> > > >> OK
> > > >>
> > > >> I will assume that the series will go in through MFD then.
> > > >>
> > > >
> > > > Now that the MFD and GPIO patches of v6 of this series have been
> > > > applied
> > > on respective trees, can you advise the next steps for the ACPI /
> > > PMIC Opregion driver?
> > >
> > > Well, it would have been better to route the whole series through one
> tree.
> > > Now it's better to wait until the two other trees get merged and
> > > then apply the opregion patch.
> > >
> >
> > Ack.
> > Let me get back once the other 2 trees are merged.
> >
> 
> Both MFD and GPIO patches of this series got merged upstream as of today.
> 
> Thanks
> Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael,

> Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> 
> Hi Rafael,
> 
> > >> > >> > This is the patch series for TPS68470 PMIC that works as a
> > >> > >> > camera
> > PMIC.
> > >> > >> >
> > >> > >> > The patch series provide the following 3 drivers, to help
> > >> > >> > configure the
> > >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC,
> > >> to be able to use the camera sensors connected to this PMIC.
> > >> > >> >
> > >> > >> > TPS68470 MFD driver:
> > >> > >> > This is the multi function driver that initializes the
> > >> > >> > TPS68470 PMIC and
> > >> supports the GPIO and Op Region functions.
> > >> > >> >
> > >> > >> > TPS68470 GPIO driver:
> > >> > >> > This is the PMIC GPIO driver that will be used by the OS
> > >> > >> > GPIO layer,
> > >> when the BIOS / firmware triggered GPIO access is done.
> > >> > >> >
> > >> > >> > TPS68470 Op Region driver:
> > >> > >> > This is the driver that will be invoked, when the BIOS /
> > >> > >> > firmware
> > >> configures the voltage / clock for the sensors / vcm devices
> > >> connected to the PMIC.
> > >> > >> >
> > >> > >>
> > >> > >> All three patches are good to me (we did few rounds of
> > >> > >> internal review before posting v4)
> > >> > >>
> > >> > >> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com>
> > >> > >
> > >> > > OK, so how should they be routed?
> > >> >
> > >> > Good question. I don't know how last time PMIC drivers were
> > >> > merged, here I think is just sane to route vi MFD with immutable
> > >> > branch created.
> > >>
> > >> OK
> > >>
> > >> I will assume that the series will go in through MFD then.
> > >>
> > >
> > > Now that the MFD and GPIO patches of v6 of this series have been
> > > applied
> > on respective trees, can you advise the next steps for the ACPI / PMIC
> > Opregion driver?
> >
> > Well, it would have been better to route the whole series through one tree.
> > Now it's better to wait until the two other trees get merged and then
> > apply the opregion patch.
> >
> 
> Ack.
> Let me get back once the other 2 trees are merged.
> 

Both MFD and GPIO patches of this series got merged upstream as of today.

Thanks
Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael,

> Subject: RE: [PATCH v5 0/3] TPS68470 PMIC drivers
> 
> Hi Rafael,
> 
> > >> > >> > This is the patch series for TPS68470 PMIC that works as a
> > >> > >> > camera
> > PMIC.
> > >> > >> >
> > >> > >> > The patch series provide the following 3 drivers, to help
> > >> > >> > configure the
> > >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC,
> > >> to be able to use the camera sensors connected to this PMIC.
> > >> > >> >
> > >> > >> > TPS68470 MFD driver:
> > >> > >> > This is the multi function driver that initializes the
> > >> > >> > TPS68470 PMIC and
> > >> supports the GPIO and Op Region functions.
> > >> > >> >
> > >> > >> > TPS68470 GPIO driver:
> > >> > >> > This is the PMIC GPIO driver that will be used by the OS
> > >> > >> > GPIO layer,
> > >> when the BIOS / firmware triggered GPIO access is done.
> > >> > >> >
> > >> > >> > TPS68470 Op Region driver:
> > >> > >> > This is the driver that will be invoked, when the BIOS /
> > >> > >> > firmware
> > >> configures the voltage / clock for the sensors / vcm devices
> > >> connected to the PMIC.
> > >> > >> >
> > >> > >>
> > >> > >> All three patches are good to me (we did few rounds of
> > >> > >> internal review before posting v4)
> > >> > >>
> > >> > >> Reviewed-by: Andy Shevchenko 
> > >> > >
> > >> > > OK, so how should they be routed?
> > >> >
> > >> > Good question. I don't know how last time PMIC drivers were
> > >> > merged, here I think is just sane to route vi MFD with immutable
> > >> > branch created.
> > >>
> > >> OK
> > >>
> > >> I will assume that the series will go in through MFD then.
> > >>
> > >
> > > Now that the MFD and GPIO patches of v6 of this series have been
> > > applied
> > on respective trees, can you advise the next steps for the ACPI / PMIC
> > Opregion driver?
> >
> > Well, it would have been better to route the whole series through one tree.
> > Now it's better to wait until the two other trees get merged and then
> > apply the opregion patch.
> >
> 
> Ack.
> Let me get back once the other 2 trees are merged.
> 

Both MFD and GPIO patches of this series got merged upstream as of today.

Thanks
Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael,

> >> > >> > This is the patch series for TPS68470 PMIC that works as a camera
> PMIC.
> >> > >> >
> >> > >> > The patch series provide the following 3 drivers, to help
> >> > >> > configure the
> >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC,
> >> to be able to use the camera sensors connected to this PMIC.
> >> > >> >
> >> > >> > TPS68470 MFD driver:
> >> > >> > This is the multi function driver that initializes the
> >> > >> > TPS68470 PMIC and
> >> supports the GPIO and Op Region functions.
> >> > >> >
> >> > >> > TPS68470 GPIO driver:
> >> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO
> >> > >> > layer,
> >> when the BIOS / firmware triggered GPIO access is done.
> >> > >> >
> >> > >> > TPS68470 Op Region driver:
> >> > >> > This is the driver that will be invoked, when the BIOS /
> >> > >> > firmware
> >> configures the voltage / clock for the sensors / vcm devices
> >> connected to the PMIC.
> >> > >> >
> >> > >>
> >> > >> All three patches are good to me (we did few rounds of internal
> >> > >> review before posting v4)
> >> > >>
> >> > >> Reviewed-by: Andy Shevchenko 
> >> > >
> >> > > OK, so how should they be routed?
> >> >
> >> > Good question. I don't know how last time PMIC drivers were merged,
> >> > here I think is just sane to route vi MFD with immutable branch
> >> > created.
> >>
> >> OK
> >>
> >> I will assume that the series will go in through MFD then.
> >>
> >
> > Now that the MFD and GPIO patches of v6 of this series have been applied
> on respective trees, can you advise the next steps for the ACPI / PMIC 
> Opregion
> driver?
> 
> Well, it would have been better to route the whole series through one tree.
> Now it's better to wait until the two other trees get merged and then apply 
> the
> opregion patch.
> 

Ack.
Let me get back once the other 2 trees are merged.

Thanks
Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Rafael,

> >> > >> > This is the patch series for TPS68470 PMIC that works as a camera
> PMIC.
> >> > >> >
> >> > >> > The patch series provide the following 3 drivers, to help
> >> > >> > configure the
> >> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC,
> >> to be able to use the camera sensors connected to this PMIC.
> >> > >> >
> >> > >> > TPS68470 MFD driver:
> >> > >> > This is the multi function driver that initializes the
> >> > >> > TPS68470 PMIC and
> >> supports the GPIO and Op Region functions.
> >> > >> >
> >> > >> > TPS68470 GPIO driver:
> >> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO
> >> > >> > layer,
> >> when the BIOS / firmware triggered GPIO access is done.
> >> > >> >
> >> > >> > TPS68470 Op Region driver:
> >> > >> > This is the driver that will be invoked, when the BIOS /
> >> > >> > firmware
> >> configures the voltage / clock for the sensors / vcm devices
> >> connected to the PMIC.
> >> > >> >
> >> > >>
> >> > >> All three patches are good to me (we did few rounds of internal
> >> > >> review before posting v4)
> >> > >>
> >> > >> Reviewed-by: Andy Shevchenko 
> >> > >
> >> > > OK, so how should they be routed?
> >> >
> >> > Good question. I don't know how last time PMIC drivers were merged,
> >> > here I think is just sane to route vi MFD with immutable branch
> >> > created.
> >>
> >> OK
> >>
> >> I will assume that the series will go in through MFD then.
> >>
> >
> > Now that the MFD and GPIO patches of v6 of this series have been applied
> on respective trees, can you advise the next steps for the ACPI / PMIC 
> Opregion
> driver?
> 
> Well, it would have been better to route the whole series through one tree.
> Now it's better to wait until the two other trees get merged and then apply 
> the
> opregion patch.
> 

Ack.
Let me get back once the other 2 trees are merged.

Thanks
Raj

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Tue, Aug 22, 2017 at 12:58 AM, Mani, Rajmohan
 wrote:
> Hi Andy,
>
>> > >> > This is the patch series for TPS68470 PMIC that works as a camera 
>> > >> > PMIC.
>> > >> >
>> > >> > The patch series provide the following 3 drivers, to help configure 
>> > >> > the
>> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be
>> able to use the camera sensors connected to this PMIC.
>> > >> >
>> > >> > TPS68470 MFD driver:
>> > >> > This is the multi function driver that initializes the TPS68470 PMIC 
>> > >> > and
>> supports the GPIO and Op Region functions.
>> > >> >
>> > >> > TPS68470 GPIO driver:
>> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer,
>> when the BIOS / firmware triggered GPIO access is done.
>> > >> >
>> > >> > TPS68470 Op Region driver:
>> > >> > This is the driver that will be invoked, when the BIOS / firmware
>> configures the voltage / clock for the sensors / vcm devices connected to the
>> PMIC.
>> > >> >
>> > >>
>> > >> All three patches are good to me (we did few rounds of internal
>> > >> review before posting v4)
>> > >>
>> > >> Reviewed-by: Andy Shevchenko 
>> > >
>> > > OK, so how should they be routed?
>> >
>> > Good question. I don't know how last time PMIC drivers were merged,
>> > here I think is just sane to route vi MFD with immutable branch
>> > created.
>>
>> OK
>>
>> I will assume that the series will go in through MFD then.
>>
>
> Now that the MFD and GPIO patches of v6 of this series have been applied on 
> respective trees, can you advise the next steps for the ACPI / PMIC Opregion 
> driver?

Well, it would have been better to route the whole series through one
tree.  Now it's better to wait until the two other trees get merged
and then apply the opregion patch.

Thanks,
Rafael

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Tue, Aug 22, 2017 at 12:58 AM, Mani, Rajmohan
 wrote:
> Hi Andy,
>
>> > >> > This is the patch series for TPS68470 PMIC that works as a camera 
>> > >> > PMIC.
>> > >> >
>> > >> > The patch series provide the following 3 drivers, to help configure 
>> > >> > the
>> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be
>> able to use the camera sensors connected to this PMIC.
>> > >> >
>> > >> > TPS68470 MFD driver:
>> > >> > This is the multi function driver that initializes the TPS68470 PMIC 
>> > >> > and
>> supports the GPIO and Op Region functions.
>> > >> >
>> > >> > TPS68470 GPIO driver:
>> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer,
>> when the BIOS / firmware triggered GPIO access is done.
>> > >> >
>> > >> > TPS68470 Op Region driver:
>> > >> > This is the driver that will be invoked, when the BIOS / firmware
>> configures the voltage / clock for the sensors / vcm devices connected to the
>> PMIC.
>> > >> >
>> > >>
>> > >> All three patches are good to me (we did few rounds of internal
>> > >> review before posting v4)
>> > >>
>> > >> Reviewed-by: Andy Shevchenko 
>> > >
>> > > OK, so how should they be routed?
>> >
>> > Good question. I don't know how last time PMIC drivers were merged,
>> > here I think is just sane to route vi MFD with immutable branch
>> > created.
>>
>> OK
>>
>> I will assume that the series will go in through MFD then.
>>
>
> Now that the MFD and GPIO patches of v6 of this series have been applied on 
> respective trees, can you advise the next steps for the ACPI / PMIC Opregion 
> driver?

Well, it would have been better to route the whole series through one
tree.  Now it's better to wait until the two other trees get merged
and then apply the opregion patch.

Thanks,
Rafael

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Andy,

> > >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> > >> >
> > >> > The patch series provide the following 3 drivers, to help configure the
> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be
> able to use the camera sensors connected to this PMIC.
> > >> >
> > >> > TPS68470 MFD driver:
> > >> > This is the multi function driver that initializes the TPS68470 PMIC 
> > >> > and
> supports the GPIO and Op Region functions.
> > >> >
> > >> > TPS68470 GPIO driver:
> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer,
> when the BIOS / firmware triggered GPIO access is done.
> > >> >
> > >> > TPS68470 Op Region driver:
> > >> > This is the driver that will be invoked, when the BIOS / firmware
> configures the voltage / clock for the sensors / vcm devices connected to the
> PMIC.
> > >> >
> > >>
> > >> All three patches are good to me (we did few rounds of internal
> > >> review before posting v4)
> > >>
> > >> Reviewed-by: Andy Shevchenko 
> > >
> > > OK, so how should they be routed?
> >
> > Good question. I don't know how last time PMIC drivers were merged,
> > here I think is just sane to route vi MFD with immutable branch
> > created.
> 
> OK
> 
> I will assume that the series will go in through MFD then.
> 

Now that the MFD and GPIO patches of v6 of this series have been applied on 
respective trees, can you advise the next steps for the ACPI / PMIC Opregion 
driver?

Thanks
Raj

RE: [PATCH v5 0/3] TPS68470 PMIC drivers

[Mani, Rajmohan]

Hi Andy,

> > >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> > >> >
> > >> > The patch series provide the following 3 drivers, to help configure the
> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be
> able to use the camera sensors connected to this PMIC.
> > >> >
> > >> > TPS68470 MFD driver:
> > >> > This is the multi function driver that initializes the TPS68470 PMIC 
> > >> > and
> supports the GPIO and Op Region functions.
> > >> >
> > >> > TPS68470 GPIO driver:
> > >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer,
> when the BIOS / firmware triggered GPIO access is done.
> > >> >
> > >> > TPS68470 Op Region driver:
> > >> > This is the driver that will be invoked, when the BIOS / firmware
> configures the voltage / clock for the sensors / vcm devices connected to the
> PMIC.
> > >> >
> > >>
> > >> All three patches are good to me (we did few rounds of internal
> > >> review before posting v4)
> > >>
> > >> Reviewed-by: Andy Shevchenko 
> > >
> > > OK, so how should they be routed?
> >
> > Good question. I don't know how last time PMIC drivers were merged,
> > here I think is just sane to route vi MFD with immutable branch
> > created.
> 
> OK
> 
> I will assume that the series will go in through MFD then.
> 

Now that the MFD and GPIO patches of v6 of this series have been applied on 
respective trees, can you advise the next steps for the ACPI / PMIC Opregion 
driver?

Thanks
Raj

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Saturday, July 22, 2017 08:15:33 PM Andy Shevchenko wrote:
> On Fri, Jul 21, 2017 at 11:51 PM, Rafael J. Wysocki  
> wrote:
> > On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
> >> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
> >> wrote:
> >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> >> >
> >> > The patch series provide the following 3 drivers, to help configure the 
> >> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to 
> >> > be able to use the camera sensors connected to this PMIC.
> >> >
> >> > TPS68470 MFD driver:
> >> > This is the multi function driver that initializes the TPS68470 PMIC and 
> >> > supports the GPIO and Op Region functions.
> >> >
> >> > TPS68470 GPIO driver:
> >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, 
> >> > when the BIOS / firmware triggered GPIO access is done.
> >> >
> >> > TPS68470 Op Region driver:
> >> > This is the driver that will be invoked, when the BIOS / firmware 
> >> > configures the voltage / clock for the sensors / vcm devices connected 
> >> > to the PMIC.
> >> >
> >>
> >> All three patches are good to me (we did few rounds of internal review
> >> before posting v4)
> >>
> >> Reviewed-by: Andy Shevchenko 
> >
> > OK, so how should they be routed?
> 
> Good question. I don't know how last time PMIC drivers were merged,
> here I think is just sane to route vi MFD with immutable branch
> created.

OK

I will assume that the series will go in through MFD then.

Thanks,
Rafael

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Saturday, July 22, 2017 08:15:33 PM Andy Shevchenko wrote:
> On Fri, Jul 21, 2017 at 11:51 PM, Rafael J. Wysocki  
> wrote:
> > On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
> >> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
> >> wrote:
> >> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> >> >
> >> > The patch series provide the following 3 drivers, to help configure the 
> >> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to 
> >> > be able to use the camera sensors connected to this PMIC.
> >> >
> >> > TPS68470 MFD driver:
> >> > This is the multi function driver that initializes the TPS68470 PMIC and 
> >> > supports the GPIO and Op Region functions.
> >> >
> >> > TPS68470 GPIO driver:
> >> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, 
> >> > when the BIOS / firmware triggered GPIO access is done.
> >> >
> >> > TPS68470 Op Region driver:
> >> > This is the driver that will be invoked, when the BIOS / firmware 
> >> > configures the voltage / clock for the sensors / vcm devices connected 
> >> > to the PMIC.
> >> >
> >>
> >> All three patches are good to me (we did few rounds of internal review
> >> before posting v4)
> >>
> >> Reviewed-by: Andy Shevchenko 
> >
> > OK, so how should they be routed?
> 
> Good question. I don't know how last time PMIC drivers were merged,
> here I think is just sane to route vi MFD with immutable branch
> created.

OK

I will assume that the series will go in through MFD then.

Thanks,
Rafael

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Andy Shevchenko]

On Fri, Jul 21, 2017 at 11:51 PM, Rafael J. Wysocki  wrote:
> On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
>> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
>> wrote:
>> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
>> >
>> > The patch series provide the following 3 drivers, to help configure the 
>> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
>> > able to use the camera sensors connected to this PMIC.
>> >
>> > TPS68470 MFD driver:
>> > This is the multi function driver that initializes the TPS68470 PMIC and 
>> > supports the GPIO and Op Region functions.
>> >
>> > TPS68470 GPIO driver:
>> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, when 
>> > the BIOS / firmware triggered GPIO access is done.
>> >
>> > TPS68470 Op Region driver:
>> > This is the driver that will be invoked, when the BIOS / firmware 
>> > configures the voltage / clock for the sensors / vcm devices connected to 
>> > the PMIC.
>> >
>>
>> All three patches are good to me (we did few rounds of internal review
>> before posting v4)
>>
>> Reviewed-by: Andy Shevchenko 
>
> OK, so how should they be routed?

Good question. I don't know how last time PMIC drivers were merged,
here I think is just sane to route vi MFD with immutable branch
created.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Andy Shevchenko]

On Fri, Jul 21, 2017 at 11:51 PM, Rafael J. Wysocki  wrote:
> On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
>> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
>> wrote:
>> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
>> >
>> > The patch series provide the following 3 drivers, to help configure the 
>> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
>> > able to use the camera sensors connected to this PMIC.
>> >
>> > TPS68470 MFD driver:
>> > This is the multi function driver that initializes the TPS68470 PMIC and 
>> > supports the GPIO and Op Region functions.
>> >
>> > TPS68470 GPIO driver:
>> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, when 
>> > the BIOS / firmware triggered GPIO access is done.
>> >
>> > TPS68470 Op Region driver:
>> > This is the driver that will be invoked, when the BIOS / firmware 
>> > configures the voltage / clock for the sensors / vcm devices connected to 
>> > the PMIC.
>> >
>>
>> All three patches are good to me (we did few rounds of internal review
>> before posting v4)
>>
>> Reviewed-by: Andy Shevchenko 
>
> OK, so how should they be routed?

Good question. I don't know how last time PMIC drivers were merged,
here I think is just sane to route vi MFD with immutable branch
created.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
> wrote:
> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> >
> > The patch series provide the following 3 drivers, to help configure the 
> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
> > able to use the camera sensors connected to this PMIC.
> >
> > TPS68470 MFD driver:
> > This is the multi function driver that initializes the TPS68470 PMIC and 
> > supports the GPIO and Op Region functions.
> >
> > TPS68470 GPIO driver:
> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, when 
> > the BIOS / firmware triggered GPIO access is done.
> >
> > TPS68470 Op Region driver:
> > This is the driver that will be invoked, when the BIOS / firmware 
> > configures the voltage / clock for the sensors / vcm devices connected to 
> > the PMIC.
> >
> 
> All three patches are good to me (we did few rounds of internal review
> before posting v4)
> 
> Reviewed-by: Andy Shevchenko 

OK, so how should they be routed?

Thanks,
Rafael

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Rafael J. Wysocki]

On Friday, July 21, 2017 06:20:15 PM Andy Shevchenko wrote:
> On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  
> wrote:
> > This is the patch series for TPS68470 PMIC that works as a camera PMIC.
> >
> > The patch series provide the following 3 drivers, to help configure the 
> > voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
> > able to use the camera sensors connected to this PMIC.
> >
> > TPS68470 MFD driver:
> > This is the multi function driver that initializes the TPS68470 PMIC and 
> > supports the GPIO and Op Region functions.
> >
> > TPS68470 GPIO driver:
> > This is the PMIC GPIO driver that will be used by the OS GPIO layer, when 
> > the BIOS / firmware triggered GPIO access is done.
> >
> > TPS68470 Op Region driver:
> > This is the driver that will be invoked, when the BIOS / firmware 
> > configures the voltage / clock for the sensors / vcm devices connected to 
> > the PMIC.
> >
> 
> All three patches are good to me (we did few rounds of internal review
> before posting v4)
> 
> Reviewed-by: Andy Shevchenko 

OK, so how should they be routed?

Thanks,
Rafael

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Andy Shevchenko]

On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  wrote:
> This is the patch series for TPS68470 PMIC that works as a camera PMIC.
>
> The patch series provide the following 3 drivers, to help configure the 
> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
> able to use the camera sensors connected to this PMIC.
>
> TPS68470 MFD driver:
> This is the multi function driver that initializes the TPS68470 PMIC and 
> supports the GPIO and Op Region functions.
>
> TPS68470 GPIO driver:
> This is the PMIC GPIO driver that will be used by the OS GPIO layer, when the 
> BIOS / firmware triggered GPIO access is done.
>
> TPS68470 Op Region driver:
> This is the driver that will be invoked, when the BIOS / firmware configures 
> the voltage / clock for the sensors / vcm devices connected to the PMIC.
>

All three patches are good to me (we did few rounds of internal review
before posting v4)

Reviewed-by: Andy Shevchenko 

> ---
>
> Update on 2 GPIO chips implementation over 1:
> - Attempted to implement 2 GPIO chips, but ran into couple of
>   issues in the kernel, so we couldn't get it to work.
> - It was decided to postpone this change, since it is not
>   critical
>
> Changes in v5:
> - MFD driver:
> - Fixed Kconfig description text
> - Addressed other comments from Lee, related to formatting
>
> - GPIO driver:
> - Formatted the file header text
>
> - Opregion driver:
> - Formatted the file header text
>
> Changes in v4:
> - MFD driver:
> - Removed board specific code and FIXME comment
> - Moved i2c.h include from tps68470.h to tps68470.c
> - Moved the TPS68470 REVID read code after PMIC reset
> - Fixed typo in debug error message (on failure of
>   devm_mfd_add_devices() )
> - Enhanced dependency on I2C by changing it to I2C=y
>   (to fix build errors if I2C is built as module
>e.g tps68470.c:71: undefined reference to `__devm_regmap_init_i2c'
>tps68470.c:117: undefined reference to `i2c_register_driver')
> - Removed most of the unused header file definitions
> - Moved devm_mfd_add_devices() after PMIC resett
> - Used probe_new() and removed i2c_device_id table
>
>   The following patch from Andy is needed for the driver to be
>   probed.
>   http://marc.info/?l=linux-acpi=150030081523885=2
>
> - GPIO driver:
> - Added newline at the end of Kconfig description
> - Updated commit message about the descriptive
>   names for the GPIOs and the typical usage model
>   of the GPIO driver
>
> - Opregion driver:
> - Added dependency on MFD_TPS68470
> - Converted 2 liner into one line code
>
> Changes in v3:
> - MFD driver:
> - Removed GPIO lookup table
> - Reverted to probe() for consistency
> - Addressed other comments from Andy
>
> - GPIO driver:
> - Removed the code that initializes the default values
>   of GPIOs to zeros
> - Used gpiochip_get_data() to access data inside the gpio_chip
>
> Changes in v2:
> - MFD driver:
> - Removed tps68470_* wrappers around regmap_* calls
> - Removed "struct tps68470"
> - used devm_mfd_add_devices and removed mutex in mfd driver
> - Added reasoning about the need of having mfd driver
>   as bool/builtin
>
> - Opregion driver:
> - renamed opregion driver file / internal symbol names
>   with tps68470_pmic*
> - Made opregion driver tables as const
> - Removed unused *handler_context in common handler
> - Replaced "int" with "unsigned int"
> - Changed to WARN macro to dev_warn()
> - Destroyed mutex on error
> - Added reasoning about the need of having Opregion driver
>   as bool/builtin
>
> - GPIO driver:
> - Implemented get_direction() in the GPIO driver
> - Setup gpio_chip.names
> - Moved the GPIO lookup table code inside mfd driver
> - Added reasoning about the need of having GPIO driver
>   as bool/builtin
>
> ---
>
> Rajmohan Mani (3):
>   mfd: Add new mfd device TPS68470
>   gpio: Add support for TPS68470 GPIOs
>   ACPI / PMIC: Add TI PMIC TPS68470 operation region driver
>
>  drivers/acpi/Kconfig  |  16 ++
>  drivers/acpi/Makefile |   2 +
>  drivers/acpi/pmic/tps68470_pmic.c | 455 
> ++
>  drivers/gpio/Kconfig  |  15 ++
>  drivers/gpio/Makefile |   1 +
>  drivers/gpio/gpio-tps68470.c  | 176 +++
>  drivers/mfd/Kconfig   |  18 ++
>  drivers/mfd/Makefile  |   1 +
>  drivers/mfd/tps68470.c| 106 +
>  include/linux/mfd/tps68470.h  |  97 

Re: [PATCH v5 0/3] TPS68470 PMIC drivers

[Andy Shevchenko]

On Fri, Jul 21, 2017 at 5:46 PM, Rajmohan Mani  wrote:
> This is the patch series for TPS68470 PMIC that works as a camera PMIC.
>
> The patch series provide the following 3 drivers, to help configure the 
> voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be 
> able to use the camera sensors connected to this PMIC.
>
> TPS68470 MFD driver:
> This is the multi function driver that initializes the TPS68470 PMIC and 
> supports the GPIO and Op Region functions.
>
> TPS68470 GPIO driver:
> This is the PMIC GPIO driver that will be used by the OS GPIO layer, when the 
> BIOS / firmware triggered GPIO access is done.
>
> TPS68470 Op Region driver:
> This is the driver that will be invoked, when the BIOS / firmware configures 
> the voltage / clock for the sensors / vcm devices connected to the PMIC.
>

All three patches are good to me (we did few rounds of internal review
before posting v4)

Reviewed-by: Andy Shevchenko 

> ---
>
> Update on 2 GPIO chips implementation over 1:
> - Attempted to implement 2 GPIO chips, but ran into couple of
>   issues in the kernel, so we couldn't get it to work.
> - It was decided to postpone this change, since it is not
>   critical
>
> Changes in v5:
> - MFD driver:
> - Fixed Kconfig description text
> - Addressed other comments from Lee, related to formatting
>
> - GPIO driver:
> - Formatted the file header text
>
> - Opregion driver:
> - Formatted the file header text
>
> Changes in v4:
> - MFD driver:
> - Removed board specific code and FIXME comment
> - Moved i2c.h include from tps68470.h to tps68470.c
> - Moved the TPS68470 REVID read code after PMIC reset
> - Fixed typo in debug error message (on failure of
>   devm_mfd_add_devices() )
> - Enhanced dependency on I2C by changing it to I2C=y
>   (to fix build errors if I2C is built as module
>e.g tps68470.c:71: undefined reference to `__devm_regmap_init_i2c'
>tps68470.c:117: undefined reference to `i2c_register_driver')
> - Removed most of the unused header file definitions
> - Moved devm_mfd_add_devices() after PMIC resett
> - Used probe_new() and removed i2c_device_id table
>
>   The following patch from Andy is needed for the driver to be
>   probed.
>   http://marc.info/?l=linux-acpi=150030081523885=2
>
> - GPIO driver:
> - Added newline at the end of Kconfig description
> - Updated commit message about the descriptive
>   names for the GPIOs and the typical usage model
>   of the GPIO driver
>
> - Opregion driver:
> - Added dependency on MFD_TPS68470
> - Converted 2 liner into one line code
>
> Changes in v3:
> - MFD driver:
> - Removed GPIO lookup table
> - Reverted to probe() for consistency
> - Addressed other comments from Andy
>
> - GPIO driver:
> - Removed the code that initializes the default values
>   of GPIOs to zeros
> - Used gpiochip_get_data() to access data inside the gpio_chip
>
> Changes in v2:
> - MFD driver:
> - Removed tps68470_* wrappers around regmap_* calls
> - Removed "struct tps68470"
> - used devm_mfd_add_devices and removed mutex in mfd driver
> - Added reasoning about the need of having mfd driver
>   as bool/builtin
>
> - Opregion driver:
> - renamed opregion driver file / internal symbol names
>   with tps68470_pmic*
> - Made opregion driver tables as const
> - Removed unused *handler_context in common handler
> - Replaced "int" with "unsigned int"
> - Changed to WARN macro to dev_warn()
> - Destroyed mutex on error
> - Added reasoning about the need of having Opregion driver
>   as bool/builtin
>
> - GPIO driver:
> - Implemented get_direction() in the GPIO driver
> - Setup gpio_chip.names
> - Moved the GPIO lookup table code inside mfd driver
> - Added reasoning about the need of having GPIO driver
>   as bool/builtin
>
> ---
>
> Rajmohan Mani (3):
>   mfd: Add new mfd device TPS68470
>   gpio: Add support for TPS68470 GPIOs
>   ACPI / PMIC: Add TI PMIC TPS68470 operation region driver
>
>  drivers/acpi/Kconfig  |  16 ++
>  drivers/acpi/Makefile |   2 +
>  drivers/acpi/pmic/tps68470_pmic.c | 455 
> ++
>  drivers/gpio/Kconfig  |  15 ++
>  drivers/gpio/Makefile |   1 +
>  drivers/gpio/gpio-tps68470.c  | 176 +++
>  drivers/mfd/Kconfig   |  18 ++
>  drivers/mfd/Makefile  |   1 +
>  drivers/mfd/tps68470.c| 106 +
>  include/linux/mfd/tps68470.h  |  97 
>  10 files changed, 887 insertions(+)
>