Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, 20 Jul 2012 17:03:59 +0200, richard -rw- weinberger said: > On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan wrote: > > Thank you for your interest in fixing this problem. When we decide to > > change this > > ID, we will conform to the MSFT guidelines on constructing this guest ID. > > > > I'm wondering why it hasn't been conform to the MSFT guidelines from > the very beginning on? It's a lot easier to sneak something cute into code when it isn't maintained in git repositories and mailing lists readable by everybody and their pet llama. I'll admit to not doing a *lot* of extensive review, but I try to at least read Kconfig patches (mostly out of self-defense so when I do a 'make oldconfig' I get presented with something useful ;) - and it's amazing how often I spot issues in stuff that's presumably already had several pair of eyeballs look at it already. Probably what happened - some programmer had a 60 hour week, wrote the code on a Friday and had a sudden attack of the sillies, and it went through a code review meeting, but they had to cover 800 lines of code in a one-hour meeting so nobody looked *too* close... pgpp8nmLjNzbq.pgp Description: PGP signature
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, 20 Jul 2012 17:03:59 +0200, richard -rw- weinberger said: On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan k...@microsoft.com wrote: Thank you for your interest in fixing this problem. When we decide to change this ID, we will conform to the MSFT guidelines on constructing this guest ID. I'm wondering why it hasn't been conform to the MSFT guidelines from the very beginning on? It's a lot easier to sneak something cute into code when it isn't maintained in git repositories and mailing lists readable by everybody and their pet llama. I'll admit to not doing a *lot* of extensive review, but I try to at least read Kconfig patches (mostly out of self-defense so when I do a 'make oldconfig' I get presented with something useful ;) - and it's amazing how often I spot issues in stuff that's presumably already had several pair of eyeballs look at it already. Probably what happened - some programmer had a 60 hour week, wrote the code on a Friday and had a sudden attack of the sillies, and it went through a code review meeting, but they had to cover 800 lines of code in a one-hour meeting so nobody looked *too* close... pgpp8nmLjNzbq.pgp Description: PGP signature
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: richard -rw- weinberger [mailto:richard.weinber...@gmail.com] > Sent: Friday, July 20, 2012 11:04 AM > To: KY Srinivasan > Cc: Bjørn Mork; Greg KH (gre...@linuxfoundation.org); Paolo Bonzini; > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan wrote: > > Thank you for your interest in fixing this problem. When we decide to change > this > > ID, we will conform to the MSFT guidelines on constructing this guest ID. > > > > I'm wondering why it hasn't been conform to the MSFT guidelines from > the very beginning on? Great question; this was before my time in MSFT and so I cannot answer that. Regards, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan wrote: > Thank you for your interest in fixing this problem. When we decide to change > this > ID, we will conform to the MSFT guidelines on constructing this guest ID. > I'm wondering why it hasn't been conform to the MSFT guidelines from the very beginning on? -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message-
> From: Bjørn Mork [mailto:bj...@mork.no]
> Sent: Friday, July 20, 2012 3:59 AM
> To: KY Srinivasan
> Cc: Greg KH (gre...@linuxfoundation.org); Paolo Bonzini;
> de...@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> virtualizat...@lists.osdl.org
> Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the
> drivers/staging/ directory)
>
> KY Srinivasan writes:
>
> > Here is the link that describes how the guest ID should be composed:
> >
> > http://msdn.microsoft.com/en-
> us/library/windows/hardware/ff542653%28v=vs.85%29.aspx
>
> The unwanted value does not conform to those rules: Linux is not yet at
> major version 0xB5.
>
> I propose that you change this into a macro actually taking the OS
> major/minor version into account, keeping the 0xB16B vendor ID (which
> seems safest as the vendor ID registration process seems a bit unclear)
Thank you for your interest in fixing this problem. When we decide to change
this
ID, we will conform to the MSFT guidelines on constructing this guest ID.
Regards,
K. Y
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
KY Srinivasan writes: > Here is the link that describes how the guest ID should be composed: > > http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx The unwanted value does not conform to those rules: Linux is not yet at major version 0xB5. I propose that you change this into a macro actually taking the OS major/minor version into account, keeping the 0xB16B vendor ID (which seems safest as the vendor ID registration process seems a bit unclear) Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
KY Srinivasan k...@microsoft.com writes: Here is the link that describes how the guest ID should be composed: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx The unwanted value does not conform to those rules: Linux is not yet at major version 0xB5. I propose that you change this into a macro actually taking the OS major/minor version into account, keeping the 0xB16B vendor ID (which seems safest as the vendor ID registration process seems a bit unclear) Bjørn -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message-
From: Bjørn Mork [mailto:bj...@mork.no]
Sent: Friday, July 20, 2012 3:59 AM
To: KY Srinivasan
Cc: Greg KH (gre...@linuxfoundation.org); Paolo Bonzini;
de...@linuxdriverproject.org; linux-kernel@vger.kernel.org;
virtualizat...@lists.osdl.org
Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the
drivers/staging/ directory)
KY Srinivasan k...@microsoft.com writes:
Here is the link that describes how the guest ID should be composed:
http://msdn.microsoft.com/en-
us/library/windows/hardware/ff542653%28v=vs.85%29.aspx
The unwanted value does not conform to those rules: Linux is not yet at
major version 0xB5.
I propose that you change this into a macro actually taking the OS
major/minor version into account, keeping the 0xB16B vendor ID (which
seems safest as the vendor ID registration process seems a bit unclear)
Thank you for your interest in fixing this problem. When we decide to change
this
ID, we will conform to the MSFT guidelines on constructing this guest ID.
Regards,
K. Y
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan k...@microsoft.com wrote: Thank you for your interest in fixing this problem. When we decide to change this ID, we will conform to the MSFT guidelines on constructing this guest ID. I'm wondering why it hasn't been conform to the MSFT guidelines from the very beginning on? -- Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: richard -rw- weinberger [mailto:richard.weinber...@gmail.com] Sent: Friday, July 20, 2012 11:04 AM To: KY Srinivasan Cc: Bjørn Mork; Greg KH (gre...@linuxfoundation.org); Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Fri, Jul 20, 2012 at 4:00 PM, KY Srinivasan k...@microsoft.com wrote: Thank you for your interest in fixing this problem. When we decide to change this ID, we will conform to the MSFT guidelines on constructing this guest ID. I'm wondering why it hasn't been conform to the MSFT guidelines from the very beginning on? Great question; this was before my time in MSFT and so I cannot answer that. Regards, -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Greg KH (gre...@linuxfoundation.org) > [mailto:gre...@linuxfoundation.org] > Sent: Thursday, July 19, 2012 7:29 PM > To: KY Srinivasan > Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote: > > > > As you know, this ID has been in use for a long time now. While the > hypervisor > > > > does not interpret the guest ID that is registered, I am not sure what > > > dependencies > > > > there might be on this value. > > > > > > Could you please go find out the answer to this? > > > > That is easier said than done. I have sent emails out asking this very > > question > and I have > > not received a definitive answer yet. Not knowing if and when I can get a > definitive > > answer here, I chose the least risky approach in my patch. > > What happens if you test with different values? Nothing and that is not the issue. Current MSFT hypervisors don't interpret this ID value while future versions might. However, this ID can be retrieved by the parent partition and can be used by the management stack today (that is what I am told). > > > > If, as you originally stated, there is a range of values we can use, > > > then we should probably use another one, right? > > > > On the Windows side this ID namespace is managed well. > > It is? How is this managed? What does this tell the hypervisor? What > changes with the different values? > > > However on the Linux side, we have really had this current ID in use > > for almost five years now. I am not aware of any pool of IDs available > > for Linux usage except that Linux IDs be distinct from the guest IDs > > in use by MSFT operating systems. If I were to change the guest ID, I > > would probably want to comply with the MSFT guidance on constructing > > these IDs (although not all fields may be relevant for Linux). > > What are those rules? Here is the link that describes how the guest ID should be composed: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Thursday, July 19, 2012 7:18 PM > To: KY Srinivasan > Cc: Greg KH (gre...@linuxfoundation.org); Paolo Bonzini; > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On 07/19/2012 05:30 PM, KY Srinivasan wrote: > > > > > >> -Original Message- > >> From: Greg KH (gre...@linuxfoundation.org) > >> [mailto:gre...@linuxfoundation.org] > >> Sent: Thursday, July 19, 2012 6:02 PM > >> To: KY Srinivasan > >> Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; > >> virtualizat...@lists.osdl.org > >> Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > >> drivers/staging/ directory) > >> > >> On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: > >>> > >>> > >>>> -Original Message- > >>>> From: Greg KH (gre...@linuxfoundation.org) > >>>> [mailto:gre...@linuxfoundation.org] > >>>> Sent: Thursday, July 19, 2012 5:07 PM > >>>> To: KY Srinivasan > >>>> Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- > >> ker...@vger.kernel.org; > >>>> virtualizat...@lists.osdl.org > >>>> Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > >>>> drivers/staging/ directory) > >>>> > >>>> On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > >>>>> > >>>>> > >>>>>> -Original Message----- > >>>>>> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of > Paolo > >>>>>> Bonzini > >>>>>> Sent: Friday, July 13, 2012 6:23 AM > >>>>>> To: KY Srinivasan > >>>>>> Cc: Greg KH; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; > >>>>>> virtualizat...@lists.osdl.org > >>>>>> Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > >>>> drivers/staging/ > >>>>>> directory) > >>>>>> > >>>>>> Il 04/10/2011 21:34, Greg KH ha scritto: > >>>>>>> diff --git a/drivers/staging/hv/hyperv_vmbus.h > >>>> b/drivers/hv/hyperv_vmbus.h > >>>>>>> similarity index 99% > >>>>>>> rename from drivers/staging/hv/hyperv_vmbus.h > >>>>>>> rename to drivers/hv/hyperv_vmbus.h > >>>>>>> index 3d2d836..8261cb6 100644 > >>>>>>> --- a/drivers/staging/hv/hyperv_vmbus.h > >>>>>>> +++ b/drivers/hv/hyperv_vmbus.h > >>>>>>> @@ -28,8 +28,7 @@ > >>>>>>> #include > >>>>>>> #include > >>>>>>> #include > >>>>>>> - > >>>>>>> -#include "hyperv.h" > >>>>>>> +#include > >>>>>>> > >>>>>>> /* > >>>>>>>* The below CPUID leaves are present if > >>>>>> VersionAndFeatures.HypervisorPresent > >>>>>> > >>>>>> git's rename detection snips away this gem: > >>>>>> > >>>>>> +#define HV_LINUX_GUEST_ID_LO 0x > >>>>>> +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > >>>>>> +#define HV_LINUX_GUEST_ID > (((u64)HV_LINUX_GUEST_ID_HI > >>>>>> << 32) | \ > >>>>>> + HV_LINUX_GUEST_ID_LO) > >>>>>> > >>>>>> Somone was trying to be funny, I guess. > >>>>>> > >>>>>> KY, I suppose you have access to Hyper-V code or can ask someone who > >>>> does. > >>>>>> Is this signature actually used in the Hyper-V host code? > >>>>> > >>>>> Paolo, > >>>>> > >>>>> As I noted earlier, this is just a guest ID that needs to be registered > >>>>> with > the > >>>>> hypervisor. Thanks for reporting this issue and on behalf of > >>>>> Microsoft, I > >> would > >>>>> like to a
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote: > > > As you know, this ID has been in use for a long time now. While the > > > hypervisor > > > does not interpret the guest ID that is registered, I am not sure what > > dependencies > > > there might be on this value. > > > > Could you please go find out the answer to this? > > That is easier said than done. I have sent emails out asking this very > question and I have > not received a definitive answer yet. Not knowing if and when I can get a > definitive > answer here, I chose the least risky approach in my patch. What happens if you test with different values? > > If, as you originally stated, there is a range of values we can use, > > then we should probably use another one, right? > > On the Windows side this ID namespace is managed well. It is? How is this managed? What does this tell the hypervisor? What changes with the different values? > However on the Linux side, we have really had this current ID in use > for almost five years now. I am not aware of any pool of IDs available > for Linux usage except that Linux IDs be distinct from the guest IDs > in use by MSFT operating systems. If I were to change the guest ID, I > would probably want to comply with the MSFT guidance on constructing > these IDs (although not all fields may be relevant for Linux). What are those rules? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On 07/19/2012 05:30 PM, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 6:02 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include #include #include - -#include "hyperv.h" +#include /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI << 32) | \ + HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). Presumably, Hyper-V can deal with unexpected values here, no? Otherwise, it wouldn't be future proof against new types of guests. So worst case scenario, Hyper-V disables optimizations on Linux guests that report then new ID until they patch Hyper-V to know about the new ID. That seems like a reasonable trade off to me. I'm sure there's sufficient incentive to patch Hyper-V for this at Microsoft... Regards, Anthony Liguori Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Greg KH (gre...@linuxfoundation.org) > [mailto:gre...@linuxfoundation.org] > Sent: Thursday, July 19, 2012 6:02 PM > To: KY Srinivasan > Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: > > > > > > > -Original Message- > > > From: Greg KH (gre...@linuxfoundation.org) > > > [mailto:gre...@linuxfoundation.org] > > > Sent: Thursday, July 19, 2012 5:07 PM > > > To: KY Srinivasan > > > Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; > > > virtualizat...@lists.osdl.org > > > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > > > drivers/staging/ directory) > > > > > > On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > > > > > > > > > > > > -Original Message- > > > > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of > > > > > Paolo > > > > > Bonzini > > > > > Sent: Friday, July 13, 2012 6:23 AM > > > > > To: KY Srinivasan > > > > > Cc: Greg KH; de...@linuxdriverproject.org; > > > > > linux-kernel@vger.kernel.org; > > > > > virtualizat...@lists.osdl.org > > > > > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > > > drivers/staging/ > > > > > directory) > > > > > > > > > > Il 04/10/2011 21:34, Greg KH ha scritto: > > > > > > diff --git a/drivers/staging/hv/hyperv_vmbus.h > > > b/drivers/hv/hyperv_vmbus.h > > > > > > similarity index 99% > > > > > > rename from drivers/staging/hv/hyperv_vmbus.h > > > > > > rename to drivers/hv/hyperv_vmbus.h > > > > > > index 3d2d836..8261cb6 100644 > > > > > > --- a/drivers/staging/hv/hyperv_vmbus.h > > > > > > +++ b/drivers/hv/hyperv_vmbus.h > > > > > > @@ -28,8 +28,7 @@ > > > > > > #include > > > > > > #include > > > > > > #include > > > > > > - > > > > > > -#include "hyperv.h" > > > > > > +#include > > > > > > > > > > > > /* > > > > > > * The below CPUID leaves are present if > > > > > VersionAndFeatures.HypervisorPresent > > > > > > > > > > git's rename detection snips away this gem: > > > > > > > > > > +#define HV_LINUX_GUEST_ID_LO 0x > > > > > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > > > > > +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI > > > > > << 32) | \ > > > > > +HV_LINUX_GUEST_ID_LO) > > > > > > > > > > Somone was trying to be funny, I guess. > > > > > > > > > > KY, I suppose you have access to Hyper-V code or can ask someone who > > > does. > > > > > Is this signature actually used in the Hyper-V host code? > > > > > > > > Paolo, > > > > > > > > As I noted earlier, this is just a guest ID that needs to be registered > > > > with the > > > > hypervisor. Thanks for reporting this issue and on behalf of > > > > Microsoft, I > would > > > > like to apologize for this offensive string. I have submitted a patch > > > > to fix this > > > issue. > > > > > > You only changed it to be in decimal, you did not change the id at all. > > > Is there some reason why you can not change it? You said there was a > > > reserved range of ids that could be used, perhaps just pick another one? > > > What is the valid range that can be used here? > > > > Greg, > > > > As you know, this ID has been in use for a long time now. While the > > hypervisor > > does not interpret the guest ID that is registered, I am not sure what > dependencies > > there might be on this value. > > Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. > > If, as you originally stated, there is a range of values we can use, > then we should probably use another one, right? On the Windows side this ID namespace is managed well. However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Greg KH (gre...@linuxfoundation.org) > > [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, July 19, 2012 5:07 PM > > To: KY Srinivasan > > Cc: Paolo Bonzini; de...@linuxdriverproject.org; > > linux-kernel@vger.kernel.org; > > virtualizat...@lists.osdl.org > > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > > drivers/staging/ directory) > > > > On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > > > > > > > > > -Original Message- > > > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > > > Bonzini > > > > Sent: Friday, July 13, 2012 6:23 AM > > > > To: KY Srinivasan > > > > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > > > > virtualizat...@lists.osdl.org > > > > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > > drivers/staging/ > > > > directory) > > > > > > > > Il 04/10/2011 21:34, Greg KH ha scritto: > > > > > diff --git a/drivers/staging/hv/hyperv_vmbus.h > > b/drivers/hv/hyperv_vmbus.h > > > > > similarity index 99% > > > > > rename from drivers/staging/hv/hyperv_vmbus.h > > > > > rename to drivers/hv/hyperv_vmbus.h > > > > > index 3d2d836..8261cb6 100644 > > > > > --- a/drivers/staging/hv/hyperv_vmbus.h > > > > > +++ b/drivers/hv/hyperv_vmbus.h > > > > > @@ -28,8 +28,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > - > > > > > -#include "hyperv.h" > > > > > +#include > > > > > > > > > > /* > > > > > * The below CPUID leaves are present if > > > > VersionAndFeatures.HypervisorPresent > > > > > > > > git's rename detection snips away this gem: > > > > > > > > +#define HV_LINUX_GUEST_ID_LO 0x > > > > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > > > > +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI > > > > << 32) | \ > > > > + HV_LINUX_GUEST_ID_LO) > > > > > > > > Somone was trying to be funny, I guess. > > > > > > > > KY, I suppose you have access to Hyper-V code or can ask someone who > > does. > > > > Is this signature actually used in the Hyper-V host code? > > > > > > Paolo, > > > > > > As I noted earlier, this is just a guest ID that needs to be registered > > > with the > > > hypervisor. Thanks for reporting this issue and on behalf of Microsoft, > > > I would > > > like to apologize for this offensive string. I have submitted a patch to > > > fix this > > issue. > > > > You only changed it to be in decimal, you did not change the id at all. > > Is there some reason why you can not change it? You said there was a > > reserved range of ids that could be used, perhaps just pick another one? > > What is the valid range that can be used here? > > Greg, > > As you know, this ID has been in use for a long time now. While the hypervisor > does not interpret the guest ID that is registered, I am not sure what > dependencies > there might be on this value. Could you please go find out the answer to this? If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Greg KH (gre...@linuxfoundation.org) > [mailto:gre...@linuxfoundation.org] > Sent: Thursday, July 19, 2012 5:07 PM > To: KY Srinivasan > Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > > > > > > -Original Message- > > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > > Bonzini > > > Sent: Friday, July 13, 2012 6:23 AM > > > To: KY Srinivasan > > > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > > > virtualizat...@lists.osdl.org > > > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ > > > directory) > > > > > > Il 04/10/2011 21:34, Greg KH ha scritto: > > > > diff --git a/drivers/staging/hv/hyperv_vmbus.h > b/drivers/hv/hyperv_vmbus.h > > > > similarity index 99% > > > > rename from drivers/staging/hv/hyperv_vmbus.h > > > > rename to drivers/hv/hyperv_vmbus.h > > > > index 3d2d836..8261cb6 100644 > > > > --- a/drivers/staging/hv/hyperv_vmbus.h > > > > +++ b/drivers/hv/hyperv_vmbus.h > > > > @@ -28,8 +28,7 @@ > > > > #include > > > > #include > > > > #include > > > > - > > > > -#include "hyperv.h" > > > > +#include > > > > > > > > /* > > > > * The below CPUID leaves are present if > > > VersionAndFeatures.HypervisorPresent > > > > > > git's rename detection snips away this gem: > > > > > > +#define HV_LINUX_GUEST_ID_LO 0x > > > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > > > +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI > > > << 32) | \ > > > +HV_LINUX_GUEST_ID_LO) > > > > > > Somone was trying to be funny, I guess. > > > > > > KY, I suppose you have access to Hyper-V code or can ask someone who > does. > > > Is this signature actually used in the Hyper-V host code? > > > > Paolo, > > > > As I noted earlier, this is just a guest ID that needs to be registered > > with the > > hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I > > would > > like to apologize for this offensive string. I have submitted a patch to > > fix this > issue. > > You only changed it to be in decimal, you did not change the id at all. > Is there some reason why you can not change it? You said there was a > reserved range of ids that could be used, perhaps just pick another one? > What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. That is the reason I am reluctant to change the value. Since the hex representation of this constant was what was offensive, changing it to a decimal number would not break anything while simultaneously addressing the issue Paolo brought up. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > Bonzini > > Sent: Friday, July 13, 2012 6:23 AM > > To: KY Srinivasan > > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > > virtualizat...@lists.osdl.org > > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the > > drivers/staging/ > > directory) > > > > Il 04/10/2011 21:34, Greg KH ha scritto: > > > diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h > > > similarity index 99% > > > rename from drivers/staging/hv/hyperv_vmbus.h > > > rename to drivers/hv/hyperv_vmbus.h > > > index 3d2d836..8261cb6 100644 > > > --- a/drivers/staging/hv/hyperv_vmbus.h > > > +++ b/drivers/hv/hyperv_vmbus.h > > > @@ -28,8 +28,7 @@ > > > #include > > > #include > > > #include > > > - > > > -#include "hyperv.h" > > > +#include > > > > > > /* > > > * The below CPUID leaves are present if > > VersionAndFeatures.HypervisorPresent > > > > git's rename detection snips away this gem: > > > > +#define HV_LINUX_GUEST_ID_LO 0x > > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > > +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI > > << 32) | \ > > + HV_LINUX_GUEST_ID_LO) > > > > Somone was trying to be funny, I guess. > > > > KY, I suppose you have access to Hyper-V code or can ask someone who does. > > Is this signature actually used in the Hyper-V host code? > > Paolo, > > As I noted earlier, this is just a guest ID that needs to be registered with > the > hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I > would > like to apologize for this offensive string. I have submitted a patch to fix > this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Thursday, July 19, 2012 11:30 AM > To: KY Srinivasan > Cc: Paolo Bonzini; Greg KH (gre...@linuxfoundation.org); > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > > As I noted earlier, this is just a guest ID that needs to be > > registered with the hypervisor. Thanks for reporting this issue and > > on behalf of Microsoft, I would like to apologize for this offensive > > string. I have submitted a patch to fix this issue. > > Ok, quick question: > > http://msdn.microsoft.com/en- > us/library/windows/hardware/ff542653%28v=vs.85%29.aspx > > says that that guest ID encodes a bunch of version numbers and IDs > pertaining to the guest OS. And in that case, I would've thought > you'd encode kernel versions or whatever like it is done with > LINUX_VERSION_CODE, for example. > > How does this define fit with that scheme or was it chosen completely > arbitrarily? From what I know, this constant was chosen I think, completely arbitrarily. Currently, the hypervisor does not interpret this, however the host partition can retrieve it. Regards, K. Y
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: > As I noted earlier, this is just a guest ID that needs to be > registered with the hypervisor. Thanks for reporting this issue and > on behalf of Microsoft, I would like to apologize for this offensive > string. I have submitted a patch to fix this issue. Ok, quick question: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx says that that guest ID encodes a bunch of version numbers and IDs pertaining to the guest OS. And in that case, I would've thought you'd encode kernel versions or whatever like it is done with LINUX_VERSION_CODE, for example. How does this define fit with that scheme or was it chosen completely arbitrarily? Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. Ok, quick question: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx says that that guest ID encodes a bunch of version numbers and IDs pertaining to the guest OS. And in that case, I would've thought you'd encode kernel versions or whatever like it is done with LINUX_VERSION_CODE, for example. How does this define fit with that scheme or was it chosen completely arbitrarily? Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Thursday, July 19, 2012 11:30 AM To: KY Srinivasan Cc: Paolo Bonzini; Greg KH (gre...@linuxfoundation.org); de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. Ok, quick question: http://msdn.microsoft.com/en- us/library/windows/hardware/ff542653%28v=vs.85%29.aspx says that that guest ID encodes a bunch of version numbers and IDs pertaining to the guest OS. And in that case, I would've thought you'd encode kernel versions or whatever like it is done with LINUX_VERSION_CODE, for example. How does this define fit with that scheme or was it chosen completely arbitrarily? From what I know, this constant was chosen I think, completely arbitrarily. Currently, the hypervisor does not interpret this, however the host partition can retrieve it. Regards, K. Y
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI 32) | \ + HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI 32) | \ +HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. That is the reason I am reluctant to change the value. Since the hex representation of this constant was what was offensive, changing it to a decimal number would not break anything while simultaneously addressing the issue Paolo brought up. Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI 32) | \ + HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 6:02 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI 32) | \ +HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On 07/19/2012 05:30 PM, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 6:02 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #includelinux/list.h #includeasm/sync_bitops.h #includelinux/atomic.h - -#include hyperv.h +#includelinux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI 32) | \ + HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). Presumably, Hyper-V can deal with unexpected values here, no? Otherwise, it wouldn't be future proof against new types of guests. So worst case scenario, Hyper-V disables optimizations on Linux guests that report then new ID until they patch Hyper-V to know about the new ID. That seems like a reasonable trade off to me. I'm sure there's sufficient incentive to patch Hyper-V for this at Microsoft... Regards, Anthony Liguori Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote: As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. What happens if you test with different values? If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. It is? How is this managed? What does this tell the hypervisor? What changes with the different values? However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). What are those rules? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Anthony Liguori [mailto:anth...@codemonkey.ws] Sent: Thursday, July 19, 2012 7:18 PM To: KY Srinivasan Cc: Greg KH (gre...@linuxfoundation.org); Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On 07/19/2012 05:30 PM, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 6:02 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 09:22:53PM +, KY Srinivasan wrote: -Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 5:07 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 02:11:47AM +, KY Srinivasan wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux- ker...@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #includelinux/list.h #includeasm/sync_bitops.h #includelinux/atomic.h - -#include hyperv.h +#includelinux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID (((u64)HV_LINUX_GUEST_ID_HI 32) | \ + HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. You only changed it to be in decimal, you did not change the id at all. Is there some reason why you can not change it? You said there was a reserved range of ids that could be used, perhaps just pick another one? What is the valid range that can be used here? Greg, As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). Presumably, Hyper-V can deal with unexpected values here, no? Otherwise, it wouldn't be future proof against new types of guests. Anthony, As I noted earlier, the current versions of MSFT hypervisors don't interpret the guest ID value although future versions might. However, this ID may be retrieved from the parent partition and can be used by the management stack (today). So worst case scenario, Hyper-V disables optimizations on Linux guests that report then new ID until they patch Hyper-V to know
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Greg KH (gre...@linuxfoundation.org) [mailto:gre...@linuxfoundation.org] Sent: Thursday, July 19, 2012 7:29 PM To: KY Srinivasan Cc: Paolo Bonzini; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) On Thu, Jul 19, 2012 at 10:30:38PM +, KY Srinivasan wrote: As you know, this ID has been in use for a long time now. While the hypervisor does not interpret the guest ID that is registered, I am not sure what dependencies there might be on this value. Could you please go find out the answer to this? That is easier said than done. I have sent emails out asking this very question and I have not received a definitive answer yet. Not knowing if and when I can get a definitive answer here, I chose the least risky approach in my patch. What happens if you test with different values? Nothing and that is not the issue. Current MSFT hypervisors don't interpret this ID value while future versions might. However, this ID can be retrieved by the parent partition and can be used by the management stack today (that is what I am told). If, as you originally stated, there is a range of values we can use, then we should probably use another one, right? On the Windows side this ID namespace is managed well. It is? How is this managed? What does this tell the hypervisor? What changes with the different values? However on the Linux side, we have really had this current ID in use for almost five years now. I am not aware of any pool of IDs available for Linux usage except that Linux IDs be distinct from the guest IDs in use by MSFT operating systems. If I were to change the guest ID, I would probably want to comply with the MSFT guidance on constructing these IDs (although not all fields may be relevant for Linux). What are those rules? Here is the link that describes how the guest ID should be composed: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, July 13, 2012 6:23 AM > To: KY Srinivasan > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ > directory) > > Il 04/10/2011 21:34, Greg KH ha scritto: > > diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h > > similarity index 99% > > rename from drivers/staging/hv/hyperv_vmbus.h > > rename to drivers/hv/hyperv_vmbus.h > > index 3d2d836..8261cb6 100644 > > --- a/drivers/staging/hv/hyperv_vmbus.h > > +++ b/drivers/hv/hyperv_vmbus.h > > @@ -28,8 +28,7 @@ > > #include > > #include > > #include > > - > > -#include "hyperv.h" > > +#include > > > > /* > > * The below CPUID leaves are present if > VersionAndFeatures.HypervisorPresent > > git's rename detection snips away this gem: > > +#define HV_LINUX_GUEST_ID_LO 0x > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI > << 32) | \ > +HV_LINUX_GUEST_ID_LO) > > Somone was trying to be funny, I guess. > > KY, I suppose you have access to Hyper-V code or can ask someone who does. > Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI 32) | \ +HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? Paolo, As I noted earlier, this is just a guest ID that needs to be registered with the hypervisor. Thanks for reporting this issue and on behalf of Microsoft, I would like to apologize for this offensive string. I have submitted a patch to fix this issue. Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:00:57PM -0400, Steven Rostedt wrote: > I guess that's why it's in a file called hyPERV_vmbus. ;-) Ladies and gentlemen, Steve can see nastyness in an arbitrary ASCII string. 8-). -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:00:57PM -0400, Steven Rostedt wrote: I guess that's why it's in a file called hyPERV_vmbus. ;-) Ladies and gentlemen, Steve can see nastyness in an arbitrary ASCII string. 8-). -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:24:43PM +0200, Borislav Petkov wrote: > On Fri, Jul 13, 2012 at 03:15:29PM +0200, Paolo Bonzini wrote: > > Il 13/07/2012 15:13, KY Srinivasan ha scritto: > > >> > > > >> > Somone was trying to be funny, I guess. > > >> > > > >> > KY, I suppose you have access to Hyper-V code or can ask someone who > > >> > does. > > >> > Is this signature actually used in the Hyper-V host code? > > > It is still early in the morning here and pardon me if I am not seeing > > > the issue. > > > > [offlist] I guess not :-) > > > > 0xB16B00B5 = big boobs > > LOL! You can't make this stuff up! > I guess that's why it's in a file called hyPERV_vmbus. ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:15:29PM +0200, Paolo Bonzini wrote: > Il 13/07/2012 15:13, KY Srinivasan ha scritto: > >> > > >> > Somone was trying to be funny, I guess. > >> > > >> > KY, I suppose you have access to Hyper-V code or can ask someone who > >> > does. > >> > Is this signature actually used in the Hyper-V host code? > > It is still early in the morning here and pardon me if I am not seeing the > > issue. > > [offlist] > > 0xB16B00B5 = big boobs LOL! You can't make this stuff up! :-) -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Friday, July 13, 2012 9:15 AM > To: KY Srinivasan > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the > drivers/staging/ directory) > > Il 13/07/2012 15:13, KY Srinivasan ha scritto: > >> > > >> > Somone was trying to be funny, I guess. > >> > > >> > KY, I suppose you have access to Hyper-V code or can ask someone who > does. > >> > Is this signature actually used in the Hyper-V host code? > > It is still early in the morning here and pardon me if I am not seeing the > > issue. > > [offlist] > > 0xB16B00B5 = big boobs Ok! I don't know how easy it is to change this. If I remember correctly, I think on our Cloud (Azure), the guest ID may be currently used in our management stack. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
Il 13/07/2012 15:13, KY Srinivasan ha scritto: >> > >> > Somone was trying to be funny, I guess. >> > >> > KY, I suppose you have access to Hyper-V code or can ask someone who does. >> > Is this signature actually used in the Hyper-V host code? > It is still early in the morning here and pardon me if I am not seeing the > issue. [offlist] 0xB16B00B5 = big boobs Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, July 13, 2012 6:23 AM > To: KY Srinivasan > Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; > virtualizat...@lists.osdl.org > Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ > directory) > > Il 04/10/2011 21:34, Greg KH ha scritto: > > diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h > > similarity index 99% > > rename from drivers/staging/hv/hyperv_vmbus.h > > rename to drivers/hv/hyperv_vmbus.h > > index 3d2d836..8261cb6 100644 > > --- a/drivers/staging/hv/hyperv_vmbus.h > > +++ b/drivers/hv/hyperv_vmbus.h > > @@ -28,8 +28,7 @@ > > #include > > #include > > #include > > - > > -#include "hyperv.h" > > +#include > > > > /* > > * The below CPUID leaves are present if > VersionAndFeatures.HypervisorPresent > > git's rename detection snips away this gem: > > +#define HV_LINUX_GUEST_ID_LO 0x > +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 > +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI > << 32) | \ > +HV_LINUX_GUEST_ID_LO) > > Somone was trying to be funny, I guess. > > KY, I suppose you have access to Hyper-V code or can ask someone who does. > Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. Could you elaborate on what you want changed and why. This is a guest signature that is stashed away in the hypervisor and perhaps can be retrieved by the host. Other than that, this is not used anywhere else. MSFT has defined a a namespace for guest IDs and while some ranges are reserved for MSFT operating systems, there really is nothing special about the guest ID. Regards, K. Y -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Friday, July 13, 2012 6:23 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 04/10/2011 21:34, Greg KH ha scritto: diff --git a/drivers/staging/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h similarity index 99% rename from drivers/staging/hv/hyperv_vmbus.h rename to drivers/hv/hyperv_vmbus.h index 3d2d836..8261cb6 100644 --- a/drivers/staging/hv/hyperv_vmbus.h +++ b/drivers/hv/hyperv_vmbus.h @@ -28,8 +28,7 @@ #include linux/list.h #include asm/sync_bitops.h #include linux/atomic.h - -#include hyperv.h +#include linux/hyperv.h /* * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent git's rename detection snips away this gem: +#define HV_LINUX_GUEST_ID_LO 0x +#define HV_LINUX_GUEST_ID_HI 0xB16B00B5 +#define HV_LINUX_GUEST_ID(((u64)HV_LINUX_GUEST_ID_HI 32) | \ +HV_LINUX_GUEST_ID_LO) Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. Could you elaborate on what you want changed and why. This is a guest signature that is stashed away in the hypervisor and perhaps can be retrieved by the host. Other than that, this is not used anywhere else. MSFT has defined a a namespace for guest IDs and while some ranges are reserved for MSFT operating systems, there really is nothing special about the guest ID. Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
Il 13/07/2012 15:13, KY Srinivasan ha scritto: Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. [offlist] 0xB16B00B5 = big boobs Paolo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
-Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Friday, July 13, 2012 9:15 AM To: KY Srinivasan Cc: Greg KH; de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; virtualizat...@lists.osdl.org Subject: Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory) Il 13/07/2012 15:13, KY Srinivasan ha scritto: Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. [offlist] 0xB16B00B5 = big boobs Ok! I don't know how easy it is to change this. If I remember correctly, I think on our Cloud (Azure), the guest ID may be currently used in our management stack. Regards, K. Y -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:15:29PM +0200, Paolo Bonzini wrote: Il 13/07/2012 15:13, KY Srinivasan ha scritto: Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. [offlist] 0xB16B00B5 = big boobs LOL! You can't make this stuff up! :-) -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)
On Fri, Jul 13, 2012 at 03:24:43PM +0200, Borislav Petkov wrote: On Fri, Jul 13, 2012 at 03:15:29PM +0200, Paolo Bonzini wrote: Il 13/07/2012 15:13, KY Srinivasan ha scritto: Somone was trying to be funny, I guess. KY, I suppose you have access to Hyper-V code or can ask someone who does. Is this signature actually used in the Hyper-V host code? It is still early in the morning here and pardon me if I am not seeing the issue. [offlist] I guess not :-) 0xB16B00B5 = big boobs LOL! You can't make this stuff up! I guess that's why it's in a file called hyPERV_vmbus. ;-) -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
