Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Rafael J. Wysocki
On Sunday, 25 March 2007 17:10, Maxim wrote: > On Sunday 25 March 2007 14:13:07 Rafael J. Wysocki wrote: > > On Sunday, 25 March 2007 01:40, Maxim wrote: > > > On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: > > > > On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: > > > > > On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Maxim
On Sunday 25 March 2007 14:13:07 Rafael J. Wysocki wrote: > On Sunday, 25 March 2007 01:40, Maxim wrote: > > On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: > > > On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: > > > > On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Rafael J. Wysocki
On Sunday, 25 March 2007 01:40, Maxim wrote: > On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: > > On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: > > > On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: > > > > On Thursday, 22 March 2007 00:39, Maxim wrote: > > > > > On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Rafael J. Wysocki
On Sunday, 25 March 2007 01:40, Maxim wrote: On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Maxim
On Sunday 25 March 2007 14:13:07 Rafael J. Wysocki wrote: On Sunday, 25 March 2007 01:40, Maxim wrote: On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-25 Thread Rafael J. Wysocki
On Sunday, 25 March 2007 17:10, Maxim wrote: On Sunday 25 March 2007 14:13:07 Rafael J. Wysocki wrote: On Sunday, 25 March 2007 01:40, Maxim wrote: On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: On Thursday, 22

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-24 Thread Maxim
On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: > On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: > > On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: > > > On Thursday, 22 March 2007 00:39, Maxim wrote: > > > > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-24 Thread Maxim
On Friday 23 March 2007 16:42:44 Rafael J. Wysocki wrote: On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-23 Thread Rafael J. Wysocki
On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: > On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: > > On Thursday, 22 March 2007 00:39, Maxim wrote: > > > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > > > > On Thursday, 22 March 2007 00:09, Maxim wrote: > > > >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-23 Thread Rafael J. Wysocki
On Friday, 23 March 2007 00:30, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: > On Thursday, 22 March 2007 00:39, Maxim wrote: > > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > > > On Thursday, 22 March 2007 00:09, Maxim wrote: > > > > On Thursday 22 March 2007 00:39:02 you wrote: > > > > > On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 08:31, Andrew Morton wrote: > On Thu, 22 Mar 2007 08:23:39 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> > wrote: > > > On Thursday, 22 March 2007 05:51, David Chinner wrote: > > > On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > > > > > > > I

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 08:23:39 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 22 March 2007 05:51, David Chinner wrote: > > On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > > > > > I think this is the XFS problem with freezable workqueues. > > > > > >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 05:51, David Chinner wrote: > On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > > > I think this is the XFS problem with freezable workqueues. > > > > Maxim, please try to apply the appended patch and see if it helps. > > > > Greetings, > > Rafael

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 05:51, David Chinner wrote: On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: I think this is the XFS problem with freezable workqueues. Maxim, please try to apply the appended patch and see if it helps. Greetings, Rafael ---

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Andrew Morton
On Thu, 22 Mar 2007 08:23:39 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Thursday, 22 March 2007 05:51, David Chinner wrote: On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: I think this is the XFS problem with freezable workqueues. Maxim, please try to

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 08:31, Andrew Morton wrote: On Thu, 22 Mar 2007 08:23:39 +0100 Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Thursday, 22 March 2007 05:51, David Chinner wrote: On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: I think this is the XFS

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-22 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 00:53, Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread David Chinner
On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: > > I think this is the XFS problem with freezable workqueues. > > Maxim, please try to apply the appended patch and see if it helps. > > Greetings, > Rafael > > > --- > Since freezable workqueues are broken in 2.6.21-rc >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:14:05 Maxim wrote: > On Wednesday 21 March 2007 23:22:40 Nigel Cunningham wrote: > > Hi. > > > > On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: > > > Hi, > > > > > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on > > > my system.

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:47:05 Nigel Cunningham wrote: > Hi. > > On Wed, 2007-03-21 at 22:38 +0100, Rafael J. Wysocki wrote: > > > Do you know exactly which mutex was being waited on and where it was > > > taken? If you can say that, it would be much more helpful. > > Yeah, me too, but

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:53:54 Rafael J. Wysocki wrote: > On Thursday, 22 March 2007 00:39, Maxim wrote: > > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > > > On Thursday, 22 March 2007 00:09, Maxim wrote: > > > > On Thursday 22 March 2007 00:39:02 you wrote: > > > > > On

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 00:39, Maxim wrote: > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > > On Thursday, 22 March 2007 00:09, Maxim wrote: > > > On Thursday 22 March 2007 00:39:02 you wrote: > > > > On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: > > > > > Hi! > > > > >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Nigel Cunningham
Hi. On Wed, 2007-03-21 at 22:38 +0100, Rafael J. Wysocki wrote: > > Do you know exactly which mutex was being waited on and where it was > > taken? If you can say that, it would be much more helpful. Yeah, me too, but assuming too much sometimes bites me :) > I think this is the XFS problem

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:39:24 Maxim wrote: > On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > > On Thursday, 22 March 2007 00:09, Maxim wrote: > > > On Thursday 22 March 2007 00:39:02 you wrote: > > > > On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: > > > > > Hi! > > > >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: > On Thursday, 22 March 2007 00:09, Maxim wrote: > > On Thursday 22 March 2007 00:39:02 you wrote: > > > On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: > > > > Hi! > > > > > > > > > Starting with 2.6.21-rc1 suspend to ram and

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:09:54 Maxim wrote: > On Thursday 22 March 2007 00:39:02 you wrote: > > On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: > > > Hi! > > > > > > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore > > > > on my system. > > > > > > > > I did a

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:14:05 Maxim wrote: > On Wednesday 21 March 2007 23:22:40 Nigel Cunningham wrote: > > Hi. > > > > On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: > > > Hi, > > > > > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on > > > my system.

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: > Hi! > > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my > > system. > > > > I did a git-bisect and found that those commits break it: > > > > e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM:

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Pavel Machek
Hi! > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my > system. > > I did a git-bisect and found that those commits break it: > > e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM: Change code > ordering in main.c >

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Wednesday, 21 March 2007 22:22, Nigel Cunningham wrote: > Hi. > > On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: > > Hi, > > > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my > > system. > > > > I did a git-bisect and found that those commits break

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Nigel Cunningham
Hi. On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: > Hi, > > Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my > system. > > I did a git-bisect and found that those commits break it: > > e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM: Change

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Nigel Cunningham
Hi. On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: Hi, Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a git-bisect and found that those commits break it: e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM: Change code

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Wednesday, 21 March 2007 22:22, Nigel Cunningham wrote: Hi. On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: Hi, Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a git-bisect and found that those commits break it:

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Pavel Machek
Hi! Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a git-bisect and found that those commits break it: e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM: Change code ordering in main.c ed746e3b18f4df18afa3763155972c5835f284c5 -

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: Hi! Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a git-bisect and found that those commits break it: e3c7db621bed4afb8e231cb005057f2feb5db557 - [PATCH] [PATCH] PM: Change code

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:14:05 Maxim wrote: On Wednesday 21 March 2007 23:22:40 Nigel Cunningham wrote: Hi. On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: Hi, Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:09:54 Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: Hi! Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a git-bisect and found that

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: Hi! Starting with 2.6.21-rc1 suspend to ram and disk doesn't work

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:39:24 Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: Hi! Starting

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Nigel Cunningham
Hi. On Wed, 2007-03-21 at 22:38 +0100, Rafael J. Wysocki wrote: Do you know exactly which mutex was being waited on and where it was taken? If you can say that, it would be much more helpful. Yeah, me too, but assuming too much sometimes bites me :) I think this is the XFS problem with

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Rafael J. Wysocki
On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March 2007 23:21, Pavel Machek wrote: Hi! Starting

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:53:54 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:39, Maxim wrote: On Thursday 22 March 2007 01:24:25 Rafael J. Wysocki wrote: On Thursday, 22 March 2007 00:09, Maxim wrote: On Thursday 22 March 2007 00:39:02 you wrote: On Wednesday, 21 March

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:47:05 Nigel Cunningham wrote: Hi. On Wed, 2007-03-21 at 22:38 +0100, Rafael J. Wysocki wrote: Do you know exactly which mutex was being waited on and where it was taken? If you can say that, it would be much more helpful. Yeah, me too, but assuming too

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread Maxim
On Thursday 22 March 2007 01:14:05 Maxim wrote: On Wednesday 21 March 2007 23:22:40 Nigel Cunningham wrote: Hi. On Wed, 2007-03-21 at 18:40 +0200, Maxim Levitsky wrote: Hi, Starting with 2.6.21-rc1 suspend to ram and disk doesn't work anymore on my system. I did a

Re: [BUG] Code reordering in swsusp breaks suspend on SMP systems

2007-03-21 Thread David Chinner
On Wed, Mar 21, 2007 at 10:38:33PM +0100, Rafael J. Wysocki wrote: I think this is the XFS problem with freezable workqueues. Maxim, please try to apply the appended patch and see if it helps. Greetings, Rafael --- Since freezable workqueues are broken in 2.6.21-rc (cf.