Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Thu, 2018-07-05 at 14:51 +0100, Mark Rutland wrote: > On Sun, Apr 15, 2018 at 12:26:44AM +0200, KarimAllah Ahmed wrote: > > > > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > > use the size of "requests" instead of the hard-coded '32'. > > > > That gives us a bit

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Thu, 2018-07-05 at 14:51 +0100, Mark Rutland wrote: > On Sun, Apr 15, 2018 at 12:26:44AM +0200, KarimAllah Ahmed wrote: > > > > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > > use the size of "requests" instead of the hard-coded '32'. > > > > That gives us a bit

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, Apr 15, 2018 at 12:26:44AM +0200, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, Apr 15, 2018 at 12:26:44AM +0200, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 05/07/2018 14:22, Raslan, KarimAllah wrote: >> They don't support atomics on double-word data. > But they support atomics on single words. Of which there are two. > We don't need atomic updates of the whole 64-bit quantity (a là  > cmpxchg). Do we strictly need this to be atomic accross the

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 05/07/2018 14:22, Raslan, KarimAllah wrote: >> They don't support atomics on double-word data. > But they support atomics on single words. Of which there are two. > We don't need atomic updates of the whole 64-bit quantity (a là  > cmpxchg). Do we strictly need this to be atomic accross the

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Tue, 2018-05-22 at 17:47 +0200, Paolo Bonzini wrote: > On 22/05/2018 17:42, Raslan, KarimAllah wrote: > > > > On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: > > > > > > On 15/04/2018 00:26, KarimAllah Ahmed wrote: > > > > > > > > > > > > Switch 'requests' to be explicitly 64-bit

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Tue, 2018-05-22 at 17:47 +0200, Paolo Bonzini wrote: > On 22/05/2018 17:42, Raslan, KarimAllah wrote: > > > > On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: > > > > > > On 15/04/2018 00:26, KarimAllah Ahmed wrote: > > > > > > > > > > > > Switch 'requests' to be explicitly 64-bit

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 22/05/2018 17:42, Raslan, KarimAllah wrote: > On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: >> On 15/04/2018 00:26, KarimAllah Ahmed wrote: >>> >>> Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to >>> use the size of "requests" instead of the hard-coded '32'.

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 22/05/2018 17:42, Raslan, KarimAllah wrote: > On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: >> On 15/04/2018 00:26, KarimAllah Ahmed wrote: >>> >>> Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to >>> use the size of "requests" instead of the hard-coded '32'.

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: > On 15/04/2018 00:26, KarimAllah Ahmed wrote: > > > > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > > use the size of "requests" instead of the hard-coded '32'. > > > > That gives us a bit more room again for

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Mon, 2018-04-16 at 18:28 +0200, Paolo Bonzini wrote: > On 15/04/2018 00:26, KarimAllah Ahmed wrote: > > > > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > > use the size of "requests" instead of the hard-coded '32'. > > > > That gives us a bit more room again for

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 15/04/2018 00:26, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of space for x86 due to

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On 15/04/2018 00:26, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of space for x86 due to

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, Apr 15, 2018 at 6:12 AM, Raslan, KarimAllah wrote: > On Sun, 2018-04-15 at 00:26 +0200, KarimAllah Ahmed wrote: >> Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to >> use the size of "requests" instead of the hard-coded '32'. >> >> That gives

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, Apr 15, 2018 at 6:12 AM, Raslan, KarimAllah wrote: > On Sun, 2018-04-15 at 00:26 +0200, KarimAllah Ahmed wrote: >> Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to >> use the size of "requests" instead of the hard-coded '32'. >> >> That gives us a bit more room

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, 2018-04-15 at 00:26 +0200, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of space

Re: [PATCH] KVM: Switch 'requests' to be 64-bit (explicitly)

On Sun, 2018-04-15 at 00:26 +0200, KarimAllah Ahmed wrote: > Switch 'requests' to be explicitly 64-bit and update BUILD_BUG_ON check to > use the size of "requests" instead of the hard-coded '32'. > > That gives us a bit more room again for arch-specific requests as we > already ran out of space